From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0417FC433E7 for ; Sun, 18 Oct 2020 18:50:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58FD522261 for ; Sun, 18 Oct 2020 18:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="MBf+vf9P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58FD522261 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 48D666B005D; Sun, 18 Oct 2020 14:50:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43D966B0062; Sun, 18 Oct 2020 14:50:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32CDC6B0068; Sun, 18 Oct 2020 14:50:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 06E0C6B005D for ; Sun, 18 Oct 2020 14:50:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 92A5B1EE6 for ; Sun, 18 Oct 2020 18:50:13 +0000 (UTC) X-FDA: 77385936306.23.jar44_2a11f7927230 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 6ED7237604 for ; Sun, 18 Oct 2020 18:50:13 +0000 (UTC) X-HE-Tag: jar44_2a11f7927230 X-Filterd-Recvd-Size: 3474 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Sun, 18 Oct 2020 18:50:12 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 18 Oct 2020 11:49:59 -0700 Received: from [10.2.63.174] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 18 Oct 2020 18:50:11 +0000 Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h To: Linus Torvalds , Andrew Morton CC: Jonathan Corbet , Jerome Glisse , Linux-MM , , Ralph Campbell , Shuah Khan , Jason Gary Gunthorpe References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org> <20201017231425.0OZYgQdDr%akpm@linux-foundation.org> From: John Hubbard Message-ID: Date: Sun, 18 Oct 2020 11:50:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603046999; bh=Y6f5/ocgp0jKWELcz24Z8GoYvJ/UjATW0tUfuazKbpg=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=MBf+vf9PtjhpqUsdNOSdNiT3xKt+FfQhmzz13wPkB/48kU3X/9oro/X8yFXhVxhCX M6Og/bzF9lKHE2b9OZxtzTadsdcf7XEMGLecKFQ0T23LLE3tkmfozd+ykclo/Jib/T C6D6bCTLJ/GFw4H6kstKe928ZBQFlt6nwM3NechhotdRN5xYkX/ZsyOdb92Rm5xD2D b/fv0ram7nqFLKV0jZWc3N/Zl5kWKWzLFEDMXD3ZEojKNt45LZEL/tHf8ewpFaOAZA CQUWsxroW/q7CUMAsC4re8Bc1d/vTIleNJkHum7eeC8eYjGaSy1CTOc9yDklbSGGMT Hl4w3EHVUsZJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/18/20 9:18 AM, Linus Torvalds wrote: > On Sat, Oct 17, 2020 at 4:14 PM Andrew Morton wrote: >> >> --- a/mm/gup_test.c~selftests-vm-use-a-common-gup_testh >> +++ a/mm/gup_test.c >> @@ -4,22 +4,7 @@ >> +#include "../../../../mm/gup_test.h" >> +++ a/mm/gup_test.h > > There is no way I'm applying a crazy patch like this. > > That can't be right. > > And even if it works, it *still* isn't right. > > Linus > I feel the same way about the ridiculous ../..'s in the include path. But that seemed to be the accepted way (I even have an email that I'm trying to find, in which someone confirmed that...ah here, it is [1], and I'm adding Jason to CC) for the odd situation of sharing a header file between kernel and user space, for the kselftest world. If there's a different acceptable way, I'd be delighted to use that. [1] https://lore.kernel.org/r/20200929163507.GV9916@ziepe.ca thanks, -- John Hubbard NVIDIA