From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F11EB64DA for ; Fri, 16 Jun 2023 18:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79F288E0001; Fri, 16 Jun 2023 14:47:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74E496B0075; Fri, 16 Jun 2023 14:47:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615DB8E0001; Fri, 16 Jun 2023 14:47:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 509CB6B0074 for ; Fri, 16 Jun 2023 14:47:16 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E14BF16082F for ; Fri, 16 Jun 2023 18:47:15 +0000 (UTC) X-FDA: 80909493630.28.A61CF07 Received: from smtp.smtpout.orange.fr (smtp-28.smtpout.orange.fr [80.12.242.28]) by imf05.hostedemail.com (Postfix) with ESMTP id E8934100009 for ; Fri, 16 Jun 2023 18:47:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=CSO71O13; spf=pass (imf05.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.28 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686941233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mjmm8to/bELzOA//iAPouJVx5kPEfLD/xVc4EtzWKJQ=; b=MsQ1JBUa+3mUU16qeQ5yEC3oSZ9yU2xkCq+yN0LRvGM5GiFIvuvpLdby1OmSYh5vuAxIbr vwW0wmldJ7zm7BeB3/e5itEL4mCM4qZkvs6SLM6941NlDkdfoGj+fwsaIBF2+3MWS7Lpge oQrWLJCKRs7nptD4sp33OrYlVW2jveA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=CSO71O13; spf=pass (imf05.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.28 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686941233; a=rsa-sha256; cv=none; b=J9hngmkY9wJ6dGpCYb8E5wEXEZiKz9KsMcdCD2sere1N5Y/0FkVvdltwIX3Zf601/KGxu+ XYEqNGxgxcDp4oD9ynMukHro0mZ/p18KRoSSh5eD6ay4Tvg0vsQ33CK0G5szlwVbhSvQu4 8FsIa3J08gBFBxhSmCS0Sxj2KFht3u8= Received: from [192.168.1.18] ([86.243.2.178]) by smtp.orange.fr with ESMTPA id AETTqsIxdzGOZAETTqbwHa; Fri, 16 Jun 2023 20:47:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1686941231; bh=mjmm8to/bELzOA//iAPouJVx5kPEfLD/xVc4EtzWKJQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=CSO71O13/XmQ1IidOFGljlCsp76z72TXUzO/xep7q9frqV4mp5S5vU7UUXS5wVK1g JZgOO4QJ0HDS9BXemYhW4rbEhJOOQ2MeG5V6WO7O0/b8O5nT1fmwNvIVKHV5SWl+Tp UjJXQH8DeXkxv7MDya/JQkTRY2aBwjby5XFG5lLSKviGfqcmlMOjI1HpoeIqb4zBfo 5z+JKruJH9UIMaI7te/Xic79xKvXhudx6/k/cVIyGaW1RMmje1CL2VSr2rNC8ZqPMN 9Z72eIMurdEnnRQhDx6v1LC18CwqRtmuZbdEdjvYJOAZIChRtKmobmRRRAxEoLRyxz k500PkAeIJ9Ew== X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 16 Jun 2023 20:47:11 +0200 X-ME-IP: 86.243.2.178 Message-ID: Date: Fri, 16 Jun 2023 20:47:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] mm/memcg: remove return value of mem_cgroup_scan_tasks() Content-Language: fr To: Peng Zhang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20230616063030.977586-1-zhangpeng362@huawei.com> From: Christophe JAILLET In-Reply-To: <20230616063030.977586-1-zhangpeng362@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E8934100009 X-Rspam-User: X-Stat-Signature: btx6adfjo5up9q5pdk3ehc9erp5hy4u9 X-Rspamd-Server: rspam01 X-HE-Tag: 1686941232-855332 X-HE-Meta: U2FsdGVkX19Q0Qp/9bylxB3Rb9JAvLS5DUpe2TUlw0aCPIcgyYdaWwukGKHwyxWPoEdNQOz4u78ma93Hfb7oaIe8lkIzL7NpkSJjwOcQN8EUjHqdqjuaVRVb7pIGgK9CldarIKTrJv32R6Ive6FFsSGcQQj42Q4DpnP5jH6o0jRpGF5jdSkudDpLxVT83yjc8j5mN/6auIU1q787tlWwziinNO996UyeNhnJPiR/8/1XLPXPNPqbhLwLMGn9NtZiE18T2Qf54retesNHeJhSMTZ2J0vOU4Qb8Tm1uy23/qec4IxdyqQL28NqU/ABNl3RqrYxiAuztpu8TKa+YdJMMG5Y2jitd2dXEiwIOMFpjl3K1u9fFK1h0GglW88jAU48jgB/XJMVIMXr/j9/14Y5VIV8S7QAKLv86lZfRsizSHSiS62UFMdHEK4NmZa5AVtYkELVmlpSFwLCQrxKAhQTietVbfbsAZ94FO3H6O4/JEw0AEyz3adsyov6VfOct1tbiQjaIOPDxxxKzpRSiivb5Qar1I5eq69MKg2nw0CPMtQcppBD2n32EvSE/+Vs7Rgyj7H/j4iB2GzfLeXJILHi+ZHxKG04cNlD+qnbpM1KkuHrFRflsIpkL0vIaFBrPwJPkiZfJxroFrHty9X0opwoGFp2wzQwKNgrhrYoEALwwA+Z5Zzrm4F/aOLYt6nq9WZCzolVlNKwmK+FaZR8LqDpTKfGREulAenyBRxJL5Ec+hE7We/7ycR5q23EWYlftzDi/W5NNk1iQcP/0/gSEoa18vbJNOsCeT4FwicgcWh03qQaKhE0kcKnNnL94GzkWhLmdO8j49KxMNsNXQgb/GNCX9UZ/cYsFFJF5I6/9MKBmx24/1ZduiKLaaWAJMuT0JJcOri5/7R1qROsMW0jz74/UpDqrmocdrpKLUQgkM4wSciCH1NvmY5/bvzly9zdvziOh4VDdFYQ8k+yZWm4JdM etnwQgWQ HWGUiy/remclE7HvgODKamBD+SUShDAa0TaJxTfIa3OCm5B/b/fER7QJn3n+vPWNe1WcBuuizqY0N2baxDuOLjZzOR8Nf291oGF5SyHx66w4OYLg6yJxhv+niXxzYv/baAzt6BNby7sY3o0vSDTtMEGhxb+UBOZ1r8//iMrkgd+PSu24eoeHaSK1LlSxDg+9QBbSst3u/nyFhF3QjSz3JZVI4Z9bLrOWLdWmyCwSU85aHpO36FX2X9eTwgVUQH8FhD+Nm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 16/06/2023 à 08:30, Peng Zhang a écrit : > From: ZhangPeng > > No user checks the return value of mem_cgroup_scan_tasks(). Make the > return value void. > > Signed-off-by: ZhangPeng > --- > v2: > - drop redundant return 0 per kernel test robot > > include/linux/memcontrol.h | 7 +++---- > mm/memcontrol.c | 9 ++++----- > 2 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index c3d3a0c09315..5818af8eca5a 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -820,8 +820,8 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *, > struct mem_cgroup *, > struct mem_cgroup_reclaim_cookie *); > void mem_cgroup_iter_break(struct mem_cgroup *, struct mem_cgroup *); > -int mem_cgroup_scan_tasks(struct mem_cgroup *, > - int (*)(struct task_struct *, void *), void *); > +void mem_cgroup_scan_tasks(struct mem_cgroup *memcg, > + int (*)(struct task_struct *, void *), void *arg); > > static inline unsigned short mem_cgroup_id(struct mem_cgroup *memcg) > { > @@ -1364,10 +1364,9 @@ static inline void mem_cgroup_iter_break(struct mem_cgroup *root, > { > } > > -static inline int mem_cgroup_scan_tasks(struct mem_cgroup *memcg, > +static inline void mem_cgroup_scan_tasks(struct mem_cgroup *memcg, > int (*fn)(struct task_struct *, void *), void *arg) > { > - return 0; > } > > static inline unsigned short mem_cgroup_id(struct mem_cgroup *memcg) > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index cf06b1c9b3bb..a834b1edcde9 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1259,13 +1259,13 @@ static void invalidate_reclaim_iterators(struct mem_cgroup *dead_memcg) > * > * This function iterates over tasks attached to @memcg or to any of its > * descendants and calls @fn for each task. If @fn returns a non-zero > - * value, the function breaks the iteration loop and returns the value. > - * Otherwise, it will iterate over all tasks and return 0. > + * value, the function breaks the iteration loop. Otherwise, it will iterate > + * over all tasks and return 0. It does not return 0 any more in such a case. CJ > * > * This function must not be called for the root memory cgroup. > */ > -int mem_cgroup_scan_tasks(struct mem_cgroup *memcg, > - int (*fn)(struct task_struct *, void *), void *arg) > +void mem_cgroup_scan_tasks(struct mem_cgroup *memcg, > + int (*fn)(struct task_struct *, void *), void *arg) > { > struct mem_cgroup *iter; > int ret = 0; > @@ -1285,7 +1285,6 @@ int mem_cgroup_scan_tasks(struct mem_cgroup *memcg, > break; > } > } > - return ret; > } > > #ifdef CONFIG_DEBUG_VM