Re: [linux-next:master 7104/8410] drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access'

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 10/16/21 20:05, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   7c832d2f9b959e3181370c8b0dacaf9efe13fc05
> commit: ed229454856e565c5a7d3287cbc63f2cf077b34f [7104/8410] power: supply: axp288-charger: Optimize register reading method
> config: i386-randconfig-c001-20211016 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 8ca4b3ef19fe82d7ad6a6e1515317dcc01b41515)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed229454856e565c5a7d3287cbc63f2cf077b34f
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout ed229454856e565c5a7d3287cbc63f2cf077b34f
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> Note: the linux-next/master HEAD 7c832d2f9b959e3181370c8b0dacaf9efe13fc05 builds fine.
>       It may have been fixed somewhere.
> 
> All errors (new ones prefixed by >>):

> 
>>> drivers/power/supply/axp288_charger.c:411:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
>            ret = iosf_mbi_block_punit_i2c_access();
>                  ^
>>> drivers/power/supply/axp288_charger.c:430:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]
>            iosf_mbi_unblock_punit_i2c_access();
>            ^
>    drivers/power/supply/axp288_charger.c:430:2: note: did you mean 'iosf_mbi_block_punit_i2c_access'?
>    drivers/power/supply/axp288_charger.c:411:8: note: 'iosf_mbi_block_punit_i2c_access' declared here
>            ret = iosf_mbi_block_punit_i2c_access();
>                  ^
>    2 errors generated.

This is my bad, the Kconfig entry for CONFIG_AXP288_CHARGER now needs a depends on IOSF_MBI, just like
we needed it for AXP288_FUEL_GAUGE when similar changes were made to that. I should have caught this
during review.

I'll send a follow-up patch fixing this.

Regards,

Hans