From: Vlastimil Babka <vbabka@suse.cz>
To: Marco Elver <elver@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, kernel test robot <oliver.sang@intel.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: Re: [PATCH] mm, kfence: support kmem_dump_obj() for KFENCE objects
Date: Thu, 7 Apr 2022 11:57:42 +0200 [thread overview]
Message-ID: <d179e539-1da6-c489-b2b4-ad97367bd73a@suse.cz> (raw)
In-Reply-To: <CANpmjNP-XtRB3zTOymH_PCKbDMHoJVYx6UQd_xoM-s33bXJk2w@mail.gmail.com>
On 4/7/22 11:48, Marco Elver wrote:
> On Thu, 7 Apr 2022 at 11:43, Vlastimil Babka <vbabka@suse.cz> wrote:
>>
>> On 4/6/22 15:15, Marco Elver wrote:
>> > Calling kmem_obj_info() via kmem_dump_obj() on KFENCE objects has been
>> > producing garbage data due to the object not actually being maintained
>> > by SLAB or SLUB.
>> >
>> > Fix this by implementing __kfence_obj_info() that copies relevant
>> > information to struct kmem_obj_info when the object was allocated by
>> > KFENCE; this is called by a common kmem_obj_info(), which also calls the
>> > slab/slub/slob specific variant now called __kmem_obj_info().
>> >
>> > For completeness, kmem_dump_obj() now displays if the object was
>> > allocated by KFENCE.
>> >
>> > Link: https://lore.kernel.org/all/20220323090520.GG16885@xsang-OptiPlex-9020/
>> > Fixes: b89fb5ef0ce6 ("mm, kfence: insert KFENCE hooks for SLUB")
>> > Fixes: d3fb45f370d9 ("mm, kfence: insert KFENCE hooks for SLAB")
>> > Reported-by: kernel test robot <oliver.sang@intel.com>
>> > Signed-off-by: Marco Elver <elver@google.com>
>> > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
>>
>> Thanks.
>> Given the impact on slab, and my series exposing the bug, I will add this to
>> slab tree.
>
> It's already in Andrew's tree:
> https://lore.kernel.org/all/20220406192351.2E115C385A5@smtp.kernel.org/T/#u
Ah, missed that.
> Does your series and this patch merge cleanly?
Yeah the dependency is not on the code level.
> If so, maybe leaving in
> -mm is fine. Of course I don't mind either way and it's up to you and
> Andrew.
Yeah should be fine as linux-next will be safe with both trees merged. Thanks.
> Thanks,
> -- Marco
next prev parent reply other threads:[~2022-04-07 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 13:15 Marco Elver
2022-04-07 9:43 ` Vlastimil Babka
2022-04-07 9:48 ` Marco Elver
2022-04-07 9:57 ` Vlastimil Babka [this message]
2022-04-07 9:58 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d179e539-1da6-c489-b2b4-ad97367bd73a@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oliver.sang@intel.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox