From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7240CC433EF for ; Tue, 8 Mar 2022 14:25:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF0BF8D0002; Tue, 8 Mar 2022 09:25:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9F7B8D0001; Tue, 8 Mar 2022 09:25:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8E588D0002; Tue, 8 Mar 2022 09:25:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id BAACB8D0001 for ; Tue, 8 Mar 2022 09:25:16 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6D65A1828AC98 for ; Tue, 8 Mar 2022 14:25:16 +0000 (UTC) X-FDA: 79221441432.27.1BCA3FB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id E3FBEC0004 for ; Tue, 8 Mar 2022 14:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646749515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kumltRP5xoYTs9zCrvASai08H9k31B5+7rHSh9VugPY=; b=aN7D5xEulCZO4qN5dGw0dpoS6gsjmzUc/Uu5dRThH8THuJ03gvhVJ5t2oCX9AT1rFAzJbz VIzI9nfc13VS5F1Wb6vXSMroz0Wc+YKQBzpw6p3UYNPuTKF6SehruKMB5Ows1Cn5j2p1U7 tTqCE2aO47szaAdMARSxBX4OKHTJHro= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-41-H-qOkiGgMQiORS5tPxwSXA-1; Tue, 08 Mar 2022 09:25:14 -0500 X-MC-Unique: H-qOkiGgMQiORS5tPxwSXA-1 Received: by mail-wm1-f72.google.com with SMTP id x5-20020a1c7c05000000b00389bcc8df46so1183882wmc.0 for ; Tue, 08 Mar 2022 06:25:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=kumltRP5xoYTs9zCrvASai08H9k31B5+7rHSh9VugPY=; b=5DqE94JZLPVKxgXSS0Cixzw7J5Ay/E4Cp73RDkohhxKB1+zvnVA7tp6kt4Vq7iGtt4 Cc4SA2yUOAlOmIS+ZTfNdJpLVnP/V2sCBbuf03+QO+8DRReGPK3KvrjaRtwmdjTNLDXb XERAaoJoKgKjN8g56fuSYfPuHuAqAdIlB8RI4cXVmNra60W/IkvdJ99HunhaOyPQpZh1 vCNrQ+fQAjSMcPjqt0PIYv75gz0jISVfOo572EZkzYUEMyGQuxBWLhXx9rthw8cJQnCH GVq2DvrEgFI/fVXsUm1JWghR1bzbJK/Asnm6HJn7ix2QVrK15A16zRLSQ3jb7dTFISth 0jYQ== X-Gm-Message-State: AOAM533vDhsab28VaCG595HC/mqA475h06YihoIEVeDUbZaw6kGj+ZD5 6S/Pkti/xpF3Shhhq5TqSm2u+GloJHP2znQcpr/+84IwqxZo/oBq2aS6yIfED36fUvAfRvOPIlS LlUCxtJRhAis= X-Received: by 2002:a05:6000:154b:b0:1f0:6019:ea3a with SMTP id 11-20020a056000154b00b001f06019ea3amr12330583wry.395.1646749512996; Tue, 08 Mar 2022 06:25:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxznZCLNljth4M8V08Um5+lfKLr3E/0Oh4tOhNEBRjr9ngJ4D3YE+L+JEPV/yWQExUVOsyeVQ== X-Received: by 2002:a05:6000:154b:b0:1f0:6019:ea3a with SMTP id 11-20020a056000154b00b001f06019ea3amr12330552wry.395.1646749512782; Tue, 08 Mar 2022 06:25:12 -0800 (PST) Received: from ?IPV6:2003:cb:c708:b000:acda:b420:16aa:6b67? (p200300cbc708b000acdab42016aa6b67.dip0.t-ipconnect.de. [2003:cb:c708:b000:acda:b420:16aa:6b67]) by smtp.gmail.com with ESMTPSA id v14-20020adfd18e000000b0020373e5319asm244959wrc.103.2022.03.08.06.25.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 06:25:12 -0800 (PST) Message-ID: Date: Tue, 8 Mar 2022 15:25:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 3/3] KVM: use vcalloc/__vcalloc for very large allocations To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Michael Ellerman , Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Johannes Weiner , Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, stable@vger.kernel.org References: <20220308105918.615575-1-pbonzini@redhat.com> <20220308105918.615575-4-pbonzini@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220308105918.615575-4-pbonzini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E3FBEC0004 X-Stat-Signature: yqdwksrywt8adtdtqgrcjw1d6bo3mner Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aN7D5xEu; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1646749515-387241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.03.22 11:59, Paolo Bonzini wrote: > Allocations whose size is related to the memslot size can be arbitrarily > large. Do not use kvzalloc/kvcalloc, as those are limited to "not crazy" > sizes that fit in 32 bits. Now that it is available, they can use either > vcalloc or __vcalloc, the latter if accounting is required. > > Cc: stable@vger.kernel.org > Cc: kvm@vger.kernel.org > Signed-off-by: Paolo Bonzini Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls") ? Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb