From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A607C30653 for ; Sun, 7 Jul 2024 08:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A54A26B007B; Sun, 7 Jul 2024 04:11:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DDBF6B0082; Sun, 7 Jul 2024 04:11:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857306B0083; Sun, 7 Jul 2024 04:11:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 641076B007B for ; Sun, 7 Jul 2024 04:11:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DE994120C30 for ; Sun, 7 Jul 2024 08:11:55 +0000 (UTC) X-FDA: 82312238190.23.968CEB5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id AB4971C0016 for ; Sun, 7 Jul 2024 08:11:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B16m1xkE; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720339884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0FC4NvfoAJx1Y/gu3Ro2ey/6zbMrWE94iatb1WkAmOQ=; b=rrFscalSGVroLM++mhCTwjuJ00P2qr+9SBAkLLqT7LW+3ucBtCS/IWWqG9KV4hVaLN3bw8 nkW3GYGdItTNT0SicRrq6UapJ0/8uYwX+KLde5OnXszp2tk/Qetq+QSHI+5we2D5LD5QQe TQMdnotumZ46UENogxpd/2jTidUmVK4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720339884; a=rsa-sha256; cv=none; b=Q5B0msGTC63qfU3Rt4qzOvP8oZWRIffm5Klxs81YDN3qEZs1sqDpavX7HfxfH5dD7YDBwX 6VUoBTl2YCqkMLPPFdvoD9WU35WNdyO1tdCgDq/YEyzUgS6J11rKk9B1cFo3qxo0Ygokui ztvin8d/QS6FQdCwodf/M2C4Bl+J8GA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B16m1xkE; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720339911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0FC4NvfoAJx1Y/gu3Ro2ey/6zbMrWE94iatb1WkAmOQ=; b=B16m1xkErtbQ12YMYNsPJ5EU1IKFBicK8o4O3AC4TJ3xoXqBdQsuVJouYW6bwgFSOq9c3v eiaoLQaC0X6Zj65xwB+daRBxFsjp+onWvJgaDoIIuyDjN+B8LFPBVNerK615btKkBKrqB4 yjUHqc0LumPKesvoUQJYqOCWE8lL/IM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-HYy3kpu7MRa1F3Y3rEYQQw-1; Sun, 07 Jul 2024 04:11:49 -0400 X-MC-Unique: HYy3kpu7MRa1F3Y3rEYQQw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42490ae735dso31296035e9.0 for ; Sun, 07 Jul 2024 01:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720339909; x=1720944709; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0FC4NvfoAJx1Y/gu3Ro2ey/6zbMrWE94iatb1WkAmOQ=; b=bDfO0p0HZNjClo/hKdPOHvJaRzjF4uzQDTldSTXhCIK7r8F2XwoZ2cRKDSQiIpbUnj IuxTMC08woCZawVf6uuyXjr9i8DvE2A9d5yqknI+gCrBnQMsRdzmuWubdSbbdcVYO66M ULJOpDtAc1eskUEJSwHwSl6T81GAwxkrk/m47EDQVmK9vTlJWvcLiL6wv/0Y81K6W1Ea zt4qjngdFoek+ZjVyNnMiPmdmxTUhqpE6QfzPDD6HgGd4LsD0ktxec0hfRzx6QsVEYzT aLAdcnLIgzuuZsEfLWq3d8BM7ldix48fgPqVodenrnGQo1bV/1P3ZggCzsf2Ch6JtNjG 4opg== X-Gm-Message-State: AOJu0Yx2aQdQOUFvuIA6BErIXwb6LQz6EeIGHVHBwCin78BRmMho+/zH FjhTVLuzeDBvfxJRcyA+SweyzoW/b8F9mfWtkToUHoYtE8FbTWYQwRBGMHAAjlog8vbzTa1oIRZ 6XmDuAsUJ9ExMyKGbn4VV1ra/wYUHVyTAstWyLgB/H6Pdu/I+ X-Received: by 2002:a05:600c:4787:b0:426:63f1:9a1b with SMTP id 5b1f17b1804b1-42663f19bddmr9560855e9.33.1720339908779; Sun, 07 Jul 2024 01:11:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEEafKI8YyHtgDom4e/eOXaAlEzV1pgl+1foShbkE7WKPQAePKR7zrXbwxom2eBgKuJXJMW1w== X-Received: by 2002:a05:600c:4787:b0:426:63f1:9a1b with SMTP id 5b1f17b1804b1-42663f19bddmr9560695e9.33.1720339908392; Sun, 07 Jul 2024 01:11:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:c00:10f0:d1a8:c206:17ac? (p200300cbc72f0c0010f0d1a8c20617ac.dip0.t-ipconnect.de. [2003:cb:c72f:c00:10f0:d1a8:c206:17ac]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4264a2519a4sm119123635e9.35.2024.07.07.01.11.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jul 2024 01:11:47 -0700 (PDT) Message-ID: Date: Sun, 7 Jul 2024 10:11:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: Fix khugepaged activation policy To: Ryan Roberts , Andrew Morton , Jonathan Corbet , Barry Song , Baolin Wang , Lance Yang , Yang Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240705102849.2479686-1-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240705102849.2479686-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AB4971C0016 X-Stat-Signature: zkxeoc4nu15bn5bmqebbtrk53r1n8okz X-HE-Tag: 1720339912-445553 X-HE-Meta: U2FsdGVkX18LhVwD3w3tbJtFacKmZkhkMVhHSTlcxkwVVZJ9KJdg7P4n3OHSvoYR9lf0/1EHeaU5BMxLAj9q/i6qTyVOH9l3wWLmJJ96W3eqOPF17cKxHyfMJpdmN8dAWIOP5dNni2TOnifgp9LseSphxef87TQTM5lf9DsSZuFYRGPaljSqBj8KgSwbVxFAIoEHrpNaWMnCTID2DViG8XoNCOgAANP7gVW6yb6bba9IepdVG7SCVaWjUWDXyYXsI/rCFR8JwEFE8YqPciGKq0sipo9b4dqnzYtkXci4F3+JLT+3qL/kVDsq/o3pLmVHDzwcRqrS8nA55qN02LtHE2GJ//SucePzKty7jfhLVZnNgJvFjmRDYL3KPOAAVDJVIV6/3hilalii/3agGN3X6Du5jdBO/xutCvCrbMXcE/cqIgzFr6STgQG5o/7Ox/ccvQH11dnYFG5k4BfV4d6jf3mJwV7XAfbJWW5b8Y1KoQSUYpJK4LFjt3H1zdEtY6BMnePAph4Wy4pJB+Y5nF/MWx7yc1z0yqJGQCepEZFXCF6BmxnMp1B6s6Eg1MV2XMQhcNMP0s2PqjwlJS8xuN9Sb0T57C0GXmGoY7w9J8G7JgvdSyCf63fE3u5RFM+gDfyFHT/yDYPT4B5bpAEljk7HaQO3FPSYYNgA6F7N8MF2d5fN3N4UcfXLB2UKFNBUNBmBY8WvJKPUSKxAqZbbSBDByZrvLxmx9QqsJpHf9muGrhOw96ljkX3Ky/SCjtoQSd5DE9f56FjycJA3zB9n8w+Kuf4RdA7eyIDAYdJDQcasiYaUGBLNMAlWJatTS3E8jDpaXxvh7rG/A1lC5jG8KkZ0D8d3/94D70mdEQXo2mjge0Ec3KTpOF+djrR9EwF4UOwZYsFLTavtRgY2apjrwVHDYGGqueje0clka9iGkvogKVAgnXWa0WodJllxbXBLt5eyw+2QpkW2sO9fkF9qeaT 89j2C4M7 IoQNjUMRrAAJiUTtpXEcgPt7tYqbnNK+nD/PPkhF0wEv/WdFyYX6/4iwgACGD2oPx6vnwuhCW5ws8cAb1srekIpevgWciYnwsCsIyOVKGRr0+4CC+ea8kXSSh25DIWQbx1FKER5v1uvvC02Ojfyh28mwb4L+roInoNlfW8j6293dLy73pcnehW4dlibY/LLQC/rdPSS5DXpWWGvGFT54CnIflQsiYABcbxB8zdGQiMXaJLwtvabOXA8p0lin9dwdLZdWtRNSnSkLSAO2zFlrtZ0hN5YXgcutZCkba7w7MEFlwNNqUZY/b7H44zyXXYHZBAKzOEI/7NPfTkgjoVhe+Ygv8nd1RC039Gtbi9ozk6uGoNirBQN0lQO8HxubINwcmTCOZsF7sN7CAq1UuAwEXZfdWfkqKWNe3VH5Lx1CgToa4xwA9C+Jdb0m1UvbBwhsu/AVh70XaQs1/d2FQhp5M0rINog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.07.24 12:28, Ryan Roberts wrote: > Since the introduction of mTHP, the docuementation has stated that > khugepaged would be enabled when any mTHP size is enabled, and disabled > when all mTHP sizes are disabled. There are 2 problems with this; 1. > this is not what was implemented by the code and 2. this is not the > desirable behavior. > > Desirable behavior is for khugepaged to be enabled when any PMD-sized > THP is enabled, anon or file. (Note that file THP is still controlled by > the top-level control so we must always consider that, as well as the > PMD-size mTHP control for anon). khugepaged only supports collapsing to > PMD-sized THP so there is no value in enabling it when PMD-sized THP is > disabled. So let's change the code and documentation to reflect this > policy. > > Further, per-size enabled control modification events were not > previously forwarded to khugepaged to give it an opportunity to start or > stop. Consequently the following was resulting in khugepaged eroneously > not being activated: > > echo never > /sys/kernel/mm/transparent_hugepage/enabled > echo always > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled > > Signed-off-by: Ryan Roberts > Fixes: 3485b88390b0 ("mm: thp: introduce multi-size THP sysfs interface") > Closes: https://lore.kernel.org/linux-mm/7a0bbe69-1e3d-4263-b206-da007791a5c4@redhat.com/ > Cc: stable@vger.kernel.org > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb