From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E755DC4828D for ; Thu, 1 Feb 2024 13:40:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 716336B0080; Thu, 1 Feb 2024 08:40:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69CF66B0085; Thu, 1 Feb 2024 08:40:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5173E6B0087; Thu, 1 Feb 2024 08:40:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3B5D76B0080 for ; Thu, 1 Feb 2024 08:40:14 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D46AD40E02 for ; Thu, 1 Feb 2024 13:40:13 +0000 (UTC) X-FDA: 81743343906.05.140B18E Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf29.hostedemail.com (Postfix) with ESMTP id B40F5120026 for ; Thu, 1 Feb 2024 13:40:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=1ldhltdI; dmarc=none; spf=pass (imf29.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706794811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a9Tl8kuFfclMhhTVxm/oWitPhp2Nx4l75IVTGKrZREI=; b=P5XQrKDlIbWyXIMA6NtbLG/H1V9sRh8wYooWUdto3zM02mcsYGL09oL3iLRjtXJd7y9myS 49/6DXj+Wkri/kUExEttsNM5l5ySfcNqJZNccjBfncC/sMrMqZYLadGAMwAQB4cA9fjTbk N4MOpzvIwbGSyZCU/NjUG5rsouSnWUs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=1ldhltdI; dmarc=none; spf=pass (imf29.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706794811; a=rsa-sha256; cv=none; b=Ctg+Bv/AYYrk09yl3LBq8T+H2d+mzkqAf+t56j1lbld+5H0ATySz1UWQFEhkV2kWztjNtp 3lRkDw1gSOD38UTF9ftqnijfKD/KWzQX9V492IZ292IoJ7pa88XHVGy/F5hnkVB4Jy70Qb 23clR5cZWKNiiGsLdELiyYid1hJVk5Q= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-55b5a37acb6so157673a12.0 for ; Thu, 01 Feb 2024 05:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1706794810; x=1707399610; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a9Tl8kuFfclMhhTVxm/oWitPhp2Nx4l75IVTGKrZREI=; b=1ldhltdI0YoxG+S3WnpAzQ0DBp52AKxcxEMZMebi/UxmNZO9dAXUj5IYTBX6bqgT+u XuNtfvkELyNy8XoGB993cLKRQJxnhEAIDKMvj8BWuXKu5ugaqAKdXJv+QwRRJRbFaRng v60dTuGsTu5nKX7B/bbNh+LjrNz0M4uCYk/XcoIPFg7EIJD4LQf4Ma25xiDsz8OZTMBM 9awfjDA8lUxVbDJaejprJ/URxPEq5qBkla4AwmOdtBF587h8+N45XdnCa00tZ0QANy/Q m2g3UYjPJgxOoft6pXZL5rLbbxQYDOdO8sVsRRnNLkLYAL9k7qjdJKX5mM4K5xkaaGZi C/Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706794810; x=1707399610; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a9Tl8kuFfclMhhTVxm/oWitPhp2Nx4l75IVTGKrZREI=; b=vc5zALQ3YZXfsae8RdmJHkh61UqxNk8qSNgnfjBEYjLFbZXpqYp+6LcSJIrS8Fd24t +Z1AwnvoxFivi+pFM8npo0k7581vLrQlRXUVQBMGt2a11f5a/MU1ztIrRBchoZgsBMa0 wYUuLErvmPW5V+xS11Lktbk4pgz4533HhzG4mynO/k3U0vkSXiG3ktrwJkbAyl4o1/yH eb+kwoVIhis17pfHNgNoWXGRi6s0G+j/JaLR7TmmQTC8xcbS9zEw3omk4Y/F4SUvdE7f wfkZskLsCSRTNKCk+zxGNSH+B9wpk0NNavFpPh8jSkH+AIWi1Ns5ZL1NxXi3CVgvthIW wGuA== X-Forwarded-Encrypted: i=0; AJvYcCVaeOIqvnu5aSKcW5vIcw5a9xXcbZz6cE/6fWbI8BAxerxjZufU4qFw9jqzeMCqp1dSYSdcU567Fm6itYzfZGkGgNM= X-Gm-Message-State: AOJu0YxjbZToOSe+1IPaQHiBtNVoajkR2iDwvM8YnvaT5zulheWWprIQ /TRwMIz0lh3vhrjQVuh1CvSqp9sN+OuQS5erslnsT3kwhgsHVmGkP/G4+ZQD+DQ= X-Google-Smtp-Source: AGHT+IFw9K1O3lKafKcofcTeqHyWqk9t02ES2N7eBu525aHQTvzKt/oN04taiEnwdq3lggzDtRhSIQ== X-Received: by 2002:a05:6a00:db:b0:6d9:383b:d91a with SMTP id e27-20020a056a0000db00b006d9383bd91amr2611229pfj.1.1706794810223; Thu, 01 Feb 2024 05:40:10 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXnSmrFf/l4827XxqXZcZoGtOvAf3BxO2fj6nMCEbrz64sCPLcYAKXtfcWd7LW1BDCtH/XycBlmSJ77679Bx9Xw/cidzoMONCOIsCnzi27CH9VaC1U4hL2IUQtw5ohwaWDY0yTP6cc0LxoB35qfetucXHyOUjq1wwIhB2itYtPu0vDcw32p54vvkbv7PiLFTpxTTN4gSpwi4soudTXxcIUbRRFrCq1vHrGOaGtPM2tMAsOdqn3b6YVwWwxWDWTYGgylda7LZm+5V/Xy4OFMcFOyDL6TVn4jtMx1F7TlIEr1nvQtJsJGSWhXHy4ybMc6rJf8mKqEJDcMJYsU3FDVOA== Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id h21-20020a056a00219500b006dd8985e7c6sm11737980pfi.1.2024.02.01.05.40.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Feb 2024 05:40:09 -0800 (PST) Message-ID: Date: Thu, 1 Feb 2024 06:40:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [block/mq] 574e7779cf: fio.write_iops -72.9% regression Content-Language: en-US To: Oliver Sang Cc: Bart Van Assche , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Oleksandr Natalenko , Johannes Thumshirn , linux-block@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com References: <202401312320.a335db14-oliver.sang@intel.com> <9d2f99d8-ecd2-413e-b910-18e05239a2b8@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B40F5120026 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: h5iuxpimfspcwkjwky5djq99twqzu7nx X-HE-Tag: 1706794811-841425 X-HE-Meta: U2FsdGVkX1+Jwe4xZnXVOz7vndyPeXf2Lw8CarQ5qjRGVkcHQZJ7Jf3bFHJhsDe/mDKMuKO4EwBtuvBxoXobvvqVy6aKwMYSJ7gCMBMNgRhB9rUafi8bqxeOOg7dwbuynp2QL/M1n7jxUOtHHX0eQnPqH0ePUOBaZk1xwDQXmAQS4N+pYdzCwdhOlMhRa6mM/rsdVPNgALAEjd1yCod2jogpTtIYr76Nj6nHVUkPGMnQxUQkiBjo/2f9yVatGeqYwgyY6DV7O6wKWSPo+QiEC9E9ka0DXCCpuRZ1pvssf/opPqYMVtFOx/+s6yek7GHk3L/QskpelHPzlhWG3bH9A7txBwWNAzdxLh5eJoSqvnqmgViknDJLw9mSHKj2Y/mAfN4bwDxeX9WX2z8gMbxsE0U46NPRa6UKIoShHU89zM2uwOVQxfacnJJd3wINZDJlHxVhlcVlw/21yK/F/fCv9sRlve4H/Ux0pra7MAufE+8RRjRMBqKfF4F4kJqOdsxBTO/aJzWQWtovpFVvpDd+pgCGGPLCPDP2gzF9XWuPen4NPwoyoGaUVFk3W6TI00jVSdwgVCa21F0uE+j95ggmzPn4CgcD4PkYclUXA98KfzCR5lRsoxytmQI2xDpwS+7yhClr7cA1FHwPLwDNzBz6yrhZr1lZWSoPyOtO/pP8ydrXQxnD/YBrxm0HkzybI/4N9k4IWSzlnNAEtqn9sA2lsKSN94KsxG07l/0q7DJgYrzsPLEHUDJsZaPzaPsyfoVpoFnkVLJALpoDFsnSFfACzm7mbRQJ5c+nkejWDb708ErPyIAv5uH/3XyTEB3988JQ76Pihu3Q57AGSBmuVYrmVpo13bE0bRt1fSBX88FRuF6Wc/KJKiJ8/ZUYVJp3YSR+1syPF522V4/J5eHDqOH16Aql6/eOQVx0vr5WsxXsxmFuvBThy6EP4dbUUW2OWjJFKsPC2bhOi4Ve9MaQkuB 99nD5+6M Vq6uLPW9fqrBRkLrzsWUoCIuSrQVupK1Wf7ej5Ri8LKoiA6oSM3zxmZMfqEdc1iG5Mzvdn/xB41yVb7Zcjx/9IiTRG1gFdWIy+FJawgwwJYGe27uavRBUtH2vpNpdN8NTQhiDFDbK6v7LjCMgzpFEfwCYmDVoVfsdsUwNZyAABvMfD0O3rgDCnf6UdslCv9G3vfFofpOc7INJ+dlPC1ap4eRw6VTD3748VPjqkbMaxKvgmTJdOLRO2kPc6pZNPZCXtK3Hk1p118Re8m0sTC8FFz//EUTlAlAL549kj36znxAeAxGovY6IkpgLte0aJXLkdOGT8Q40ztIvLqXNCFn7W2i3A536B6p4AhxT+8Xwbrlv0v8DB3olUZFUOyVYcPyI4qFD1Y+IxJE/5PVnI0DTohpr4Rx9wKx9RAKt8BzQR4Cc32rkjI/cvXJQ9NHQhspR0wBf2g3sIvHG/Orh2BQopar0LKWKZk3I+A0+eHc1GKGILQVo5f+G/aQpGF6kpFOibtPzRUpvF2xu7WDL78Q3xPqCZjUTtbNwt/JrpUF2ATqUaHlGpy32A6MZ3Cucv6mnuztajnwxmTr0+8AJhL6xJZdmrPE5xwJ17j8AwiuseoqnH2E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/1/24 12:18 AM, Oliver Sang wrote: > hi, Jens Axboe, > > On Wed, Jan 31, 2024 at 11:42:46AM -0700, Jens Axboe wrote: >> On 1/31/24 11:17 AM, Bart Van Assche wrote: >>> On 1/31/24 07:42, kernel test robot wrote: >>>> kernel test robot noticed a -72.9% regression of fio.write_iops on: >>>> >>>> >>>> commit: 574e7779cf583171acb5bf6365047bb0941b387c ("block/mq-deadline: use separate insertion lists") >>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master >>>> >>>> testcase: fio-basic >>>> test machine: 64 threads 2 sockets Intel(R) Xeon(R) Gold 6346 CPU @ 3.10GHz (Ice Lake) with 256G memory >>>> parameters: >>>> >>>> runtime: 300s >>>> disk: 1HDD >>>> fs: xfs >>>> nr_task: 100% >>>> test_size: 128G >>>> rw: write >>>> bs: 4k >>>> ioengine: io_uring >>>> direct: direct >>>> cpufreq_governor: performance >>> >>> The actual test is available in this file: >>> https://download.01.org/0day-ci/archive/20240131/202401312320.a335db14-oliver.sang@intel.com/repro-script >>> >>> I haven't found anything in that file for disabling merging. Merging >>> requests decreases IOPS. Does this perhaps mean that this test is >>> broken? >> >> It's hard to know as nothing in this email or links include the actual >> output of the job... > > I attached a dmesg and 2 outputs while running tests on 574e7779cf. > not sure if they are helpful? Both fio outputs is all I need, but I only see one of them attached? >> But if it's fio IOPS, then those are application side and don't >> necessarily correlate to drive IOPS due to merging. Eg for fio iops, >> if it does 4k sequential and we merge to 128k, then the fio perceived >> iops will be 32 times larger than the device side. >> >> I'll take a look, but seems like there might be something there. By >> inserting into the other list, the request is also not available for >> merging. And the test in question does single IOs at the time. > > if you have any debug patch want us to run, please just let us know. > it will be our great pleasure! Thanks, might take you up on that, probably won't have time for this until next week however. -- Jens Axboe