From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508D3C48BEB for ; Thu, 15 Feb 2024 10:46:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D754B8D000E; Thu, 15 Feb 2024 05:46:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFD4A6B009B; Thu, 15 Feb 2024 05:46:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D948D000E; Thu, 15 Feb 2024 05:46:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A7B156B0096 for ; Thu, 15 Feb 2024 05:46:35 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7D2BB1A0FB4 for ; Thu, 15 Feb 2024 10:46:35 +0000 (UTC) X-FDA: 81793709550.06.B0AB8FA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 811BE40006 for ; Thu, 15 Feb 2024 10:46:33 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707993993; a=rsa-sha256; cv=none; b=VZQEFUY4i7jbJD7fNpNDaNfmLsolfgVpzxoLJxQQ2VN4kk1lOka9SnL/xyH4jwFpXE2uhR H67y5HRClFgpMguMAj4VCpUpqibGXd3MYnmjdd1RSIIkiGK18ezbG5cP58MaLXiBJv97d4 H1d/c3sOleuKYn3ATn5sChSWfSlZFyI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707993993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8KZr5sGoHlhvspGJ/ogFPo9qxLHR8Gz1GWpTyAi9cig=; b=kHpw5tBpjnuqhY9EyhpvKTUjy5BvyRfepFRYogZE3c6j0RhN6bsqZWlQieMzyvEjY40LSe 4xkF0k4HoXLH8CbhUNohGcArdT/EumrEdbJV8y451nNQPNbtTGKOwqLrJDu6nX+BuMldC/ jPW2FgvyOp1zfQyEHAp5GRG9SK0NaNs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2866522031; Thu, 15 Feb 2024 10:46:32 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0A33C13A53; Thu, 15 Feb 2024 10:46:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ucwwAojrzWWfLgAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 10:46:32 +0000 Message-ID: Date: Thu, 15 Feb 2024 11:46:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/7] lib/stackdepot: Fix first entry having a 0-handle Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-2-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: <20240214170157.17530-2-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 811BE40006 X-Stat-Signature: 1d4cxxphjj7sygccyud8pnghq93m6ibr X-Rspam-User: X-HE-Tag: 1707993993-821136 X-HE-Meta: U2FsdGVkX1+g91+EFZ9fE/s2McqQ9T3NwjRiSjeYcg1M+ln8aESLqdwepJ7sTfFyxBiCbZi+XqliEMCIT3sRSLTmZtX67McGFf1SmzM82GhqyDmgVZ2OeGPSiIunafhSDoWzyRh/xzq8YsPx1a6NvEesbqVG1wif0C6Mu/RVyaitDursB2vVMNI+Wef4ZRyRnklLizvSEVh8U+Wm54UyMir6L2iLgmqz73JOBkVa4kwhO2rUnTZHV+ZRo8EpZBj+cfPoWOmMkPaHVYJLWETLPsW/nWU3Z9KfyakbejGMZr6akntQqzlo0GuE4FlbQa9w/xQWOzOE5Hi0dhmHh5GoBBbDi2f8oW5ndffQolGpkR6pihj/lahaCApghU2HxOscB9pB373dbisUGNA/wOUf/bdsL7XtzSyCLFe0ePHc4swiYob2jAeeJzHdhj3DY+XGrrg42TB+A7lKxcW9T46Imgw6mHSQ3ngOaUktO1VoI5Eu19dmzf+EPpoaIdr0KR6Zm3bcpqcZUEdjjBZBsJojSq0SfdcNK9EwXZIPpB8CCoGDRcyu7oTiMTy6krTc3WdBHLjrPltk6m4CdpY3sITUID3SXceRRacOGBZBIOxDVnW/2b8LQRy7Fye3aoqA9uLodYVij7tCxcaG/Xro5iVWcbsFkv0lQiTZw/rtTUe09zNzjPfZd5we9aoAnZtdjjerx9UeNxRLFJGsYDElrk5hqmQi3dlMynuy2/gqFk8seGLa7dIRyVyke4RsAqlo3Cbe1pHUxklDHzj4THlEM7AOrMmFEDPfosmVDlt10oJVbyz4AaVwPwrpF7ENhrDqh8kSOnU5cUa+FXIeeZx6r7/gFeEU3EIYHb22rioeXFKVzejzsCrbImAtVsrdhGyUr65rPdPwiHGcH/1PZujG4VOPxqJOhNIH7+Rw2zUJBl3l3mZsD1ddZRg2yvwA72/0JyTExwU6UIs25yiW+6Q6JN3 MgIk9h1W leCSwseV3xpfYShSBTsnSGrK8CX7ketXGUtXwhFPXJ618RY7nLvnARL0jRKgI7uL08w+/mcNxFJuwf5z2Z2XZN/NnbMh2jKX+7tR1YSwhM4f7vKQvVvtXr53naZ91oaPY8lrzOMnOMK4Nyb5C6Qc7AoNNX2138EmIcIOT9q99Eu0vh8E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/24 18:01, Oscar Salvador wrote: > The very first entry of stack_record gets a handle of 0, but this is wrong > because stackdepot treats a 0-handle as a non-valid one. > E.g: See the check in stack_depot_fetch() > > Fix this by adding and offset of 1. > > This bug has been lurking since the very beginning of stackdepot, > but no one really cared as it seems. > Because of that I am not adding a Fixes tag. > > Co-developed-by: Marco Elver > Signed-off-by: Marco Elver > Signed-off-by: Oscar Salvador Acked-by: Vlastimil Babka