From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F46C4708E for ; Mon, 2 Jan 2023 13:22:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81CC38E0002; Mon, 2 Jan 2023 08:22:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD8F8E0001; Mon, 2 Jan 2023 08:22:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66EE48E0002; Mon, 2 Jan 2023 08:22:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 55E598E0001 for ; Mon, 2 Jan 2023 08:22:33 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3A57E1A012C for ; Mon, 2 Jan 2023 13:22:33 +0000 (UTC) X-FDA: 80309923386.27.2601B65 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id CD6D440002 for ; Mon, 2 Jan 2023 13:22:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AMkFOpSv; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672665751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E5JT1kd37IuRGEL37nkEW4w2qEUZx756Pop0OedkJgo=; b=Hl1R76AxcyFz5UjjLgZsRvDhTxD1TTYAUeogu8HWw2FBYN4p8/28Lde14XQM+x/w4pPJZe tFCKASGjludyhlFJDsdLH2p/K59hHi0azAALY0nSBj7zsEuYQU7VTroRcrz69bnP3ZeIzV 9ga+GNBHkxuewDA7qlUvbeNDkkDPmBE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AMkFOpSv; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672665751; a=rsa-sha256; cv=none; b=hbkMg7jVOdrPoIoa9HyGN9pxfZ6hQkeBim0IfptNabKTDPN8Dyse+/CWsCFmRizDk4wNbc UHvmFWg/jpgOoXjC5PQeGDoY/mXMaRoR4rJ/ba46J/zkX8b/Tm6jo60Z83xOFxNeBhGdTx JL4rI05fcfZIgFyZ5LDS1ubCDFM6MtQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672665750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E5JT1kd37IuRGEL37nkEW4w2qEUZx756Pop0OedkJgo=; b=AMkFOpSv6jDdI0TFSZ7XpRcRTaKPc1WvXwkfH61CR1WvVQQ8ucFBk1rM2RCVdS7+B4Z0jQ r8EQvZ4XybjJSZ9lgfw6nosbTUzRZvVVHaOb/8tD2qqU2HD/gzAaU2/rpfg9sBPh+dR8Sj 8dd4GrVI1UkWRY3J1XxTIcP/WAU++9w= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-670-EyX-DY6ANdOuXbDYxsahWg-1; Mon, 02 Jan 2023 08:22:28 -0500 X-MC-Unique: EyX-DY6ANdOuXbDYxsahWg-1 Received: by mail-wm1-f71.google.com with SMTP id c23-20020a7bc857000000b003d97c8d4935so10832484wml.8 for ; Mon, 02 Jan 2023 05:22:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E5JT1kd37IuRGEL37nkEW4w2qEUZx756Pop0OedkJgo=; b=Fc5lKze2bwyN16RiJVsmENpgYrSEv5VhpSlW7+g+qq1VSb1C1uJBdmAhTcx/G0DxX4 bmzAeqhOobeieZ4TMnAT0zwU+Z82dVkNo7UH6QoDRKv2aK7u78SuFyJBElwRc6SzUwWH RCzc21gDZbykslmfFa6i4AkHJrbjXJvfJWusxm6C2QQmjdchyCMnEIsNtQH93tUT88Kv Ra4v+B1VnP6cdpLb1AkgMH73agvx1U4oXiPDr8wN7mD653WBb/JJE08iqgVl32oPHMMz 7BxKK6+w29lAGDJxN340chYC7+SehyJ5bnXwKV4FW/yvRjSU8IBhZYk0ZMv08wrV8a6A NLtQ== X-Gm-Message-State: AFqh2kpVRLm3s8pOQtVMedYmmD8U7S0Nr7kFUkRAK/l5lFku9bzDJFy+ 1zxjXMePXw+krcwwm9TLpRVvN+EcKswWQDRzuFVCAH0Bv5FA9Msjr8zbQGQ9zto1natXnISyBg0 ideE4UUPqj8o= X-Received: by 2002:a05:600c:3b29:b0:3cf:d18e:528b with SMTP id m41-20020a05600c3b2900b003cfd18e528bmr29332210wms.39.1672665747833; Mon, 02 Jan 2023 05:22:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXt1MMvvBh79Ous21PvG7yDllmYOOsPELrmqqGxs09MXsS8a6IvY3cauQUjOIhzB4QrCR3A1cg== X-Received: by 2002:a05:600c:3b29:b0:3cf:d18e:528b with SMTP id m41-20020a05600c3b2900b003cfd18e528bmr29332197wms.39.1672665747575; Mon, 02 Jan 2023 05:22:27 -0800 (PST) Received: from ?IPV6:2003:cb:c703:500:9382:2e5a:fea:8889? (p200300cbc703050093822e5a0fea8889.dip0.t-ipconnect.de. [2003:cb:c703:500:9382:2e5a:fea:8889]) by smtp.gmail.com with ESMTPSA id p19-20020a1c5453000000b003d2157627a8sm42233921wmi.47.2023.01.02.05.22.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 05:22:27 -0800 (PST) Message-ID: Date: Mon, 2 Jan 2023 14:22:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 0/4] return EINVAL for illegal user memory range To: Wupeng Ma , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kuleshovmail@gmail.com, aneesh.kumar@linux.ibm.com, clameter@sgi.com References: <20221205034108.3365182-1-mawupeng1@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221205034108.3365182-1-mawupeng1@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xehnbwjnwjiighix8wf8cbiagp9mmw58 X-Rspam-User: X-Rspamd-Queue-Id: CD6D440002 X-Rspamd-Server: rspam06 X-HE-Tag: 1672665750-245778 X-HE-Meta: U2FsdGVkX18qWgQEWxhZBZ/I/Uisaodh39qxJcH7dS8wFbiYM0mzrEWEM1cgHplfggzj+xSfsPXu9FncUyOPLL3r1zbc9TPPamIh+zsG9S64Xv7UunGi7hwUBJERGZ0KlMOL98Aa/ezas+3UArIj+FFxgayKXA7RCLaqcXpRR5hwWvZL8Qih+gGm1XF2JrtMXcs7Jn9ZQv6eDFwBRfnsOMwfuADVE6Pvqe+oMQML7rEBKyHaOkcigUmbd3R5yxCD5houU527SJcnyURHGrgRIkLLfubb4NkRIUMaUdxEIfv9gUHnS2DnclCPY5XDg+eQql0CSvzbvQAHmaYHERJ3SQ6Pls9bYK21Hde70dEmXkn9Fmid8pPwJfpO7RrWCEN6eKVQY5sK6vDrUnNwrybtsn5k4f5E50yV6spDa9seFed2W2bxocCQf1vx7i6LOt7NwMXMeu4E+Abx0KnzuaSVHliDSadU0+R8tHLlD3thzY6BYERHX0EYz6kCiW4N/7/4tg4ScqpYfAv28t9QiD64562UjNauCdFeX0HFUKlAL5QlGCmJdX7UyAGurMzmlW6tzWMX8EtoWmyQoob7KCjb+fHxq1anN+XMkCWE/BitntLVfBZw+bozWGKIiqoD1jUXHi2w97eQTZ3tTFt1n3XM0aTimvVLDtwao/Whgp9Jyf+hCDNB2rZfArceWNiSrSMOk9fXLg1Efz2UZDVgV1UGbjvQb7vpifMXoJr0pMuNA3XCjyLPu4rssIir/s3QOnEytHtW1Lf4SMdAy75zZcXZxqG2tgVD3MeJTAcn17tJh5ZJ5RU165IvmhWEME2Vn02SRPitcYcgThZX7799yBx6wmlKCEykhYot5NlATPawdjVXMSwVV+G9KvyQRTvvAOH7fgxquaBnLqcN1qdaxN8uvskbvjKp4s+t52NBgZGC0IV6f+ruAdsxML3De53sTNu9NXpgAaCaZknrp/XD4ec 4y7Rq2M3 PSgOatRCpXdjw7GQ3QrFmRUWiEgkv5r6G4zoPDLdCrL7g+jeFKg45w4TazNSOLGwbS8RuNOby6LKashzOLaY0iAVqmq1nkwOd8LiKAW4O/9BXtAUCPo73Jk49gZd5nU63pd9HjfChXGxBIyM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.12.22 04:41, Wupeng Ma wrote: > From: Ma Wupeng > > While testing mlock, we have a problem if the len of mlock is ULONG_MAX. > The return value of mlock is zero. But nothing will be locked since the > len in do_mlock overflows to zero due to the following code in mlock: > > len = PAGE_ALIGN(len + (offset_in_page(start))); > > However this problem appear in multiple syscalls. > > Since TASK_SIZE is the maximum user space address. The start or len of > mlock shouldn't be bigger than this. Function access_ok can be used to > check this issue, so return -EINVAL if bigger. I assume this makes sure that what we document holds: EINVAL (mlock(), mlock2(), and munlock()) The result of the addition addr+len was less than addr (e.g., the addition may have resulted in an overflow). So instead of adding access_ok() checks, wouldn't be the right think to do checking for overflows? -- Thanks, David / dhildenb