From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA2D4CDB47E for ; Fri, 13 Oct 2023 11:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53EF26B0115; Fri, 13 Oct 2023 07:38:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C5646B0117; Fri, 13 Oct 2023 07:38:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 367046B0119; Fri, 13 Oct 2023 07:38:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 206A16B0115 for ; Fri, 13 Oct 2023 07:38:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E867E801ED for ; Fri, 13 Oct 2023 11:38:03 +0000 (UTC) X-FDA: 81340239246.02.4C956CF Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by imf26.hostedemail.com (Postfix) with ESMTP id D0BEE140013 for ; Fri, 13 Oct 2023 11:38:01 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LfK+tSPf; spf=pass (imf26.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697197082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KNKf+6iBlI7pRmCUJ1OBUp/bgd3+Qb/S4MnA5jTB/NU=; b=W4I3PkBP3eTF97dM8tHCZkKVxaB9mAJb663pfjLjX2neIztXqGKwZQ+Ih15X7PNQu9IZFw 6rWaW7mVDGI1kABk442irXKsBaN8tMkzHwsXDXAglOHphM9CXVTKXtE26VoNmwJrTGhgsr 3SqK8ya+sFUeKln2M5AtqCCN3sVD2do= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697197082; a=rsa-sha256; cv=none; b=JkNwi40rwhYFQRRuEdhe0oj4d5B2zrlt4azQSJpp36iUwULO7Peu6xRQt89NM//W9+KSt4 bGJg5w09oJpQHC+tpuxZuv9QWPOQ0X/bWexREVX5ODpzLUXcrwBjG1j9dYDJMxDZI/Dscy tK+88Z+Lo+jE132HZOlOKoTjQfElgaA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LfK+tSPf; spf=pass (imf26.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697197081; x=1728733081; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ariT8CxKR/Cq66g3cxCDu1qA3Q2jySEnMOrVryK1YyE=; b=LfK+tSPf9X0JAvYqEbvpRr8e8lNATFfeqBVlp92O85D3m7bWrmL/Bisd 215Fg00MFUs9M9j8DNDIf1e0bh/XEoVbtn+wbqAPIq/0qRzqN1MYfnndX sd+03HTzQh/a3ugAwnxvcRTlGMQHKzy/C3RlyxMIg8PpUogMFA2K2YsR7 ooPBlCsZAWEoP5iQmLVSJ2C17cVZXV64JM5DAXcR9IrEKTlPkoXWoXnMG SGxvQ1xu6KofS7lQP7W73F9MzO+WnTToXWkyMgcZAM87KIT1vfNYNfwfV O0PkkCCHXw13//8wjTeodspfFA5n+w1B4+9KvAJdyryYd4kHQf2bSn9PX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="449353368" X-IronPort-AV: E=Sophos;i="6.03,222,1694761200"; d="scan'208";a="449353368" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2023 04:38:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="754675817" X-IronPort-AV: E=Sophos;i="6.03,222,1694761200"; d="scan'208";a="754675817" Received: from bsankiew-mobl.ger.corp.intel.com (HELO wieczorr-mobl1.intel.com) ([10.213.0.114]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2023 04:37:56 -0700 From: Maciej Wieczor-Retman To: Andrew Morton , Shuah Khan Cc: ilpo.jarvinen@linux.intel.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 7/8] selftests/mm: Substitute attribute with a macro Date: Fri, 13 Oct 2023 13:36:31 +0200 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D0BEE140013 X-Rspam-User: X-Stat-Signature: s3enkyp3yyd9eomdj6rh6o6buoxkjrjy X-Rspamd-Server: rspam03 X-HE-Tag: 1697197081-6267 X-HE-Meta: U2FsdGVkX19dOHKCvdbR2Fn6kpjYX5k1SDZaZKarlyJYx2T7ZgdkqkWqRxF0p0Q9hEIeV5FCmdfODNXOWSfAqwi5Bt1l5jAikDsT+Z/Cmm0f7koaD1t1vhzTiQF1+RqBBECeWzQdoFyyLXwvQN2i/PxQmssRhHWMuw5M3l09kPhb3q8fwyrldqav5uWZ+YNl51Ac6354S1+0LyAh0nHPNWESBV4HP7KiYa1/2keQYWjfmx7nincbNikEcXDzkWQGN9QkzozrPPccvyDC4Em2C9G5z5KFCv1zOCJoKLhoqbblND0B12lHHcSZrfee6uJ9ggrLMhv5g1ZRVwUMEzyq13oX7tZynKr4Z/cTex/oqVhb0sgqrIWNSWkPIoFwwvE9xflQu/FAul8gzQoVDNd8cxkYOmzeABwjDD0Q9MFqUS7GGfm9WRqGWq7C2A23yQnChW8RG+A7Wl1pC1PGN8RXLuphag77h33WIAb0A19A+8IVfxB/wz1Glt5Bnys3QzEtJuDwevhrSXhqelCOspse2aeEzwkFsQxaRGSgTx/35OCbOgcv21gLMImUuKe0eoTaSzQrKpmf/Eo45dwnj01ytwrBDZdYDKO/OATU4wFxwpKYBvwPOau4Q9aK6XLNndZvlMnKjg+i2vehuFTDoyA6DdgD8Lh4psE8qVrtkUAW1adRv8pG3a6c9r/Y13xALk7ym6pF3w1XaK3ueNtq5IPAuGaoJc817w4+r+RdjA2AOXMWv2+T3xMWYqrfI2plyXJRgwcCF2LNW7zOKYgoPmSCtQY4osUiSsenNqMttm9KdHxlcjp8PycDwlY46r0DnbA+GhkONR+85dtEPcnJjPDujsNzBMC6K81cOqE42DT1D7XARxchq//g59VtSsOioCTp4DKfTSs+0VcABYBaSII4GGdgeUaLZbYFEcquEMjBbCCPFGaZgWLid6CZ8lFjGDL4ty4Xfl59UQrbVDCBgce TDEqcFmX YyCBbz20wYiUAY9kkJzwujqlP0kvQhaStK8m1RMtkLWTCjltJH+mo4Y23WmT8EOh4AuXsCt6I3TW2ngJOiaqOswYOQ5YryuWP1pOlHyq5MJcqgP9uYiiKllj0kHDAtj48cJSsqL7y3Ji3NrjEqa6dVOcmGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Compiling mm selftest after adding a __printf() attribute to ksft_print_msg() exposes -Wformat warning in remap_region(). Fix the wrong format specifier causing the warning. The mm selftest uses the printf attribute in its full form. Since the header file that uses it also includes kselftests.h it can use the macro defined there. Use __printf() included with kselftests.h instead of the full attribute. Signed-off-by: Maciej Wieczor-Retman --- Changelog v6: - Add an explanation to the patch message on how the warning that the patch resolves was caught. (Shuah) Changelog v2: - Add this patch to the series. tools/testing/selftests/mm/mremap_test.c | 2 +- tools/testing/selftests/mm/pkey-helpers.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..1dbfcf6df255 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -338,7 +338,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, char c = (char) rand(); if (((char *) dest_addr)[i] != c) { - ksft_print_msg("Data after remap doesn't match at offset %d\n", + ksft_print_msg("Data after remap doesn't match at offset %llu\n", i); ksft_print_msg("Expected: %#x\t Got: %#x\n", c & 0xff, ((char *) dest_addr)[i] & 0xff); diff --git a/tools/testing/selftests/mm/pkey-helpers.h b/tools/testing/selftests/mm/pkey-helpers.h index 92f3be3dd8e5..1af3156a9db8 100644 --- a/tools/testing/selftests/mm/pkey-helpers.h +++ b/tools/testing/selftests/mm/pkey-helpers.h @@ -34,7 +34,7 @@ extern int test_nr; extern int iteration_nr; #ifdef __GNUC__ -__attribute__((format(printf, 1, 2))) +__printf(1, 2) #endif static inline void sigsafe_printf(const char *format, ...) { -- 2.42.0