From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE9F5C77B7C for ; Fri, 26 May 2023 12:59:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08DC76B0074; Fri, 26 May 2023 08:59:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03E4D6B0075; Fri, 26 May 2023 08:59:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6EC0900002; Fri, 26 May 2023 08:59:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D8B356B0074 for ; Fri, 26 May 2023 08:59:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9D372160E7C for ; Fri, 26 May 2023 12:59:23 +0000 (UTC) X-FDA: 80832412206.04.CC0F950 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id D52D6A000A for ; Fri, 26 May 2023 12:59:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685105961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0vPK8VLhtAN+TPX3CuVFBFEuHg8QYtuygPEXDHl4R6w=; b=hhgR5aS4+ekZqYW9MWhr6DxNf1Z8M/GrYtL3uCU5xbp/Vg+bSlf5COwCf/acPzok5aOH3y jUUT1T39q5OmgRM8fWArlUSIzZ87LnS7wr9sbJ64PRY8lh7sASo58miQdRQhAAjBsazzqo 9C+yTwuiPzGNQfp9X+xbI99aUeoC3s8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685105961; a=rsa-sha256; cv=none; b=aVCBErrFwg16lqSKYlzQqm4GMMCGXimk4wjnlVGzwHKhUzeZWWZm9EgB3Rvp73i1pmmW2i 4YZl+HCAiVhlqMveXXiRyqvMlq9doMq9Nirg33TG1aQWZvt5FlmAucBfiwuunqeYjT20uX BpJ9Ti56NOI00ym3Yj1h6JiE8yG4Rr4= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QSQ1C4V6QzsSFn; Fri, 26 May 2023 20:57:03 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 26 May 2023 20:59:12 +0800 Message-ID: Date: Fri, 26 May 2023 20:59:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [syzbot] [damon?] divide error in damon_set_attrs Content-Language: en-US To: syzbot , , , , , , References: <00000000000055fc4e05fc975bc2@google.com> From: Kefeng Wang In-Reply-To: <00000000000055fc4e05fc975bc2@google.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: D52D6A000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 351wqti8qwo96edgijw7smnezo6tez5y X-HE-Tag: 1685105959-814076 X-HE-Meta: U2FsdGVkX192nTkcKRMPMNBsTmW7OEsb4Dr5hsqyxPXxSJeXxXdyA9mnVdQfaBaBG8OA9+OoGqqsYoPWZVkJlB6wURNBSb5neHCmsgAuqQXirAT9Lnl1w8WRzllQTUEmCgzOrRF8X2oYlCLsaXpl6KfsWAOP1YTm9K9qWObuV7oippXG3LOkxiiI43AU0XXVNWR9zalQEbVD3XEf5gXBq6mzKe1Qw0D0uTpLJNIf+dStgBSM8z3NYviGSdlB5wSLaqqHo86lSkGg654iq64DOsQ7a3m4nLyeu7vncKzXPHcYYsjA7W7q6IddEpe1G8SuB+q2J5y52pvSdZITuUK7+iJa3SRX37SfV4QCU4q0bmvR4BYEHMvfHDiPTDClRPL7tPCR5kuMT49vuXlTBQDY8FyPSSG0VD175mDaLgUmmxPwGUte8A/6GQmfoT5ne6njxDywbHoXjbrPtq1wC4BxusQdon25DMv5uNSR9IMemywjOb549WDBZCPQKFsIa2+Ifr1j84IlF+bnYW2KHm3gdYcv7PwuA4TorsmjfNxgPHQZkt/A/GF3ZeR2ZCf/WNaW6kffx2xwdhdIVnntFLqRbA6L2aNoGqWM6XJIorITzLCof8dI+EhLFq//xzr4Ncr6I0kDBlSWSoObwa2oejn74dwHS9DS807gNeUfyW3LkSTLoQFQ+PDugyIuRzfrjAy4Fjt2Jawf/dtKk8G+06qtrTsSzqhriEjn6b9pDcYshrZ8ysUhXSzaLJcsbYcjAdvjpNYD7ICj+ImjRJKCbyLX/r73B1kSrqbUKb/RzzwDNkD5QIwKWOG1JRJZ6bXJfTFkreXvH1Kjiuhk9TWr0BakIE3VANuc8OEMPYzM7E47wkAJvO1fXHxOEqRrZ0cN8YbIHlXRfb5WjGP3CDKOD+NHtF0l571468CaNEgZ3VEKHoPwxDdyOkeaqrs7StlEaKGLjHpoiMWPsbDhAn+/09L RQvFT1bq p2IlwYHRY2X8EFXQWnRb3+r7/xGP6G76Ki5YxyYr45QwyfkVuwB4IjYPyj88bumCEY1AHoxtROIeM43W7If+Fi7m930AGCTiXIdDDF3YHcah9cuD+wS5Jdec3HKmC9mb5VJqsNF2Fs38KFGS5y/L3Ff6+oyWLflILrb6YaRA71WyasL9vYzU/XRSM47HI2mFRJ4sW0LT2n+H3j9ZXx06eOUP5vZ7xA8IDe0UBcHJL7h4wz83Z9NK0S7uc9FIcUVadUaKBRd49Kbv2yPDo9xg0KdYwlN0zxaHQ2HwJGw1zc6g3Dz8VvvqQvnvmKbzYZgk+KoC0c+JyWAavmGzRIn5v/fzilOWv+kIrm2Tg1uEC7Sh9KJpE+ir6EVhtiJkthY0GPn3ADjFtq08Zq2DHYfWM1Em7rIc9iBvxX4FCguYrEsr/8Kr6tOuc/M4MH2PjtNOdTemx7v9y83iyI6ZAXOTCtUy+RQtA8V+vScveSFxFfL8SVOllYeXu7yGJY5MHQJyRPkrep2Rin5ujhIE4LUycG20GbU4Fzbpd2YGJhNRBUlPkNU1hFgVnQDumnka7fJ9GDaM6VG5raqKwaBFgSwjKxQn5gS5AMhiqn4QGdy0TGf1QJG206yBY2a7SecRzCfF7rE7KM01qXeuPlgQl3XyCwRh5gyeAUNRFeRnUYUVn7ZNNQZ131dY9dHavsJ4cesNV9PaExWrCmEE/YVP+bpScVEq0rCFjz3/rqnv1OVwi7Jps0AWPQ31VNMk9VQkvK1D1QgjZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/26 19:51, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 44c026a73be8 Linux 6.4-rc3 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=13a92b31280000 > kernel config: https://syzkaller.appspot.com/x/.config?x=f389ffdf4e9ba3f0 > dashboard link: https://syzkaller.appspot.com/bug?extid=841a46899768ec7bec67 > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > userspace arch: i386 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/35f16ee05df7/disk-44c026a7.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/10399498a570/vmlinux-44c026a7.xz > kernel image: https://storage.googleapis.com/syzbot-assets/5c72201ea4ba/bzImage-44c026a7.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+841a46899768ec7bec67@syzkaller.appspotmail.com > > divide error: 0000 [#1] PREEMPT SMP KASAN > CPU: 1 PID: 13527 Comm: syz-executor.1 Not tainted 6.4.0-rc3-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/28/2023 > RIP: 0010:damon_nr_accesses_to_accesses_bp mm/damon/core.c:491 [inline] > RIP: 0010:damon_nr_accesses_for_new_attrs mm/damon/core.c:497 [inline] > RIP: 0010:damon_update_monitoring_result mm/damon/core.c:506 [inline] > RIP: 0010:damon_update_monitoring_results mm/damon/core.c:534 [inline] > RIP: 0010:damon_set_attrs+0x224/0x460 mm/damon/core.c:555 make aggr_interval great than or equal sample_interval? diff --git a/mm/damon/core.c b/mm/damon/core.c index d9ef62047bf5..6fe1960f3d6b 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -525,8 +525,8 @@ static void damon_update_monitoring_results(struct damon_ctx *ctx, /* if any interval is zero, simply forgive conversion */ if (!old_attrs->sample_interval || !old_attrs->aggr_interval || - !new_attrs->sample_interval || - !new_attrs->aggr_interval) + !new_attrs->sample_interval || !new_attrs->aggr_interval || + new_attrs->aggr_interval < new_attrs->sample_interval) return;