From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CCE9C0015E for ; Fri, 14 Jul 2023 14:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05CF38E0001; Fri, 14 Jul 2023 10:26:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00CF38D0005; Fri, 14 Jul 2023 10:26:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16DD8E0001; Fri, 14 Jul 2023 10:26:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D1B478D0005 for ; Fri, 14 Jul 2023 10:26:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 983EC1A0290 for ; Fri, 14 Jul 2023 14:26:48 +0000 (UTC) X-FDA: 81010443696.06.D7D7276 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 6148D1C0016 for ; Fri, 14 Jul 2023 14:26:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2eZEKNyb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="cDg/jNJA"; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689344806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rbJwmhXfhN5rIPoLj6fIJpy/+DMnwxG+UHYLi25rZdQ=; b=urynaDqiTORg+YV9m+ENC1pyulWfQoMUDaTaxqDWDhoLSCS2JnOaMG4j6t6XMRdNeVg9y7 cWZ3aUu/Ct/UUK3JNYFN4k3MbJeKB6BSch5jziV97cQmCoQzAvIgqv8b9SEOwTu6inlKWw /h7cLhOUmqjmStzB8XsOLqNiH233CaY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2eZEKNyb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="cDg/jNJA"; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689344806; a=rsa-sha256; cv=none; b=nLRMYINKoNqnnLYM8evBH+crfhk2kZp8ys0eRlf5NQqjGHgLeqPPsqk3sb01gl7E7Oa6Nv XSIiEEqgXhyqUReCHUPijk2l3MxDgLz/hEx4wEgPH7uPbMAA05fTRCFgB3hzGRB3e9o2Te Xif7gVGZo4NsHX5xjM+u1FbkE4kE/Hw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AADA51F747; Fri, 14 Jul 2023 14:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1689344804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbJwmhXfhN5rIPoLj6fIJpy/+DMnwxG+UHYLi25rZdQ=; b=2eZEKNybuxBZ5dM4elpTXk5fybRAWCqEWxv5TWQSsbZwocHXqr6P/pCn+HDpCp7VOHFySU wrN5RdAayt0lobndDZx78GkWfzBqXslCQdTLHDIT0+rhfSaqa1zkl5RfWg4pf19se7xDGz 2877+IHCgDJe1hKZRpKwl3nJ14+KI4E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1689344804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbJwmhXfhN5rIPoLj6fIJpy/+DMnwxG+UHYLi25rZdQ=; b=cDg/jNJAsxU+WNbuvHmDt9VhdDeknW42QogvvhHtOg5owP1dFsCJop+teLMjTToesPOSkW QA4DQyFxXD8lQGCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A75413A15; Fri, 14 Jul 2023 14:26:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2440HSRbsWRTHQAAMHmgww (envelope-from ); Fri, 14 Jul 2023 14:26:44 +0000 Message-ID: Date: Fri, 14 Jul 2023 16:26:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/5] drm/amdkfd: use vma_is_stack() and vma_is_heap() Content-Language: en-US To: Felix Kuehling , Christoph Hellwig , Kefeng Wang Cc: Andrew Morton , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org References: <20230712143831.120701-1-wangkefeng.wang@huawei.com> <20230712143831.120701-4-wangkefeng.wang@huawei.com> <83f11260-cd26-5b46-e9d4-1ca97565a1d0@amd.com> From: Vlastimil Babka In-Reply-To: <83f11260-cd26-5b46-e9d4-1ca97565a1d0@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6148D1C0016 X-Rspam-User: X-Stat-Signature: gydfj9i7ra5kirsqbf6iu9fcqpdcqqkh X-Rspamd-Server: rspam01 X-HE-Tag: 1689344806-746675 X-HE-Meta: U2FsdGVkX1+5XtCyN6njEQ0DpZm3OXqT9EazS9bjEGJhVRdeKwnyO3yOVnR14Etui3l256Rum2FQ0wxR+L6OUs/XfLnwP4kPv+T0XnDtr6GLeaMiQF19WLg3wO/e6K7NL3I83h7BWZvnwwMAazTwlPaE4TTtRXRomig79nx9WUDxh6GAuzbpzEpLGzvfzsQ2CCHf26z1+Xd2kzX2Wm3S3tP1b8LkcHZLMF/XZmifG4BIyshaD00hej42R22GQpjdSBmKYRjh5Wwr5OzYJaMNa7oIn7kb15wqMI1JuA8bg7lhVFCZr8oW3cRWfunLt1SnpmoLHpPDGHOG18pTAFB9MAGu+YWsU4Gdj6EFTwby2tmHKaQYZMIRvk7LvZRbYhmLdLha1F04+t+ZvqOJ8xlGDvVU1VtWMUDKlRULUreKf6RILOe41+BuluuS1vIs5COOvKxwV5tq3VSdlubEufyFOIoTyNFDR/ttljEo2HOGZSxAgqCg6PPLRDT8UtCeRAS6wbvT8voLC89pgEcR/23SPK2PkYfGbBJ8RIE9dfnapiBjJU4wNCq7w86phBE9l//ejVbtwQnxhy3HIncDjO+7ebulFI0VETeLmfj8Q8bH+qRuyHuyVYoTuCWkydhxNGcW2zFWDSJlv9olNVYUA+wrPje4deQ1kbtSGMx1gcDJN65MFREiqZhRQGAYdvlSEIMb4MLdF38xtXONv+anjcppeO8Jq+TQa7szCq6DVyOhHy6GXLZb4loL9vRQ6fP54nVgu6aJe8m7b9QohljuWVoD6AHDnJebfUYtspO0pRrtoEP+k5gJaOhmXGPwGjWNLgvBWztoVA6SMHgM37mz2keKbfI0Z+b/yKYg1CUPVV+JygK7Ngz0Bgt4Bxo62mD7BeP43tpk/8OC92IpDPWpTI6u2KAR+t3V95TPi+Qi6ar4XkezTIv3XPfWu9F3JumdqXfgKgNfC+7ndUC1+yp/aaS XDjibhWE FC9wobdyT+S2m1WbvB6nRBniMnwNBTN46LUqfO87s3VqX05vHuSJF1CWV1WK5++sxImHdjzlNynY1+jVvAd99posYbqxSIReTH2OvTtiUeen9AJY3Degy0a5rjzMZ+MGViDcTATnI37fgRb6qk0vLlolzMKAGFxMys5Vz8QBHuCPcjdQDPHcukkHf5qxJgp34guaDwk7VgYqEYka0ln48bLIuOuxYvxuwlUycEatBNGwKC5WuXXNEn6kE0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/12/23 18:24, Felix Kuehling wrote: > Allocations in the heap and stack tend to be small, with several > allocations sharing the same page. Sharing the same page for different > allocations with different access patterns leads to thrashing when we > migrate data back and forth on GPU and CPU access. To avoid this we > disable HMM migrations for head and stack VMAs. Wonder how well does it really work in practice? AFAIK "heaps" (malloc()) today uses various arenas obtained by mmap() and not a single brk() managed space anymore? And programs might be multithreaded, thus have multiple stacks, while vma_is_stack() will recognize only the initial one... Vlastimil > Regards, >   Felix > > > Am 2023-07-12 um 10:42 schrieb Christoph Hellwig: >> On Wed, Jul 12, 2023 at 10:38:29PM +0800, Kefeng Wang wrote: >>> Use the helpers to simplify code. >> Nothing against your addition of a helper, but a GPU driver really >> should have no business even looking at this information.. >> >> >