From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6128AEB64DA for ; Thu, 20 Jul 2023 07:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9C1D2800CF; Thu, 20 Jul 2023 03:59:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4C8828004C; Thu, 20 Jul 2023 03:59:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BED1C2800CF; Thu, 20 Jul 2023 03:59:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB46628004C for ; Thu, 20 Jul 2023 03:59:08 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 798C812012C for ; Thu, 20 Jul 2023 07:59:08 +0000 (UTC) X-FDA: 81031239576.11.1C15A23 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf21.hostedemail.com (Postfix) with ESMTP id 15A5C1C000D for ; Thu, 20 Jul 2023 07:59:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Nnu9yXWn; spf=pass (imf21.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689839946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QCBG10jWmv8n11PUl1At+mRhQs+STyCHC9Y8ykk98hs=; b=RFyGTgx02MUu+DOrlDzGmL1zULSTmd1+wVEasGw0PmAMvea7B79oHyVFx0kYvsz2ojpjAe s62AXDLuWDtLN0v6KBSiRHJ0SZeOiZRgA29eYST9UOB1Ja0zON37UcjX4OWW2ZtmT09gvI UKM816XhkuENlePMjjIaP4i6VAHlvUk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689839946; a=rsa-sha256; cv=none; b=E8VnUj+ytHAyxoS2VOSA5RObPnfZ6I9WH3fYfL0AWM0/gveXR+sBL0KVjvo06AumhxavjQ RU6VCdqYfHaj377U8emnh9AugGMWDKlPc5J0qGAIhSzSO3Qb6IjSd6ZcYa9uF29Wfp2Z/p nNLTzmL5o5YX0w32NgMBmp7KoqX0yE4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Nnu9yXWn; spf=pass (imf21.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-666eef03ebdso285452b3a.1 for ; Thu, 20 Jul 2023 00:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1689839944; x=1690444744; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QCBG10jWmv8n11PUl1At+mRhQs+STyCHC9Y8ykk98hs=; b=Nnu9yXWnT11QAdbQ9GUhYKZSFFcUk0bsZdtUNqUMHxBWMFa6402Ny2yH5iQxEZhGtt Kz3XRv01VgrqlGSpLQm7E8BKzJTbIbnZkymzLZbp9YmpoHsQYwRejn13SBbT7IrQTO6U SSKMw0RKNd+ruoF1X7gd4bGzDUdn3VZamns/FpVKcyZVE8bZfh3ZB7SkwGWidjmpWE2S z1eYV6E/QnugvkY/taUn0a53MkAB3OHG65tL3psRnBqx/L04+GCvHT8xrBnv01/ZpdL0 kXwHSiBUs/WAYR8ArUnjYyaQ6W/MAMWTQXpvjgTEogO5unsJNpTbyHBzDOtgtGFpgt0g Sp/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689839944; x=1690444744; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QCBG10jWmv8n11PUl1At+mRhQs+STyCHC9Y8ykk98hs=; b=OJ0DltIqoufeK87f1sdTSxdwbPP4bT7/xacA05JAv4T8qZpoRAu4VyqcFoUQVT1zwL ZA9zQP/avHOmakSWPTPaWFEWgWa457R3sexiX3mQkOl2U5i13I9QWnixIHAkVxoRf5Xf XsmqKZle6oVLC1hCgzbnM7293427ODHRZuRNIcgpT5E4DY7l8i/VQ2yKnvONoh82d4om QgIBUZTFeEuIunSeEDyHG12/ZdaMgV8OXtibaMfRtL9XfaB1w3KpASMYAPvsp6/p1wM2 7iLEzdzGh+krJpgiDweo8Ua3g/+ZJfZYU4rWZ2saedpfQ7abKc/aJxiGoimRjmIq9jhf Y6xw== X-Gm-Message-State: ABy/qLaeTjbNjD0NHy25coOyTVsNzz5TWoXd1I9y/DgDkDhnKrvwjz9p 1Z4rouCiCQIkhXqQQij2msc6cA== X-Google-Smtp-Source: APBJJlGQceyOTHuEAgshImHxzNJeR5JGceBNvAodrsHOmgwDK+Re8De+gti6K7ICOvS0ObBFvVOw/A== X-Received: by 2002:a05:6a20:72a4:b0:133:f5c1:57bb with SMTP id o36-20020a056a2072a400b00133f5c157bbmr17999503pzk.20.1689839943740; Thu, 20 Jul 2023 00:59:03 -0700 (PDT) Received: from [10.4.72.29] ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id c1-20020a170902d48100b001b895a17429sm579947plg.280.2023.07.20.00.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 00:59:03 -0700 (PDT) Message-ID: Date: Thu, 20 Jul 2023 15:58:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing , Xin Long Cc: Michal Hocko , Alexei Starovoitov , open list , "open list:NETWORKING [GENERAL]" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" References: <20230711124157.97169-1-wuyun.abel@bytedance.com> Content-Language: en-US From: Abel Wu In-Reply-To: <20230711124157.97169-1-wuyun.abel@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 3i89wxitw6zr33pogy7dpkryynwbr1gu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 15A5C1C000D X-Rspam-User: X-HE-Tag: 1689839944-913336 X-HE-Meta: U2FsdGVkX1/8QhC9/R+CdQFCJXZZeBx0fvQBnW2XCQLhyiK/ayTfKnMXCROzQ0i7+iJkTy/BReY8PNU+JkVg+EDroK0Y5LyWHVc8Fyho7VZuXtlas8OAloiJMp0TA/ZWVVait3nfsvYeUfv/tegO9wrOSdD9R/FtEB1gOMNbYq+JwlfJnLF0Om+gFwR3Az5n1ylm89EdI9QOVhSanGA7perH25e18HnIRjBaeTCpYaMeVgTyhL69jiAg3LS1nYlAVNz3trZNdjhFp2x3RFzTTeLVFsI6XXKl6KXYjQ1pWeIXR3JLmKsT6ZSGj4oEZSTqcM1vK6XNzABURkATdII4MVQ/gE/suNeVBhowjBmLKZUpmdNcT/35wPOiDwkhW/0GWFV4/AvTYve47lOo0QLnT3V6fdq5YaFX9NIRCWIxyAmwz4CiKojowZ3sdtREZ2NILE/FPzoAwUQvHi/PbF8ExEC9bNXopTxwUfoEG3zN/wo1W5wxmr/0yPcs2iGUoX6WnwM42UzlHPRg4tFfrZjdhLH6IBRf/8fcT5eXqbT4Ag3T5sC61QMxykVQU5wwn08bL0Xy7QQ5QA0tfvpqbRMWeHTZhRYWcDvMjbfeTrrbkMJjaX9Zxihm4U9+OWtMBjtUaNiLCchkt0svKZvqdzXvzx3iwEXP3mkeSpyHGKZGIlYQo0T4JYz3zKJpSU6b86yE1ukXHWg+QxISH6uGSmp+96+j52XZQ4wT0STgMVAKE0fC6ZhbgCHZuzMU/fXhIsYjvpZaeuX2WZb2lvUJNaisL1EnHseLl2uacW7ksouKblmInZcxbQ3/pzhLrlAyJntqPvik1GgyJJpS1KlDkSYe512IhFrBU0K3Oyud6NogJXKQxxhN27k5bxgZK9guvoz+V7JDlFn/m/qmT8CO18tIufuwRSX2Ibc+WDIXCgsQOUz2KjYvqlDKC4Gw7/7KC1p1ex/GxDxuv1YAcwbITD4 JE1LHY7n irLxQ62r7EbHeoSTrXfcVbI+kM+TBUIXoMj5YuN8NsDJc+oq16dtf8kyG7RCmTxEGOkGBmaZlJsiox32hsdrfLVs070mzcAClauNUs7vDjPgZaI2lKLUGrL5cmRJcieDlUTlN0a9H07w9V0uvdSJ/V6cNnwZsLbdrGXsjIy0faPw3ZMZPRks2vViIjKv6BLB97TNhPfMiMva7u7ssvAJgCJZaTCoQ6rPkCt/WMscFPh5FZSIkAYs9Mfj6f2jOO3Flij1LBqI8id5wOs2pbl3J5V+0aEYJPrcCkGUJfsXm3RYLs7Uj1TsZc4GUO7hudef3d79tIJn/t/q/AmKHZ449Ikp4mRedPBNsGxghUTbSWx1aCy2vuQnRRtsmBwog7A0rNV77r/gvBYFFbbFuMhiMYWX4c0FM6GobUZzFUlQDU8xIG5ci0iFB6iYhgQ2Gp0ANq3ZFk7LvLOJEwQRYPs35k7cOc/u1/XGvwRXVosDbLJfG9v7BaAbfcsqUTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Gentle ping :) On 7/11/23 8:41 PM, Abel Wu wrote: > Now there are two indicators of socket memory pressure sit inside > struct mem_cgroup, socket_pressure and tcpmem_pressure. > > When in legacy mode aka. cgroupv1, the socket memory is charged > into a separate counter memcg->tcpmem rather than ->memory, so > the reclaim pressure of the memcg has nothing to do with socket's > pressure at all. While for default mode, the ->tcpmem is simply > not used. > > So {socket,tcpmem}_pressure are only used in default/legacy mode > respectively. This patch fixes the pieces of code that make mixed > use of both. > > Signed-off-by: Abel Wu > --- > include/linux/memcontrol.h | 4 ++-- > mm/vmpressure.c | 8 ++++++++ > 2 files changed, 10 insertions(+), 2 deletions(-) >