From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218A5C48BF8 for ; Thu, 22 Feb 2024 17:16:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A17E36B007D; Thu, 22 Feb 2024 12:16:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C8566B007E; Thu, 22 Feb 2024 12:16:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 841D26B0081; Thu, 22 Feb 2024 12:16:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7456A6B007D for ; Thu, 22 Feb 2024 12:16:37 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4BA8B40F18 for ; Thu, 22 Feb 2024 17:16:37 +0000 (UTC) X-FDA: 81820094034.30.C81CE56 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id CF63114001A for ; Thu, 22 Feb 2024 17:16:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cv+nUfIu; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708622195; a=rsa-sha256; cv=none; b=3k+wUxlYaOy9xtoQ3d7cY/OoqIqGdvEKVfYFNX1nsfvZa+UhRPPss73ewQPwxSFrc3sI5v vutO+iwtL+EqiDjEV1BQpbYYFw9qKy4zIltVqBw9rzFLKV0hjwmRJd6Gtr/WA6livsiKtx cEvu/zvyYKWdyqygOWoeAl8n9I4py9I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cv+nUfIu; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708622195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JTuukiLVYlOX3UUypO2eojhSEfBKmRllMc0/Rxzibrs=; b=2nSPt7ne0l2e80MNVlAXi0x31VTWKj2N2o5mMVY5kSyV0tTTVhdMOggCnCHF0lYIJQ5Kwh /6mfGuwMhkOiRVQzoz8MpWbipT0OuhNXxJOjDS9WMvVt6nLHoy6H1doGidK9ZEn7c03Wis tqmy2XH0K2XYUf/sYysDCVss44Sap3k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708622194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JTuukiLVYlOX3UUypO2eojhSEfBKmRllMc0/Rxzibrs=; b=Cv+nUfIuy/5p+mbt7l/VYjMLDgMOY0k/DlGOlADoC7yMfXF5idfFXK0cNmCq7ZkYF7MhoY VyxObl2xj1sh+D3TXkBal/l9ObWeoSWtNYTm9KyoZOE+0/E/HHPJBb/gVK6ztQ8ZiautNR b9/g6B6HrPTTqC5qwdjSY+tpfZXCQKE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-zMzfeHJzNpOcAGe_TCxlZg-1; Thu, 22 Feb 2024 12:16:29 -0500 X-MC-Unique: zMzfeHJzNpOcAGe_TCxlZg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41289591abdso3422225e9.3 for ; Thu, 22 Feb 2024 09:16:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708622188; x=1709226988; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JTuukiLVYlOX3UUypO2eojhSEfBKmRllMc0/Rxzibrs=; b=TCTWjqLSFPQNR/BDDXouQTD0UMFznffGIzJP7KkqU1BiiXNBOVi1Jtvy1s/jCOqG+0 UEErE54mduTRoUOCBctvu6lQMtnmno/8jCl/4818trNw2F1t+5PGXS/69TM5FcPjX3J/ /3KSdhvmBi2QOhFNGP1KtzgQrgdTBnhG43kiJeUR0skKBf6KP9qqLFHxjljBCsARBk1J N5sy0k6c77JUPjaWNlLVneMdvogUXaGjKXzWMS0pxdBDYiDnFxKHlpYZiliNYxu5qzIp 7ef+k0mODa3y2dF2x80+LxGGBuYyDZ2pEtw350NBtpswRuEOYMSlWLDBj91wPez8nMwm TTAQ== X-Forwarded-Encrypted: i=1; AJvYcCXK+CTgF+i6Ctw+lS4gz82FEmM0j8A6zNYNQJ8avloS7bfnoyBLEIy1RzPfmzP1rQcUKlNkKIm4VPaC4OGOwF1C42E= X-Gm-Message-State: AOJu0YwARILBUPufiHjClEbi92b8NDJ2dUTaOaE71UjRa7ace97caa+j JIZSdkKGvYri1mdlJyCLA1/kgdFHLTf+chkONHDhgHcAzOt4vaBQ65O3PSgtMKHWJIFuinY3vt5 QR1wCzLsCFwc1kmLnNQRZ0Kt497ovwo3XVvwkl0XK9AVIFpgfHAGdY/YU X-Received: by 2002:a05:600c:1392:b0:412:7eaf:c48f with SMTP id u18-20020a05600c139200b004127eafc48fmr2071396wmf.7.1708622188367; Thu, 22 Feb 2024 09:16:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQaBwe+yNbxOCf0kJIBDsT4UhayW64Euz2VeANOqZMjJsbMmb9l2jfM+kGXZb2yrcgTYnz+w== X-Received: by 2002:a05:600c:1392:b0:412:7eaf:c48f with SMTP id u18-20020a05600c139200b004127eafc48fmr2071384wmf.7.1708622188053; Thu, 22 Feb 2024 09:16:28 -0800 (PST) Received: from ?IPV6:2003:cb:c70f:8b00:ed48:6d18:2152:1cda? (p200300cbc70f8b00ed486d1821521cda.dip0.t-ipconnect.de. [2003:cb:c70f:8b00:ed48:6d18:2152:1cda]) by smtp.gmail.com with ESMTPSA id b11-20020a05600c4e0b00b004129013aa45sm229577wmq.7.2024.02.22.09.16.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 09:16:27 -0800 (PST) Message-ID: Date: Thu, 22 Feb 2024 18:16:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: remove total_mapcount() To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton References: <20240222160943.622386-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CF63114001A X-Stat-Signature: p8eaocdj5mna9obhsookqfq7oru1x5ze X-Rspam-User: X-HE-Tag: 1708622194-899703 X-HE-Meta: U2FsdGVkX1+B5h6XKVpu8uS65AMnvOsBPIubcDbx5j8SWNTb9SQAc3EJRLVdshsYOej5RkvIrz7hLIJp5wmimtkpRbNJo3eDKMOty11DwlZU+c3Y2u3zPZhg871660hVRzPCBsWOzq8mh3IiEB/R2dP8FV1f+9i9yOnUutrqzQxJgV7Bh6hvp49IDKXlkCrh5qY+b9qH6KVDAcwsgkeBCEeHT8qotI//Mr+GEGGHNAU+hm1/8KhdTqJjuRaCAQv5qSM61/ltvQd4lshqC6EwPY68w6DBeHr2ucJnmg25+1H/O7/+0OpvxcYUaJq/v5lGtSlehs4Sahs8FAtZc9YT1olsUHiGKkFeXc6ouoqe+xO1aDnEwfWehU4x+ljjU3T64cuxCHkQ1rVfdS5CZd0POj2+kqhzbNHzxwD5RUtIaFa7ccGW7PBfTBgMLCENAo06ZOl66KXisY9o7B52GlXJB4Pgfz79OifVmP0OwIif7haHqPb9iF6DiGDi4mA3bNKtHLg7H7EDgtZjfXWHSlUEa1NiVog1sQ9gbPPk2NE0tFhyrvRH5HJKaWrk2tmgLdYgUOBkxUvmJ3z04wHzfappjQQcjr5qvWYcy5U5Dc20++UhjtNpVwF4ulS/yEUcjqYlPrwzu1mRWph/t8Y9G+h/hXn8aSgrByLWYVatXXA1xfE0ATDm2hnSpPT+ybEeszq896u/HYeXLAXmvBAOy6wslpmp4kvb8HyqmCmT+mUIjXoHw3LQvpMA/Seve/N82iQ8i8ogEOcp5a4R9VD0lmSbVhzPAt8uZ+1CACWTpWh5VLDueSXb6fQb2qRCki0r/njhdoFJgWIrfo+5vn7nZ5wG66W3jj+Vo48P7F72ccTnUR/tYoQEV+hehjN4A29ppF1oROjzSdeWTl4F4uall9HH70UMsruWGnXALWVzWMnADHYI4GhonkjliwJix37tMTd3IaQclchiSu2zvK0ZCai 9ZxTeszK i5U0a4QVdXgU/c+1mvPVI5OiyGwa/KKTw69Vg7YijB9BBQTgrpzP+PRpnP37E/zYJnBWYhxj8bsNoUeMl6IQVlIf+PSKGE8I1UwStFOSXA7ye0W9p6EaFC1X3aJ3jqLEoQ9pkl1ZViskbIE6qNWrfaCPHmvA0PYXqIO1UeuSaXnKmKU7W7TGKVxyJxX+++XMV5SrqSEMx3vF42+vBeFPviwqvsdkKW/TAFrqqACFvrDcsIO9Oaq9n0MEzqnxgDC/lNc4DoONsb+/ZPkjGhtOXQiw4s7Ld4vr68jr+aw82GV3dYToZkiGJvhBUnHJGVrvjw8Zozsk9YqvVIIaRbwKFJ055UxGL95NHnO39uyUxoHdqFfn1YOIhM5+OniKs57IwfNq/Cf+DQOMRYb5MOCMnLXY004cJdVWmuePY0ghoo9yNWmGTaZP3KzgEXwYVlJOIKyhiLEoe8jkCvQL4/TZ8Otr6O5L9m/254D+dX/7y0MjqU6l8cbTUc4biaRM67ZUSX+dlzvLPCqBXc140wld1PK7UGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.02.24 18:13, Matthew Wilcox wrote: > On Thu, Feb 22, 2024 at 05:09:43PM +0100, David Hildenbrand wrote: >> We always get a head page, so we can just naturally interpret is as a folio >> (similar to other code). > > memfd seems rather confused about how to iterate over the page cache. > Perhaps we could sort that out and then delete total_mapcount as a > second patch? > > I haven't tested this at all, but ... > > Signed-off-by: Matthew Wilcox (Oracle) > > diff --git a/mm/memfd.c b/mm/memfd.c > index d3a1ba4208c9..45e55b0e3cbe 100644 > --- a/mm/memfd.c > +++ b/mm/memfd.c > @@ -29,28 +29,29 @@ > #define MEMFD_TAG_PINNED PAGECACHE_TAG_TOWRITE > #define LAST_SCAN 4 /* about 150ms max */ > > +static bool memfd_extra_refs(struct folio *folio) > +{ > + return folio_ref_count(folio) - folio_mapcount(folio) != > + folio_nr_pages(folio); > +} That is an obvious improvement I should have realized myself. Let me play with that. Thanks! -- Cheers, David / dhildenb