From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 984AFC48BF8 for ; Thu, 22 Feb 2024 10:19:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07D736B0074; Thu, 22 Feb 2024 05:19:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 004FA6B007E; Thu, 22 Feb 2024 05:19:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D73376B0080; Thu, 22 Feb 2024 05:19:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C1A916B0074 for ; Thu, 22 Feb 2024 05:19:31 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6E77040D50 for ; Thu, 22 Feb 2024 10:19:31 +0000 (UTC) X-FDA: 81819042942.30.2560666 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 2D2C720018 for ; Thu, 22 Feb 2024 10:19:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S15Cgsgx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708597169; a=rsa-sha256; cv=none; b=DEVtt7yXi95zj7QLgYJW7kkpLww6lLTjTnv99QnJK8Qmkix9ouP9qseXaRtIXgz+uDpRcX xv/i1feuvdCrgUxOSDxc424DylGVFUJPTH8LZV42WXbh1wsuA+CoQso7e2zqPnaDD7RPNZ Aw7/17sEVj6dv9mxgejE8a4to7G3lrw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S15Cgsgx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708597169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aN2CoCAXzjDD0pifuFrV69E7GpRNjCsHr9lhDc//c14=; b=nF7cOAre2v3/zrJjmWAkMv+LU59rKXOSpDu0pqSbTY4zuNxGc0AGT04MW+BhkJrKgGJrwT OSQ2DVjaMEMuCWq2mGWEqVENEuK9Rdiz6An2/IsLUls1iD4eu3MYojQ/oIGPZ6bluqqe3M 6elssGpm0JvVUIoM1qRFx+VsGAeTaxI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708597168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aN2CoCAXzjDD0pifuFrV69E7GpRNjCsHr9lhDc//c14=; b=S15Cgsgx3B6qmwBQj1U2IWKitSD/m5DJhsxjzQnvxB14e3w7x7yTBxyxXjNQgBMqV+iaNy ZCc/uHGtLwr2dNWeBUd5GsvPE9r6GODThieHw8eE3svReWfWe6ZC084W+qMhqF+uaXOINU opOo9UZAgyaulrlDNwGZZa3l4Phbux8= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-l6ab_qxcNKq5SFsuYojG9Q-1; Thu, 22 Feb 2024 05:19:25 -0500 X-MC-Unique: l6ab_qxcNKq5SFsuYojG9Q-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d25a02f48fso10523271fa.3 for ; Thu, 22 Feb 2024 02:19:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708597163; x=1709201963; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aN2CoCAXzjDD0pifuFrV69E7GpRNjCsHr9lhDc//c14=; b=QrNITaRXHb+Rh27tCyNOEudRJTKOx9Z1eybbCgDm8lUi925N1HkJtFD53wDO3+UFR/ I6y3GO7bOQQBLI/zLDPBlRLI48v+cqTzXC3pgTIQXvex1DSk+hXeSSnXhv90/mAXCMKT txqtRYIJKMRAjwZCxTIEBYdDfCawcMxD5FWbD+A0GUf2H5NcX7iWFYiGpyVSdCEVtOgD ISUzZt+HjyrOoW+WbzdO/kQMZhHtSqk6FxzvRxD9VeuPMPi6LnWDX2REpFbaA0z+So1X KChYfY2KrpL+KPmFpKesvy7yHItZAlZnHW16ZWm1FOIhvuqEb/iI6YKW4D6G8OHcnXOh j5Eg== X-Forwarded-Encrypted: i=1; AJvYcCXTgLhZaPyXDcqnawSq61GbLy+ZUf3fdMEgHRUonr8XHyutdvzh+EdZf8TAEgNLVQnT4qbJcI2XL9UoYEw5iNmhawc= X-Gm-Message-State: AOJu0YyJ2yEF4M6ZnVGHI/x4mI2CSeAaDFG6gaYQDY8L3YnhqXUS+weL bCVi0PI5e0PRHCqa6CpI6aSqVcgPrhAgFYDe4D/5IcZmFjELHX0hafJ8wOdLKUU97ihKyKFli4G StPFI2YiFCfZ2EXLgiK9/3IqO/VqU4bK1bUZILQW4WnyYrrOt X-Received: by 2002:a2e:964a:0:b0:2d2:532f:bdf2 with SMTP id z10-20020a2e964a000000b002d2532fbdf2mr2827537ljh.51.1708597163764; Thu, 22 Feb 2024 02:19:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBLRHY/USPLYOTCgsVmAMVFjziJJbZ7u64lgCEmUSGCDYG3txCczGdqjeNiGjsPvptaXoZpA== X-Received: by 2002:a2e:964a:0:b0:2d2:532f:bdf2 with SMTP id z10-20020a2e964a000000b002d2532fbdf2mr2827506ljh.51.1708597163260; Thu, 22 Feb 2024 02:19:23 -0800 (PST) Received: from ?IPV6:2003:cb:c70f:8b00:ed48:6d18:2152:1cda? (p200300cbc70f8b00ed486d1821521cda.dip0.t-ipconnect.de. [2003:cb:c70f:8b00:ed48:6d18:2152:1cda]) by smtp.gmail.com with ESMTPSA id a10-20020a05600c224a00b004128da16dddsm185325wmm.15.2024.02.22.02.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 02:19:22 -0800 (PST) Message-ID: Date: Thu, 22 Feb 2024 11:19:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] mm: swap: Remove CLUSTER_FLAG_HUGE from swap_cluster_info:flags To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231025144546.577640-1-ryan.roberts@arm.com> <20231025144546.577640-2-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231025144546.577640-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2D2C720018 X-Stat-Signature: y3emp1zrmq3b5ie4y5oweuc1xbrgiwqw X-HE-Tag: 1708597168-397676 X-HE-Meta: U2FsdGVkX18OP3j1DVY1vK1IifPEQJkevLMs0KO4pTi/Ad/bZwZpYffEPrO0HNGNx0n5b5kPAQ920VpeIABkt2IlZyXuXP+lAoUKwozTWe+1IN7WBjtGW1Dt2IOiji+dRihjmnOKjhzxYg3O3CXWc2RkipxxUcuNbe+G/MuqsxhaZVlTyKNrtU7JJvVPA4Rg7SZCRyV52VTZy/v0nEU9OQfNWzZhWLmtMz5fY5gj8AhdP8ljECzLlsap9xWrXJVm5YAV/n+/Tn3NB/nXt3y0Q+YpVflaKmVl1waKmaL3NzC14XzPoVvgS9plR3e2DPelc156ehDis2Siws02lZMDxVFO63ICx9FsmxGsZu1DcAbCQBPdn/60I1WiYvAkQOZ/+uYa8hs7e7dYxuGxnCtXiJymazODwsWomGoHz5IS/Z0rg/laqB1mUMHM3LcpFm8RU9EeEZ7rHbrSkS8sbvjdIw51pgDWMRjQU/73oEUNu1+sxOwpg69CmCOZOzXh9Vz3ryLPQh+U7kT2wxz+vWJv3FPdGGUL95dXCLGJYpehLGWGJg1/ZWR8JbcXC1QWlZLDFfmeG3R2adVOS9JhTuL5Olstj79LEeiSmK8h2vtv14QWStfNCWv7mcef+9jIIenOWXVEoJ5tSoANLBE99qNBIrsMSeN9RMTXLSpxX7XBjJ2NDi25XaCyTrTjFuKC4Il9TC7p8RzIZRu7yVXjhkaRBx9kr5f4TkAY9ugjzJHoI/yfyrSZl1rfKTxUHvXK0kBS7EBeKZcK4qfTusJROaPR9WYG1yKku/ib2FZ638hsm1rAqx8JPKLnZIytX8Lv3OJGsMyba3bInrut6oNFAknevJ/5md0Ka5r4L8lDUSPnrJLsN3AtnKUWJtY2tnIx0hAFb/O910m1s2u/C6s6oJrtgmujXVzcmvAt7EREBw3WyiFGoVPMkP90AL4P0jx+Hs8CAEyBAX+3iYGtzF9Ri0M DTZ8UULN eDxHpQ3/EBSm8n5ZfZtIIMvdUCV/MpKGuej0ucRfRDkA6CRMiayLY27679cpCP7QbVRt4Xq7mRxwg8X8eYLFvgrXZsoA6xtpo0n7VSYXsbPEmn3N9GsasQ21W6qeIkM46FoaQjbanakKKIUFC7gqa0aUmnrFBOeNZZJA/Gga+x9fiJykJOLINCgoE6SRWDRN/SQl/L58QpjTZP87eexgG//xUK+Ev2ZTBg9MGHvu/eVs5FpuMsQqBfXLyPy0p6QwfPqFgvbebGWJ1llvrY2DhGPSJKmgt/tZaFykD3JlUMnEuIFiojGc3NN9EGUJiYv+/jBR2xuT27q84hFdTlbaeLYyqgkPmZZA/Crnw+PaQkH7WcM3IhQk/C6XcwAcpr+rV2KSdRBGpmQawe0bb+aH+02MJPRiNXEHxyImiJ2k2Na9PeeK/1GGH1cZ69ubxdkqKy04HsVU6MTxEtRtS+//beLVgkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.10.23 16:45, Ryan Roberts wrote: > As preparation for supporting small-sized THP in the swap-out path, > without first needing to split to order-0, Remove the CLUSTER_FLAG_HUGE, > which, when present, always implies PMD-sized THP, which is the same as > the cluster size. > > The only use of the flag was to determine whether a swap entry refers to > a single page or a PMD-sized THP in swap_page_trans_huge_swapped(). > Instead of relying on the flag, we now pass in nr_pages, which > originates from the folio's number of pages. This allows the logic to > work for folios of any order. > > The one snag is that one of the swap_page_trans_huge_swapped() call > sites does not have the folio. But it was only being called there to > avoid bothering to call __try_to_reclaim_swap() in some cases. > __try_to_reclaim_swap() gets the folio and (via some other functions) > calls swap_page_trans_huge_swapped(). So I've removed the problematic > call site and believe the new logic should be equivalent. That is the __try_to_reclaim_swap() -> folio_free_swap() -> folio_swapped() -> swap_page_trans_huge_swapped() call chain I assume. The "difference" is that you will now (1) get another temporary reference on the folio and (2) (try)lock the folio every time you discard a single PTE of a (possibly) large THP. -- Cheers, David / dhildenb