From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9B6C67861 for ; Fri, 5 Apr 2024 20:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 617B76B0085; Fri, 5 Apr 2024 16:37:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C7B96B0087; Fri, 5 Apr 2024 16:37:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 468566B0088; Fri, 5 Apr 2024 16:37:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 29AE06B0085 for ; Fri, 5 Apr 2024 16:37:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5CE0C0528 for ; Fri, 5 Apr 2024 20:37:49 +0000 (UTC) X-FDA: 81976639458.15.67AEE52 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf13.hostedemail.com (Postfix) with ESMTP id E2E622000F for ; Fri, 5 Apr 2024 20:37:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=qVNO4XF2; spf=pass (imf13.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712349468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=snpp9s/J3mH55/eauNtpL5oaMuK6HQQWr21+VcDnxYk=; b=1QaUJ4PIcOh/tBbIW+PgM5JEt/+HQaRCQbwIrVRQ5u7VwiqfMtaatWW0D0d6jQHASDQJiP RSjDvjlyZQOMaQDRy9FhgxmQwbiOtH5rt9WgYJ3bNTTAb51yqM5+QA5y8+qC0pfvkufr0F zlrYz+iXC5QDeHKSpHDRyT8veHSrS2I= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=qVNO4XF2; spf=pass (imf13.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712349468; a=rsa-sha256; cv=none; b=1c/6ZxXD8EVyCrwZbwaHTYz49FYSn78dzMiQxwoZ5aUCDeu7C4CmPWc12UucRFjhjTZ4RN QZAFwvdiJrUJgYcvdIQyNaRkoP4CDPLtehClD27jvExK2UFKtpwDA9YHuamyFyJMNVeGNT YUJAQSDiX4nrTqxrG8yndQGDxo5mJ4M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712349466; bh=TlGlGuV5AlXVHNKNLj1rE35qkDjG+kSQ0iD+td99z/Q=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=qVNO4XF2L9KqxAGJJaGvGBGCKEVV3bFO4bcRdlwURbu4byJU4Pr+5fIb1uh70Icv0 TBHcro1iPw3pXn5WAwTKwHhbPykPnwrmzqlN/EsL1DosoOD/4KQAUhSFMfWPZfJ16n TzNCWuwkaUPd7Nht+4qFZTD4rSsYQMbTNQXCg/ku8xWZcc+62VzI2Lo/ZHXpEbz9f1 V3nd16CQCdMDTKlfc1bgWS03OQOaVKaFHxCFXm8AiK8OKOAyGheKPqg2zKYXQ1v3Nk q2HXHtes5qzm1SQYyaxnFgL3aMIWYaO7bC23qm/3E++nvrqMKt5xy3KotiYUWNEYVw Pot7kax3OiiBg== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 1ACC737813DC; Fri, 5 Apr 2024 20:37:35 +0000 (UTC) Message-ID: Date: Sat, 6 Apr 2024 01:38:06 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , "kernel@collabora.com" , Shuah Khan , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Eric Biederman Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() To: "Bird, Tim" , Shuah Khan , Kees Cook References: <20240405131748.1582646-1-usama.anjum@collabora.com> <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E2E622000F X-Rspam-User: X-Stat-Signature: gpozxh5xrnbn3drd5fg745ed96pko3zb X-Rspamd-Server: rspam01 X-HE-Tag: 1712349467-606308 X-HE-Meta: U2FsdGVkX1+LyPhd4eCc//+fkc/8oXm/7nLnhEtqTCV5xxBqo9Yj7pwbAyUmtyYk0wPGBJrwDtgQvhq8qpI4DCYO5ZtwtnJkw6Rkb98rD6ZPZAXFCydvCC2wcuGHTx+qqvAARBI92tX03sURWPCOFo1h5QQC51UPrEtSvr/IW0pL03w0JO7+rXEBKoGVgf+n07+aWFw7eNhskW6Nm2LVQfrERsTWSIjY3TFuwK0sASTevwHHbEZqQCap5HSLkBqnHAoq8Is2gMxLBnPEI1wpHrPPNhs5vGd1zoqqdy+e8n265ME0DSjjm0p3nyxCOPTrLYBJbyNObXwd698nWv+HwcY1miSeR+NbalFv0mJCW1WScvfCtPlCPjvKfUDcWvGbpt4znxdNZD/2qaVfBihYpkllfKwTnabmqGSZ1Y7qgeJnAY1EFadARC5PWaOKRms3W2WKl8n05CVncqnHSHphhFyjd264fjLkFQzIPQprHStxzdsVrHUvSdWQP7LrW35E3brpM8cy9Kr3Kb3X48/jtfixZ2CivX1uLiIacXMRcuaYM/FkIDwvGtMx5es6c+4+z9ohYMnAQ2DpsA5MiUCDP4jk5tNLI5jj9UjI7/Nvj1X/CTedWQc07Hgfd23rGM9golPmCg4ASRg1m8LDR7q5ez0G5B/y/2KcAjqB2Ywp4Mj7FpzIlpsG/yjIWuUCplNDGTrpTb9TL8O3mwV/ac0HJWJ2b91Fm24+rHYXBhAlDANWmpOivJZgwZxr8VYskrkmA4QuFvA7FbTgn4gkWIiYexkEibWHcMjg2R/dJWiiqMRvLsGoHJRsJCXB1jGeGwb+MdD1iCr+y7mmncCAyu9Anjt9G+RqV/eVlEVKdhBGXtyGrimavc6WWdY8MuzoHCI9hWfe73dm4v2rcjrqmwfh6h9LRB75Tca70rXcj2c671BLxQL2GqJLy9hCbAhHRHNVpiEO9gY7CVI80wQfS8o X7v0ctmy GoEP5XGQlrFVZquA0joxt/JIMyhQ9GOex9MWTnAfPFuiT95s8OzKLgt0guXB+QLhWBDrz+ttpczYPO8oa7Qah+chEvHE32fBXCP5gTWegPCGLSLK52alQ9L/0+mVG3Imqgv6jKhVf0gV3pBEmhb2AH0deUDyK2/ZaED8nWRCf23vwDyHGC5GOL8mUOZJ8meEBfWsNOyINrZJYWovSqxoretNUuHH8HQznj4EvX0i5c1ro/4vT+kS2jc15JWFM4VEZcWMuaV3BkR9sXLH0TcVItjZF8bgB+nNAsyjNBNv+4OnzmscYcCT8ogWjZfGjJ+y+zFUpoSMyrNwA8Zd8gte+suQ6OpYhtiNiEGDdNMTS6J0Ifel4+9rGupjEC6Etx79ny1LOHPwCmLqU/2TCHivKjmDGKwAcyow2arRBgk2UryQLRTeVDCqNTJxt0Fw05hgCfcJ57dP7eHu+zQmW+Ww7NTdTkbHnJEh48jgD+HHVIRLjL79yk66DvSZ/Ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Tim, On 4/6/24 12:36 AM, Bird, Tim wrote: > Sorry I didn't catch this on the original submission. > >> -----Original Message----- >> From: Shuah Khan >> >> On 4/5/24 07: 17, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It rather should be: "Failed: " and > then this added prefix >> doesn't need to be added everywhere. Usually in > the logs, we are searching for "Failed" >> ZjQcmQRYFpfptBannerStart >> Caution : This email originated from outside of Sony. >> Do not click links or open any attachments unless you recognize the sender and know the content is safe. Please report phishing if unsure. >> >> ZjQcmQRYFpfptBannerEnd >> On 4/5/24 07:17, Muhammad Usama Anjum wrote: >>> "Bail out! " is not descriptive. It rather should be: "Failed: " and >>> then this added prefix doesn't need to be added everywhere. Usually in >>> the logs, we are searching for "Failed" or "Error" instead of "Bail >>> out" so it must be replace. > > Bail out! is the wording in the original TAP spec. We should not change > it unless we plan to abandon compatibility with that spec. (which I > would advise against). > > See https://testanything.org/tap-specification.html I didn't know that exact words are coming from TAP. Thank you for catching it. We don't intend to move away from the spec. > > The reason "Bail out!" is preferred (IMO) is that it is less likely to be emitted > in other test output, and is more 'grepable'. Makes sense. > > This would get a NAK from me. Let's drop this series. > -- Tim > >>> >>> Remove Error/Failed prefixes from all usages as well. >>> >>> Muhammad Usama Anjum (2): >>> selftests: Replace "Bail out" with "Error" >>> selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages >>> >>> tools/testing/selftests/exec/load_address.c | 8 +- >>> .../testing/selftests/exec/recursion-depth.c | 10 +- >>> tools/testing/selftests/kselftest.h | 2 +- >>> .../selftests/mm/map_fixed_noreplace.c | 24 +-- >>> tools/testing/selftests/mm/map_populate.c | 2 +- >>> tools/testing/selftests/mm/mremap_dontunmap.c | 2 +- >>> tools/testing/selftests/mm/pagemap_ioctl.c | 166 +++++++++--------- >>> .../selftests/mm/split_huge_page_test.c | 2 +- >>> 8 files changed, 108 insertions(+), 108 deletions(-) >>> >> >> Andrew, Kees, >> >> I will apply these to linux-kselftest next as a series since these >> changes depend on change to tools/testing/selftests/kselftest.h >> and need to go together. >> >> Are you okay with that? >> >> thanks, >> -- Shuah >> > -- BR, Muhammad Usama Anjum