From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EDDC35FFA for ; Wed, 19 Mar 2025 12:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DECF280003; Wed, 19 Mar 2025 08:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86712280001; Wed, 19 Mar 2025 08:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69526280003; Wed, 19 Mar 2025 08:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 452F8280001 for ; Wed, 19 Mar 2025 08:03:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A9949AD129 for ; Wed, 19 Mar 2025 12:03:02 +0000 (UTC) X-FDA: 83238164604.02.2BDC449 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 236FA40006 for ; Wed, 19 Mar 2025 12:02:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y20+15DA; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742385780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7gn15plHVRiqXpFBn0Z9q9dTxOPDKBEPCsHLFphLWXc=; b=WL0Cij8S5VTd66ifOGKHyNkXP1bCGydpN6+adnzTNAxJ6mIOXV3Z5RLbGdqeST2Zpc/ESj LdDSH253O80QI+xFjRYaT5+lg76A7jibTiRvp9q/qK1zpFppDgiwlgEyRFwyQ1uk3HRhVl EbWY9ufQTbAXhmKhoAzmVZZeSa+1IV8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742385780; a=rsa-sha256; cv=none; b=DKAYiooSEcjery1dCMyiJ7oIiXIhXNtJBRORri4e9XelDOp28+OG970lMv583hd9WVI3nn iYSlgByPwZ/0//M3L/prdjuQO6lKH31fXu0WdJlvdUiHioB+d6sR0tXoBp2JNE/GTd6dfM uRqSMYYia8gEFYuEisp91kKM1MQUO3o= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y20+15DA; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742385779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7gn15plHVRiqXpFBn0Z9q9dTxOPDKBEPCsHLFphLWXc=; b=Y20+15DAQhAkFq3bvd7HKEgB0wHKYqiQcPn9ZtAlUqqQAYzSPTKiRUQvaRqE8r7Gof9Hgm 87+jiRYSjXGrPHczw+xZqy4KwY+8i2YPtcEpD08bf5eG2q9z+lqvBjT5u947CUNTL72+1M QkaUrC4/Zy6/CLAy6+nQfCah4lCf6IE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-DhJsXWR_OQ-1oCcjwbSYBA-1; Wed, 19 Mar 2025 08:02:58 -0400 X-MC-Unique: DhJsXWR_OQ-1oCcjwbSYBA-1 X-Mimecast-MFC-AGG-ID: DhJsXWR_OQ-1oCcjwbSYBA_1742385777 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ced8c2eb7so32744555e9.1 for ; Wed, 19 Mar 2025 05:02:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742385777; x=1742990577; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7gn15plHVRiqXpFBn0Z9q9dTxOPDKBEPCsHLFphLWXc=; b=Stz7qelrWNn0tY2y8Y7j5CgiqXFGa+Ql9tARBztGB6Crnij+CT9L6JLF8UywO7yRgP eXV2sFdpcc+gcdRzYfFhIkORGqiV95j2TxZbwcXIOfESg0+/tyoHLxO+jJL6YEpEAws5 N/vwytt/lo2Bhm+0z4VJADN4Ow4Jnl5D62Ro5/MZcFWPVE5q539a7mZdG8y3O0HXco9W KeK4aJmIUtcc9+wKpa4lcwFUC50pmlex0gjP40gHdKu7SUEtjizpwhh1Ja6I5TW04sTu a2FutGQPSghsuth2JYIXRd36wVE/HwoECn7TToTpsC3eCr87Ddv/TcNY7ekBAgDD3oOa FLWQ== X-Forwarded-Encrypted: i=1; AJvYcCXXODmIxS5JoPLPd6N7NtX7aMQTCvMWpn8wU3JMbTgSEgtHI3MD8N3R3kX7whTIZuAtooQgR+6+7g==@kvack.org X-Gm-Message-State: AOJu0YzIDwB8aWe8X/3uVyISZz4iNjqhn2nwsHZALPsbbcqHmOkIOIQe mXOUp3qrLRJSux/GWbNPMfY5jGw07i7sgSGajvMA4zPzFx/lb03NBo0xr5XIWq6gsi7/uaIuRFj kgQlQZSJrX3MhW/oxkWlNyqM9L3DtAfvDvD8crgeqbiVQL8cKgYZkLxwSSQQ= X-Gm-Gg: ASbGncvemJPFiPk4NtsK27kInFl3MQdDCDbmbEwn/lT2ljCnp1UDHTQuDzjBVU8JUgc s1SWGjwiNzXc+noi3Vax0AWjUSLbs3m+NO513EPuA9AqLPP/Z4utmgcaMUVnF0gDDO8RoPVSe2o pEOjvxuG/pDghepRwd4sTMQm+gbaWn8jppzrC7rHvHgM518jpoa6DXSdLpDwSVN+6dJmR+Iebjk bj9Ak4KCVb3sdQCCnV2789yeFo1yP+yvmyeivvMeP95EvHePySKIDdj2HYQ9rJo8p4Um+UtHIbv LJaKyOq9De8jB1VjMGkQz8QvbWhfM6vX3dPRP/cbxnbc0EA06yD3LinBLht8cWevhHJeituwQ4C YvdXAAl7PCyFmwCtveGJtPRxwlf1PzuidfgO9pOl6L30= X-Received: by 2002:a05:600c:46c6:b0:43c:f5fe:5c26 with SMTP id 5b1f17b1804b1-43d43786292mr21442345e9.4.1742385775517; Wed, 19 Mar 2025 05:02:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEO9wFO2nTkTUlJSs58/meqK0dfmIPHPe7ubDLeTE+LBbIu5UE13qcBy19o/yn3H77bmuGCZw== X-Received: by 2002:a05:600c:46c6:b0:43c:f5fe:5c26 with SMTP id 5b1f17b1804b1-43d43786292mr21439295e9.4.1742385773180; Wed, 19 Mar 2025 05:02:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:df00:67e8:5c3d:de72:4929? (p200300cbc705df0067e85c3dde724929.dip0.t-ipconnect.de. [2003:cb:c705:df00:67e8:5c3d:de72:4929]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d440ed4cbsm16960215e9.34.2025.03.19.05.02.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Mar 2025 05:02:52 -0700 (PDT) Message-ID: Date: Wed, 19 Mar 2025 13:02:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] kernel/events/uprobes: uprobe_write_opcode() rewrite To: Oleg Nesterov Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , Andrii Nakryiko , Matthew Wilcox , Russell King , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Tong Tiangen References: <20250318221457.3055598-1-david@redhat.com> <20250318221457.3055598-4-david@redhat.com> <20250319120028.GA26879@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250319120028.GA26879@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5NhrAVXL-Q-2XKiWVK2yfUdI1EJn7YsZKmTPa9dWfvU_1742385777 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 236FA40006 X-Stat-Signature: jw1omrk8q5cy5fpcboxgwau5ct4nj7pm X-HE-Tag: 1742385779-368913 X-HE-Meta: U2FsdGVkX19sRaQCC7BEce5yvYUCuOMrzALO4KvFupHdPvRj4QCkcQVmIb7KLJDdRRRtdMxeX+pb5tqCqvd0TjYVs+9HbIKnMoT2FktYObewP4E70mo5l3bxJYHuOdGbSRNIuuYv0mlCzup08m9TKE6AUk73X0qcb/JXDwnvURO/EDUSgyYD2FBkGVnU0TGYIPVT7toqmzdEqgLV8+WkQTu/5AqEIjiXE+jU5zfpxlJ2HnIhGsc29W41jXM3tKVOn4t5FkNQUY1nwcVzxCv1UXaMHv19b3p6NwWaugbuS41XcdTG5zLQARIsUSB1pRFmxPTHISdU5kzv1Kn2GO3XCTMjSVdvbWAzujSI2XF/XQzYE+3ScA9DwZjwcA84eEy5QL12seJvouJav+rsUCXojhYbQR+MczqAVnFggUTYZblCAURnBtyO/ljC2MOrW+TalR1/yWbTgDgRbZmW+FG4C3QBFZAxFNwg0+ZvZ7OI4ME3KhvzkOGdk/zoKUlCTI+oOdiGCtlg5oAubbRR2xFSVuW237QmdKRSBOdC/Elpvg1/SPegvz1FaBoPPlSUKVzBjq9Ri0mc4XKJrzeUZkrdUZQFRCDeZ8/iO+HKWJle6GBB226siSCBGcd6Hds56elmM+yJvi5NccDA7q1JVzgmpoo8GIBqV0ojvYvGyzHQsbg4uxDQxpzy7/WxjgoYVFHB3E+K+u2qIwRt84l8y54GvM/Jhj7GjANNlDenLqjo8o76/WRZJytCLvlQ9lm0LoGNkULWrn/MaO5ckHeEI9zQZIJRSG6qt5oizltTH3lo40CZb05K9l4bDzF9seIP1T5ypnAMNd5cMmfkW1lqzY2OE4cO39R9aHgXUp0e6ZoPlHyKxxOxSp+bxjV1YOjOQ942/GojubQesmAnYnAQkoizZi6gffhe+OprnQo/R6m8z27djKZZfAgSMnobm4yhOItLwGm8fpBcjo6nM3G406C pD64Hfx5 ZF/1jB566p9pVEtEw7wB996m9aEuoOgHAgvAjF3IeOxW5Dtx/svyumEv5NXfIYtNu4Weo+0ufTPyHB5Y/pUBLNvX7pMT6/3vfWB88cwLL7Kx3+lsbRjxr7gkbZlmW6MIvWAqOMp98ZYB8jduSVR0ab8cTk5I1JJCZ5gaDQuvcQTX2uK75RNXsAJklghpBc2ewLv1+K5wGnAjYEMk1L/zohseOCByTY5oYL0tc4VoX/3O/I6gkyZAjq4l2DHPwLOm3Um36HVd9M2wTrWjORGpWWVdCrWaynnS7Xnq+QRcDYQIZ6j8O98hFVtD+72CgIwSBif24IK8pMPwFB9XrzqXLJEVjscHk1+ijc8SWFQTubvaM3FphTcOrZsJrzuLsHHTMut+QTUE9hA8e8pfJBHpoDpK7OYVeYn6wHLZsmyjsTtB3jbKKrIMs0nTZk6dZJBtKHlePZsKfXqJSOS9+aguxZm2U+4KmQ3/jy1tUlStgLUTvXf9IP8WLBz4pBq104i5xYudRRDAwxgfA+wV8qSFf17KuwikahxkFzWKd/6o4WXB3m9g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.03.25 13:00, Oleg Nesterov wrote: > On 03/18, David Hildenbrand wrote: >> >> + if (unlikely(!folio_test_anon(folio))) { >> + VM_WARN_ON_ONCE(is_register); >> + goto out; >> + } > > Don't we need folio_put() before "goto out" ? > Yes, thanks! ... as always, the result of some last-minute reshuffling :) > Other than that, for this series: > > Acked-by: Oleg Nesterov > -- Cheers, David / dhildenb