From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C1F7EB64DB for ; Thu, 22 Jun 2023 13:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FC228D0003; Thu, 22 Jun 2023 09:38:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AC4D8D0001; Thu, 22 Jun 2023 09:38:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 274FC8D0003; Thu, 22 Jun 2023 09:38:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 182618D0001 for ; Thu, 22 Jun 2023 09:38:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E3E55160A42 for ; Thu, 22 Jun 2023 13:37:59 +0000 (UTC) X-FDA: 80930487078.23.3B8BCBA Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf27.hostedemail.com (Postfix) with ESMTP id 45B3240018 for ; Thu, 22 Jun 2023 13:37:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eY4b8KGp; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687441077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1jglPl1BaNsq2aWOFFG0aEAGoPtTBVAW04OVx3x+zjo=; b=F0XcVPX5kKDFXGeAj7E1xyfr8F3LAdfivUjJk4zv/V3ouHCjsbJnmNMPFwR5G9BP3UmFRd y9OWMsCjceIk+UoqdbY88CJrkQ1BDkAK0ISqsBkIKc/ZlOPtZ/u+PCvaddNrktq8zsxQk4 8NC8ngz4w0lGvObpFLZjAbjUGGX5CPs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eY4b8KGp; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687441077; a=rsa-sha256; cv=none; b=zm6FYxSdzRRfrn3MO3hvJ1Yw7D8IVjH/9Y5YxAzEjpntv2hXgwcBHgIpHHPkJacC3NS9ms mHIFviF2aVJMYwwb768v0QsKOXI9Bu3RpulT9/rCOdJrCL20ncznG35+kY/ywRPVw0XOdj LLtRUyHuOd4rV9LJV4jmMQIpAspeLzo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687441077; x=1718977077; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=88JqeT9MZdKfshSYWUg9b2Zs8SDEVOQUaP4tUg0s77U=; b=eY4b8KGpY6b/RRhvwdWCPB1lZysWYxgRkgukiR7Ewjssy9Sy2uvtUFXb nONYAfIoG/PPvcGxFCLIg/V0x5PGEXxhyxyXa6XDrQoMUHBumpTQfv5yz DVj8B+STwoNNKugFrxPLmpKMu4PG7NgN4t8LUhPOupHTOo3Yel3uHbn+Y IYhL2C7PT21nGC1btuPZYUZl7Oxn07AFo32U6HgY3I99um9b59tCUQC/2 3DARlneyvxrYZb9MipsEV/laNKCdTQXdPhAivvesjwR91soHVkBEkSWhx 9Jh9/Odb0B91AMqU2orShl/htyHIUDN3yGSwkku6hSAF4V1YPFHWkILM/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="357982797" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="357982797" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 06:37:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="1045176209" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="1045176209" Received: from pajgaonk-mobl1.amr.corp.intel.com (HELO [10.212.235.136]) ([10.212.235.136]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 06:37:51 -0700 Message-ID: Date: Thu, 22 Jun 2023 06:37:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Content-Language: en-US To: ypodemsk@redhat.com, mtosatti@redhat.com, ppandit@redhat.com, david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org, will@kernel.org, peterz@infradead.org, ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, arnd@arndb.de, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, akpm@linux-foundation.org, sebastian.reichel@collabora.com, rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> <680fadba-9104-3914-5175-e207fd3d9246@intel.com> <79f29f99fa07c46dbaee7b802cdd7b477b2d8dd1.camel@redhat.com> From: Dave Hansen In-Reply-To: <79f29f99fa07c46dbaee7b802cdd7b477b2d8dd1.camel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 45B3240018 X-Stat-Signature: aziz1xy9mro5i89s4bwb3fs7ouwt3yyb X-Rspam-User: X-HE-Tag: 1687441076-684038 X-HE-Meta: U2FsdGVkX1+QBKW1b7oIYe0ru3/WHteGk3vfPelc7x8/SptAa6RzvMhglEY/JL7coG9w0JWMv3OjaJVfNEENDrUplnAlOaCmEduZwS5oCNaZHQENm0Zg9vBztlVe+IpSCEONWUrrzr1OpPg28uvL+2/P2qPThcLHaIy3Tw3t83MPR2m5WneyCRLS4t8SjWB5+kYzL668wEtFqESAc67WvTlA+TTfpnoKNffOaUzJd11N83wVDi5Zh9/nzINFFugE8/ac7UrDQ1bTJCyP+QYMfTiKlWe/ZqlphG1igbM8BU8DUhgaId6CPWx4ZHaESwJxtLe2xg13Vz22ac+ohDq2wFE3OOrCpKgbDuGLT0kowr8yoYae5eFbGk/pkYT5wAwEnSxsYeMqqNKiJbs+QWLWeKg1c0+n8sUYavtRx7Cn7FAkiuauPvWT3VXpwBx0jkAS6Muyx72DNhWzXGBfthavVurb7hSXBhH56KS7MaxAM7W/kHwceaDfE4GZwEV+/E4on8dwGc7gbuo6o68d+WHwQMkQXVglP4GsOY9yJgd65fCzAeOp3K7hWZlJh5gFn+EppHUUHNzytcqe/t54yTYmpGYjQ59P6TitRDawlP1T9Vh4cLQHHMuQ7CkZ24Gsn2OPVJYmuNoc+pGbR21nY+imrlK/I+xDI2qU7esf7vk5SC90EAGyvaugeYsLw9R3x9krBsc/mq58L9H/q9vX9p6UdTiZl9KXErcqVIJMo9C3PXk66wewp+DsgTja1vC+iPYJisJvnG3t1dAqR4AqDinpu5gXy0jpdDscdOD8R4PoKgh28uKinF6yaelXwQwI8RqKFCXM7B1yUALB8Eyrqri7asjieQNxQEfFPufPIDMbCtnwIcjmOHO8y6blgthAkHxnDE0QjDWDEZwYIpb0zrjEm1y7HvTMPb38ud2U+P2wvyWg7om+HwwEAWxeJguXmpEDRQcU032pklxVdgWksL3 f4nhwgpI XHUMJp+fTHKnStLhIK6trmBuH0YSsvja/wKyCwCiiegYjpsy4ErI4CwqNAQqpCbeg78jjEL8KREtpquHuv2mL0paLv+ZYNKVus+LR7IaCA0QwDR2NRKV+FxSkeagk4UFhyJMNGv/Ae9bvO4EDyJrbJfetfStmGaNiJQOugUBWjsDArImakweyq4DSCaVZfEi3wWfDCQhLlMVweo945VKsn4P6+kaZmslOn7UUD3yAagNq3t9yFrz0p6VajOa8pleuKVUFXLoA/kQnb/2LU6a1bFYyk4CqSObajKgt0F2Kl+CPPa4S04S3jgbbCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/22/23 06:14, ypodemsk@redhat.com wrote: > I will send a new version with the local variable as you suggested > soon. > As for the config name, what about CONFIG_ARCH_HAS_MM_CPUMASK? The confusing part about that name is that mm_cpumask() and mm->cpu_bitmap[] are defined unconditionally. So, they're *around* unconditionally but just aren't updated. BTW, it would also be nice to have _some_ kind of data behind this patch. Fewer IPIs are better I guess, but it would still be nice if you could say: Before this patch, /proc/interrupts showed 123 IPIs/hour for an isolated CPU. After the approach here, it was 0. ... or something.