From: Dave Hansen <dave.hansen@intel.com>
To: ypodemsk@redhat.com, mtosatti@redhat.com, ppandit@redhat.com,
david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org,
will@kernel.org, peterz@infradead.org, ardb@kernel.org,
samitolvanen@google.com, juerg.haefliger@canonical.com,
arnd@arndb.de, rmk+kernel@armlinux.org.uk,
geert+renesas@glider.be, linus.walleij@linaro.org,
akpm@linux-foundation.org, sebastian.reichel@collabora.com,
rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs
Date: Thu, 22 Jun 2023 06:37:51 -0700 [thread overview]
Message-ID: <d0ef9148-3c95-87bb-26f9-ea0920a4faa4@intel.com> (raw)
In-Reply-To: <79f29f99fa07c46dbaee7b802cdd7b477b2d8dd1.camel@redhat.com>
On 6/22/23 06:14, ypodemsk@redhat.com wrote:
> I will send a new version with the local variable as you suggested
> soon.
> As for the config name, what about CONFIG_ARCH_HAS_MM_CPUMASK?
The confusing part about that name is that mm_cpumask() and
mm->cpu_bitmap[] are defined unconditionally. So, they're *around*
unconditionally but just aren't updated.
BTW, it would also be nice to have _some_ kind of data behind this patch.
Fewer IPIs are better I guess, but it would still be nice if you could say:
Before this patch, /proc/interrupts showed 123 IPIs/hour for an
isolated CPU. After the approach here, it was 0.
... or something.
next prev parent reply other threads:[~2023-06-22 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 14:46 [PATCH v2 0/2] send tlb_remove_table_smp_sync IPI only to necessary CPUs Yair Podemsky
2023-06-20 14:46 ` [PATCH v2 1/2] arch: Introduce ARCH_HAS_CPUMASK_BITS Yair Podemsky
2023-06-20 14:46 ` [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Yair Podemsky
2023-06-21 17:42 ` Dave Hansen
2023-06-22 13:14 ` ypodemsk
2023-06-22 13:37 ` Dave Hansen [this message]
2023-06-26 14:36 ` ypodemsk
2023-06-26 15:23 ` Dave Hansen
2023-06-21 18:02 ` Nadav Amit
2023-06-22 13:57 ` ypodemsk
2023-06-23 3:38 ` Yang Shi
2023-07-03 13:57 ` Peter Zijlstra
2023-06-21 7:43 ` [PATCH v2 0/2] send tlb_remove_table_smp_sync IPI only to necessary CPUs Peter Zijlstra
2023-06-22 12:47 ` Marcelo Tosatti
2023-07-03 14:09 ` Peter Zijlstra
2023-06-22 13:11 ` ypodemsk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ef9148-3c95-87bb-26f9-ea0920a4faa4@intel.com \
--to=dave.hansen@intel.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=frederic@kernel.org \
--cc=geert+renesas@glider.be \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=juerg.haefliger@canonical.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=ppandit@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=sebastian.reichel@collabora.com \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ypodemsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox