From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B28FC433EF for ; Tue, 19 Jul 2022 08:41:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D1DE6B0071; Tue, 19 Jul 2022 04:41:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 880D26B0073; Tue, 19 Jul 2022 04:41:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77BB76B0074; Tue, 19 Jul 2022 04:41:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 692A86B0071 for ; Tue, 19 Jul 2022 04:41:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 26E8A804DA for ; Tue, 19 Jul 2022 08:41:06 +0000 (UTC) X-FDA: 79703204532.11.6D8863B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id AEBAF180059 for ; Tue, 19 Jul 2022 08:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658220064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aCQLJQOHcJOJ8JmCqZRzHzMUpESxVjd3NNjhzKxLWQs=; b=R/vABZoAyzfqGaHB/XNLVLAiDqiExLVu5F36xrBYTuyvPTlzCirW7hHNH9QUVtmJONN+u+ b8Vt+OYKEVJsTkDz3Y8vHe/xCZdEg69ef1P4Kfwl5CJiTJwOo23UjgaKfD96FYyoCj6dAq Z+dLkKFEYMbd72ckknRiKgziFPkR+uk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-8GcE6M5yPf2JcxBX0pjY6A-1; Tue, 19 Jul 2022 04:40:58 -0400 X-MC-Unique: 8GcE6M5yPf2JcxBX0pjY6A-1 Received: by mail-wr1-f70.google.com with SMTP id l17-20020adfc791000000b0021dc7dc268dso2032018wrg.0 for ; Tue, 19 Jul 2022 01:40:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=aCQLJQOHcJOJ8JmCqZRzHzMUpESxVjd3NNjhzKxLWQs=; b=4vma4lMyDM6Ua+0mQMsgcGqOO0LIlP+B08/B/OaHS1YZwNpNJeNUTjNfrmm74l9zn/ /xaj55QRnn64nm2UsFDBDoRbV5dEymfjfa4/PK+RxrCDHXWz1o1j8/EkBP6Gdkaewuif X482cj28RjVOBbZtlMDlzaaU15dd3AKyo/hjwxSCCbaDiOqb3Jq6mb5PFAlzBVeSR70Z LKziTBRHU7G1lO6fwiRW6KKweO29IhhzlomIgW7AfDqgHKQur4YNSvNyf9TpTaGz8Jc5 wFIWs7QWpByb3rRQUiXjWLhm7B5QZnzPHA+GyH7xn6xw3+YU3y2BhEJJ8XFxLuIQ4xUk /LAQ== X-Gm-Message-State: AJIora8nVB6XQXaJTd67M/jalFe4UTxx32aqc249vwDLSETm9YjVLG2Z ocYjojrC9AVr/9MBic2Xk/wc1R88ktPSPAhLyBpB01s8FrGLrM6BpAu4iZTXlW1vYUFnmFWJN4a r9pD7zZ+/MHs= X-Received: by 2002:a7b:c381:0:b0:3a2:aef9:8df4 with SMTP id s1-20020a7bc381000000b003a2aef98df4mr37053743wmj.7.1658220057355; Tue, 19 Jul 2022 01:40:57 -0700 (PDT) X-Google-Smtp-Source: AGRyM1toW+ZoFXTJPEFs8reXmrBMtF0NaGli8q7vJKFZ+PCo4DXMfNrAYpetGiTuQdFEWq6RXg/h9w== X-Received: by 2002:a7b:c381:0:b0:3a2:aef9:8df4 with SMTP id s1-20020a7bc381000000b003a2aef98df4mr37053722wmj.7.1658220057065; Tue, 19 Jul 2022 01:40:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:600:7807:c947:bc5a:1aea? (p200300cbc70906007807c947bc5a1aea.dip0.t-ipconnect.de. [2003:cb:c709:600:7807:c947:bc5a:1aea]) by smtp.gmail.com with ESMTPSA id j23-20020a05600c1c1700b003a32251c3f9sm1833646wms.5.2022.07.19.01.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 01:40:56 -0700 (PDT) Message-ID: Date: Tue, 19 Jul 2022 10:40:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing To: Andrew Morton Cc: Alex Sierra , jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org References: <20220715150521.18165-1-alex.sierra@amd.com> <20220715150521.18165-7-alex.sierra@amd.com> <225554c2-9174-555e-ddc0-df95c39211bc@redhat.com> <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658220064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aCQLJQOHcJOJ8JmCqZRzHzMUpESxVjd3NNjhzKxLWQs=; b=dCpHo1OfHKkurwBlVI9xGWKlNiNnM7ro2f8LzGtu4eRaOnob0KaxPVG1aCC8C0OU4/iFDO 5QN2+tzItTA6+EzA3wAFoJ9kn2PGBm1YmueaByM/ls38PVn92//orbElk8Fx4tMS1Yg4XN 3TKJsqEOhY6AKWT5rqeIdZe7dtSwYmE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658220064; a=rsa-sha256; cv=none; b=rk6Xs5vHaFCVqSwDT0kRhAhaqtIfJrvIgaNHvLqVyXXMxrcANYf4tN/lDSuEF9tdj6WYEd CXAi/M3wz5tUXaJfhE10Uci8dlWrmPh7YI7q0pTIMwkI5uggxOZi7oT+lcJF1qgPYS9TVn JLdPs+naioGAD7b9WgbXxkNXCGTfNTM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R/vABZoA"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Queue-Id: AEBAF180059 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R/vABZoA"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: cz6me5gbdhbkqjazgo64bfdnwftjks34 X-HE-Tag: 1658220064-520744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.07.22 22:32, Andrew Morton wrote: > On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand wrote: > >>> /* >>> * Try to move out any movable page before pinning the range. >>> */ >>> @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, >>> folio_nr_pages(folio)); >>> } >>> >>> - if (!list_empty(&movable_page_list) || isolation_error_count) >>> + if (!list_empty(&movable_page_list) || isolation_error_count >>> + || coherent_pages) >> >> The common style is to >> >> a) add the || to the end of the previous line >> b) indent such the we have a nice-to-read alignment >> >> if (!list_empty(&movable_page_list) || isolation_error_count || >> coherent_pages) >> > > I missed that. This series is now in mm-stable so any fix will need to > be a standalone followup patch, please. > >> Apart from that lgtm. >> >> Reviewed-by: David Hildenbrand > > And your reviewed-by's will be lost. Stupid git. I know, I already raised my concerns regarding the new workflow, so I won't repeat that. I can understand (too some degree) that we don't want code to change just before the new merge window opens. But I do wonder if we really don't even want to do subject+description updates. Sure, the commit IDs will change. Who cares? Anyhow, it is what it is. -- Thanks, David / dhildenb