From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C9EEC5B543 for ; Wed, 4 Jun 2025 09:09:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A64EC6B05A3; Wed, 4 Jun 2025 05:09:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A143F6B05A5; Wed, 4 Jun 2025 05:09:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8671F6B05A6; Wed, 4 Jun 2025 05:09:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5DB976B05A3 for ; Wed, 4 Jun 2025 05:09:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4C748160C2A for ; Wed, 4 Jun 2025 09:09:25 +0000 (UTC) X-FDA: 83517144690.19.0D751B7 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf08.hostedemail.com (Postfix) with ESMTP id 45B4C160015 for ; Wed, 4 Jun 2025 09:09:21 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=NQBGTaBn; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=l7j5Wv3M; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf08.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749028162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iouDQszMKCKsF3mcyvCI3Gzro7EtcCyn1yOJiO9kUUs=; b=i51B4QRhP5YcfdlK/ZmTLUYJ+LAbjENzTgcNieW1Kul6lQ5j3Itx2/uLF1lVACMBgBP1Dt oAMu11w3qNp7lg57umR6RAK/gbHmbL4ASBzS8H1vah9Mvhakm2GbZtMJ/M1SqLlMp1yCZJ Cf9EfcFpQXe9viTU74ntl3BR13p9isI= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=NQBGTaBn; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=l7j5Wv3M; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf08.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749028162; a=rsa-sha256; cv=pass; b=bi4izZzPkDgK8bfc3bRsXRSiUuX2gNZbAyLxRmwsIs1k2TFFrDc6OOHajp9z2tAJd6G+Cw erahWkdtz9/ZWhWJgT6/Gntd2gtigg6tCa0a+dZuWEzOfGJzmzvzWgC3JFWdvtNN374EYQ 568mFgsCySlNXC3xiiFWz7Pvj9V/ekg= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5548fvfK016657; Wed, 4 Jun 2025 09:09:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=iouDQszMKCKsF3mcyvCI3Gzro7EtcCyn1yOJiO9kUUs=; b= NQBGTaBnA0wPni6PNq4aBqGuRCEwsE+pHYqRAe1auh/XxES86om9Ia03J2B/xuLY oEYgK0Qvvx0khUFgncC0GCTAiIBcwRGZIzsV1fQhnbqBD3zXn/rEf1QizhIO9SRQ ROTwnH5rHn2DpCobj4xT0QddIXcd2JUrHVPXznMETBWt54XA1IBxyyaou4APu2y2 jniYTvBtRvhX0n7DvsvQSeeQM/DRerLZxYXCv1AsEXEq2Oa4a2JHfO3440sGipQD 7oV43w1e3arWL1lvPVFS+NpL126tOzgVJso7YU5yqe6DoINmEnOrjYqOdtp9q0wa ED0vgIOejbQjttgwtjyZZQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 471g8bkh5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Jun 2025 09:09:11 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5547cM7M035048; Wed, 4 Jun 2025 09:09:11 GMT Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11010010.outbound.protection.outlook.com [52.101.193.10]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46yr7arpkx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Jun 2025 09:09:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I/BmmN7GDQUboygTb1pc4VQSvFFeLzkh4er6KtjIebjYZfcDzFwPKxxp6B4/FEVUmvjIZZsTxF5QXQSS+sexNwzoQQ1nayqaUlD+Yzzi1ufXB8NdS+Yy0RC3QLYbZrpaBUi8QigKhYqp8meD5gk/0VpC85hXTC35mjV541b1impAgZAT/3/8kk782KZQgEm3cT63La6sNMfLOwcASvqV/KEax+NF4GvRsZUAEtOJ21cjYalzWXsY/w3BMa1CZ20IyxUv9aglVwt8E94+O2vrIlqgI34gChjC9+Yk1b4HxvJdxkC03B7CbLabFUEtz7Cj5JNlAuia+W8GJDiEsmJ0nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iouDQszMKCKsF3mcyvCI3Gzro7EtcCyn1yOJiO9kUUs=; b=kgWXNVGMJx3sbr8Vug1cmKyORkTikv6/M891gV8pTI8ApXRpV2a/xPmJF7odsAPOYXDdkZ3Yyblbqb7EeQZBRT7ZvXuXxdBRxxUpE5n3nEcT+7FCddV7lW7DzA6MP5GP5z0J3IxwG5TyhhedWgI1xkKptk7Kb9vm+HcUGmfAj14QnW8etM+08cjjyo0ayxMrEtWKAhR0F4+J/J5qyEJdxi5l30gxS0U4T/jr5IhRRb6faP6TRd6hTSoJ/bN0EShirA5dCwZ2JB2EGZCabiOMtyI+hsYT3WbAKPL82MFjJs6LVMGjOofn4z5rM0yYJNQLm66pq5ssHwYSKgyRUeftyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iouDQszMKCKsF3mcyvCI3Gzro7EtcCyn1yOJiO9kUUs=; b=l7j5Wv3MtX9Vmed/K194BWSEz+OJNOEya6y8kZ4lvpSIQLCr8+w50Gu5FOQ6o5IyfhJ70jXlPeyqy+8uDNUyKBO7/TyYVyrSPKvfrXNANMgzPGUIJ/1tAgKd/LSWnFtlRSARodfer/gBebJ25d3ctNCXte6D3R/FdRSPWf6Z3kM= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by CH4PR10MB8172.namprd10.prod.outlook.com (2603:10b6:610:239::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.40; Wed, 4 Jun 2025 09:09:07 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8746.041; Wed, 4 Jun 2025 09:09:07 +0000 Date: Wed, 4 Jun 2025 10:09:05 +0100 From: Lorenzo Stoakes To: Mike Rapoport Cc: David Hildenbrand , Andrew Morton , Barry Song , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Muchun Song , Oscar Salvador , Huacai Chen , WANG Xuerui , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Jann Horn , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts Message-ID: References: <20250603192213.182931-1-lorenzo.stoakes@oracle.com> <51ec4269-b132-4163-9cb5-766042a3769d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0125.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::11) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|CH4PR10MB8172:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d76c73a-dd26-4258-58fc-08dda3477630 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dkdubVRnRVVwMVhZT2lxSUU4eUJKclhValRZemJFNkc5TldJd2RoemliVzFt?= =?utf-8?B?SGhXTnpWdXF3dG45TXVnUWlqWTJjV1FOMmdzdXdRVDBJUVIxbHVyQUpYSjdo?= =?utf-8?B?dlBWUTl4OTVvS0dBWGFoa0Q1TDY3R0NBNUR6ZVRjaUhrTWRTcnlDNkpqRXI3?= =?utf-8?B?c2JBUnFwTXdlUWR2Wk1NcldRVFdlMTd6c21jM3ozVUFlNC9RQjl5QVJab296?= =?utf-8?B?dE1zYzRnZS9xZ3BnZ1JlalZEZDhscEgrRzIyc3VHMmNvWGQ5d3hiSUZsU2ZT?= =?utf-8?B?cXVoTUxxbWFwU0Q5ZmFpTzdQeVVaQkZ4NE13ekNDYWxqRDZEdldiMUMyWFk5?= =?utf-8?B?cTM0OFV6U2U1cTZhemp6ZEFiVWRpMTI4VzVaZHdkVTl1NGNkdWJ3WHRUdzFp?= =?utf-8?B?am1UMW15dFZKSHhDYWhqS01uUjdmSWlORlJVSDJCb0Njam4zMjRiSDRsZDlu?= =?utf-8?B?UHJ5RHFlb09RTjBYNi9WZkc2OWp4NEhCLytXNHBCMzFsMlAwQ1pPTk9LcmhZ?= =?utf-8?B?U0M2NjVIMlVPSWx0b0h4M1IrOC9kWU9NM3JqaHRtOEswdk5VdEhwSzgzUUl6?= =?utf-8?B?Tysyb3BWNGRzcWRteEVDY1RCRGE5TkIzR0FSSk1ROXNMSFJZSWpzbTRFVnRl?= =?utf-8?B?bzRSditXNW1DZHhpMDc4RnhaSFdsV2Nxa2xiUFJTMS9sZko4OUJjc2VMQTlq?= =?utf-8?B?Z0t6SENVSE5hUW1uRzcwQklFTlVxS1FDa0g5L0dQRUhUVit3RWM0elJiOGN1?= =?utf-8?B?bGcxNEJsWTBSZWN6K25XbjRHaXlEb1hnSzlPZXUveXlsM09weVByWGVhaTRO?= =?utf-8?B?bnNFYi9yUmg4R3pURFc3VEk4aTJycmVrM3R5VVo2M3ZIZTFUZVlxUFRyajdm?= =?utf-8?B?NkN3Ukxobmg2eGYzemVkM2hlcVkxdjVFb1U3dnZjVlBhRVg5TGl1VWFXVXJ1?= =?utf-8?B?MG5DdlA5bTVXMm1STjFFVlp1alpGMDRHUHFwMzJ6T1NOUCtoWUc4d0FtYTd0?= =?utf-8?B?S1RvWVFMZmFTRWFmNHc4alppaElFV1l2bUJqbnNMQWNuMGpJc1lSd1NjNWFS?= =?utf-8?B?Z1pCQUk1eHRrejNWWGpPS3VTQ09hQUtmS2x2bDFOQ1U5ZmhhUzBoMTR4aXJP?= =?utf-8?B?bHNiWWFZSHJWZ2F5UEpzRDhwN0dIQ2ZhTmJSakllbElxWlVNUFBhcTdPVzVl?= =?utf-8?B?dUhhYU5KOE1DeHl6T3ZNeHA5RzI0Y3RNUVlZQnpldWVTNVBaRE5zMFlqS0pB?= =?utf-8?B?cWtHM2JnTWoybXRrd0lsa2VPTXQyQ3ZaOEkvTTZ6YjJMLzVZWC9JakVNenQ0?= =?utf-8?B?d2lkY1FMTXhyeFZRdVU4Tm9Id1RaaUNIaUIzV0o5L1cvU2NXSUJvcjI3akRY?= =?utf-8?B?QjB3RFFTUWovc1RxdVJWalUvem5ISDNDOUFNZ0RwODRkQkk5UlBYVFJlZnRG?= =?utf-8?B?em5XV0ZPeFpEMmZHd2t2bk0xQ2xhUW9kTmZ4ZVN6UXJLRW1McVJmbmtKOS9Q?= =?utf-8?B?VXh5Ym5hM2ZXK3Y4dlVQKzJRdkZmYklRUGtENVJQTUErcUNHWGwrbEJVc0RK?= =?utf-8?B?aVpFS0t4OHZNTldXcWNWdUVFaUg5MEJaOHZ0ZjdmcDlCczAwa01vNWRyTUNG?= =?utf-8?B?R1VXY1RZUEFuaVl6OUdYZ294Q0l6aHBZKzh3UWZ2S1E5ak5pNW11OStaMG9w?= =?utf-8?B?VjF3WjVac3NHdnBOc2dKcXR1eHpUeEx1bjJiU2xsak9oNGwyU3BZT1FpRWh5?= =?utf-8?B?Wmt1cmduaCswSTQwSFN5Ty9YRHdiZ3pIWWhRMlQwM0ZyeFpKSE1EbGJTbnp5?= =?utf-8?B?K0k1cXVOMHJSQ0RiUGlnbEVyUUhSenowQWdWYTkzdk9vUXJFeGM4NWZnWnpX?= =?utf-8?B?cUJpK0xrMVkwVjNDYWFUUkxSR3F5eHRleTJlOFZpZkFnY1dpeTQyQk9qNm1B?= =?utf-8?Q?E1/ZQieiCBU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWdNQVJ6Z2tPR1h2bVdCTDdlMWJzajVMNXE0WjZ4alppbVhqTXY4bW92U2tv?= =?utf-8?B?U1ZDVFhtanlLdkZCZFdqMStwV2dQTjBBMit4VmVQSjdwQnFFdjhBR3FTN0Ry?= =?utf-8?B?YlR0eVo4dTNoSHdBWEdJaW4vNlorOVd5c1BkWGJPSzJoOWM5cUxsQmJBQkFX?= =?utf-8?B?YkREUTNkZjhScm5OVjVxRjJXVmFuU0pCTExpT0xubkIrbE5rZzBkRnBQMC9S?= =?utf-8?B?Wktoa0tlOUlxYlIzQ3FuU0FLVXExaTQzeHJLSm82d2hpRU1MMUpwZDR3SHZR?= =?utf-8?B?RU9rTGJpK0dvRGFqQ3JFazdFdkJVQVB1VlZyb0UwUWZSaEpQQ2NjZmpxbFpv?= =?utf-8?B?SEsyblhTdVk1aGEwUGMyU1dib1ZxU2ptNmNwekE4azQ1NUIxTzRiN0tMTkwr?= =?utf-8?B?b2w0eDNVRmcwY0FaVk14d2NTL3dBcXZWVXBLa0ZHQWFkTW9iVXl4ZTBFSGFU?= =?utf-8?B?VDQyUzg4RWFCekdWSElHSEUvVGxyMzdkMVFZblN6QlQ0R04wQVBLZXJzc3Zl?= =?utf-8?B?Vk9TWldRZUVUVUtNYUVaK1luS0pzZjNLWUNSNTZmZ25kMjIvT3MrNjV4dkVm?= =?utf-8?B?NDVURFFVR1pzTmhyS1NtVEJibG5xWkc1b3ZQdmo3L1UwWXBHejYwa3QrNHUy?= =?utf-8?B?Y3kxcG43T2xOK053UjhpN0I2czZ4OC9vbU5YTG83Z09CWmtYb01QOVNxcjVq?= =?utf-8?B?ZUF5ekRlaldXLzczbjhZWEJLd3ZDMVl2Qy9SenFiWnZIejd5UGlFd1BGNDR0?= =?utf-8?B?SGpsLzZwSUVBSWtyRmlmeGRHZE5YNGFBL3hTcjByWkRrc0tLM25JaTFveFc2?= =?utf-8?B?MmVnRHRVQklKTjBzK3lwbWxmcE9VZ2hOWW9HdG16VGlaR1VhcHFEVmJtbFRz?= =?utf-8?B?bTcwNWFmOE1HaTF1UG9qZzBVaFByQXNNb2V5WnRBeGtVUmVNOFY4TjlXcjVW?= =?utf-8?B?QWZJUDhWdXZ2V0c1YnBsUzhsQWIvWk1rNzdXNWVKRzd1N1F5TnlvQWtQdFdm?= =?utf-8?B?SHRUbVZIb2twWGlnYWJ6d1JrMWppdGZrOXUwcUZIMVhVeXJOMzlOMEFjaDRj?= =?utf-8?B?aDg3U21BYUdLS1RsejdJZE5LMHNnR2xUN2Q3TmRVU2l1VzBEMmkyTFBkU2Rl?= =?utf-8?B?L1pSNU9mL3paVlZ3anE1K2FuRDVnYVdlOHlrZk9MR0I5M3k5UUhzYlc0UUJv?= =?utf-8?B?cGY4TVhkOVJadnA5QTZMeXRyTC9uTVJGRjVmTmVqNTkzUEx0b0xGWGpUTTRq?= =?utf-8?B?a2xrMnBWVmlobnZHYW1MNGpnR2dldFJzUHZNS01Wb1VEcS85aWh2cCtiQjRx?= =?utf-8?B?MndYYzBBL1ZBUjNtV2hyWEx2TWJuS2xMM1VxWHFRQWc0V1dRSGF0bVgyeUJy?= =?utf-8?B?MDNobnFkSkRRT3RvSmd5cjNFRmZHOGhiSXp2dG8xaWsxT1BmdHQ3b1VtUHV1?= =?utf-8?B?OE83dm5kTjlPVkR3Wk9kTExwM3FmQWNLdS9ZZnB3Z3o5ZzVzRWMrMUVCa3NE?= =?utf-8?B?MGV4WEJQcHBZUXRjTllnVHZ3aVUzcFFzcENQVzU5WjJzMDF4N3R0UDFMU00z?= =?utf-8?B?OW05ZTVpMXV1WkNXbEhPcEQ2R2lKUGY3YTR4RGc5SkRTWGplSG5iSUdoemxF?= =?utf-8?B?R2VpOTZlZ3VzeHlKTjFWRzRkSU50T3cyQXh3Q054cFp1dHdSQXo4UkpTc2hI?= =?utf-8?B?M3hFNVRYZ09kbE1YL3VUVjdTUTBNNTlJcDBSelFOUklKbUsxR1hDaVFJN0xy?= =?utf-8?B?blJzVTcyemJaQ0h5VktNejNKampEOENJYVVGd2wwbFp3SnYrQSszeVFSVnJY?= =?utf-8?B?UkFRUS9XTTJaSGpZM1JSN2RYMWlnRDM4T0FkUkREUnhJZGwxUnArRzZ6RzVY?= =?utf-8?B?ZVA0aS9iaEswK3JsaGZhVnBJUndkWDFoSFgrSkZoMGgraUVYVjBJZEJqVElJ?= =?utf-8?B?RlRGSmFDa2NKWGgwRHV4S1ZXZlIxMXBZalRTSC9VSGRqOEFHblV5WGNVS2Jq?= =?utf-8?B?dEhaL2hST2llMmo4ZTJoTFR3Wkp4YUZRSzVWVjBMeGRzLzJsWEZlZkpqRG9p?= =?utf-8?B?RGpoM3RVZHdNTkh0UHhBVytQb3ViU1BxUTBOQTl0cUpoNy9VMFMyby9PSGo0?= =?utf-8?B?emJoOWpKZnZYZWw2TTFHVE9TYWZNMWFYZ3p3eFRFT1ZvdFpmUFRNU29rYnh6?= =?utf-8?B?NUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sLy76Ylko96S3QTh6c6u/DJHZv7rXh4J9ka8PrKCYxyBGm1B1ZDVagLE0gHQYBOW9e76cdzo69QPXqw8CCTc4sqk4/xThCXUmMYFr1WBIEZnEkZfvo8i2Vb4N0sNv0jAKPlYQG9qq1a3ZouP1guiTfVZIJOmtV+aZ/VW5EgWyr6ZQZq7Bsux4uWDbIfYt/0Yq5Y2Kr7ar+nFxTn7xF/AwWqaGihr84SCv1PZ2NS7U9uAhs3XdCCAirnUR9RqibPPr7H8JW6mCMhKK5z4UJ14UCdDuUq0/Ij5p6zXGnY1Mv2HYA3JJDKjPgHWpjHrvymB+CnksdSh4oMZ63IRTf22VxrDcZRT+e9oGundes2B2zcAzO7m7w9r9vproNhW0wxoNQzngBzTlNze1f4/ewQvgX4vFDuwNfIXIeemE4EUyR+1sc7/Z5OgTqGVdj+WJcgWo4EA7MLPwZrzUnPWR4Z7qPQ5wwLzNqdpQV2LRd419HMdIRzR9+oLQ7eZM8usrHieJHx/vXAIezIUYw8fCR0dt9/7JFlrrWNnfhEWXqpc5Jx7l3UM8bYt0SUApjGC8wWcWJXU/m9E7IiE46378VUzF8mBzzonUwWFf5rfU4DI10E= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d76c73a-dd26-4258-58fc-08dda3477630 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2025 09:09:07.8250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8rxLTn1jZmmWZDqz9URH2mNyEUBS2wILwRBGKAg4Bc0t+65v7yKGWJV63E4cWdQ19pFoEzPiquKoa4gPHiAWpbay8Ico0rH9dqaDJzWhRFE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR10MB8172 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-04_02,2025-06-03_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506040068 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA0MDA2OCBTYWx0ZWRfX1j4+LqZBi1Jz PumaTi/LhooNLsNSesDV0FLZ/7uxzdDLZ3KzsN1UnaWhJ/u61vIKqkEyzxmoN1sNb1DCnZvECGM UUo4Yij9wjYzw4nGx0id57Yh6XNRXy+zPJvOPn4ajQ0AFw6m76OsJHfR4lQw6NPTTvPJiHd11X5 Z0wR8i80UwKYlphKwRv4MhHT3qn4TDB3yvuaaBDvjgW+vrdBk7uiCSNgTq9/JTO2ZM9sqsHiLsK AB0XaegOLMhwdCAE7nxGRicr+SXOeA5J2KtCPDSjSkon1VlmxbRFkXhSD/of8fpHgWMx469hHQZ 5bSJsEkc+Jh2y0CJvZVzWDHdTuWoqKpE9nGw5PNz/qR7ZoRZFujAq3AQ6PUnW/YQGvE1YFvpnwv RNxGJM6g7MY6TQPwLqH+qzsyezI31cY1/aTPixxpoXZec94BpNWOay3uVwGOkH8KTJF9BnPK X-Proofpoint-GUID: _VDAj0O3FRYl4O0niFlizuPjsSVhawDD X-Proofpoint-ORIG-GUID: _VDAj0O3FRYl4O0niFlizuPjsSVhawDD X-Authority-Analysis: v=2.4 cv=H+Dbw/Yi c=1 sm=1 tr=0 ts=68400d37 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=csIp8JxmIs3qLi1_xkkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Rspam-User: X-Stat-Signature: akws9m6ixytnzwuxjiyd58fy6usdxnjb X-Rspamd-Queue-Id: 45B4C160015 X-Rspamd-Server: rspam11 X-HE-Tag: 1749028161-853797 X-HE-Meta: U2FsdGVkX19BbBifXFp6+vb8zXU7lcaBZHIKGgZtvWmb8flshOwAq7LO9F2RriwYwCrzGuHlHFsBfIKGC3DRAe0k+wHSmHAx931T3PLgci7EgsiKKMWhmfZHiC8pZ6JblnjekEoHUWWm/Ian2TGSl43wHa6qiJ7g72XPSHSZ07VcsozsWDUkDSQwR7AorUThMROQ07N9hcCJ3EABRupnZY0J4RP5xfFLv2yz9qZ21cftllrl+soumTkogqSv6mDCrt43IaW5xiFkcnH51lWHqjOwINL7wsXE0CeVGIvyMvroRNpCmyfI7GQUHGESOPYHr81xJpjuQ6a7py3xqnmfCHI6LqZWKPer9XA/+JQTUTTgcDERHa/NfDEJguseeP8W8VXOCkJfGR/1l1v+j8+Wm421DfceLZsPStNVsp4qGhiI60Yc+NYQlUSB5EbsMLWHUbJcrN88hmDKY2cVRnTb51PH0a4Hw2HjwPTnsx/D40dks4wHP5d2x+CSLn+tjP6iHbgF1i0W2jrw642XRDWWq8DPcC6/FSatzi4b4dwJ8W5HAr3j0H+/MKc8v9azAjG9DPN+lt5CQ8PRvF9Y9flv12QqStkgcOvqmflAdnliclB58RRlkUL0smEGnpWJipDqGJiBaRRdQbUGqPcS9hySWjzxhhnsPri5K4IGRn55+VSW9nG1+Yxxp/xZ3XXPFSI3uyJr/VEsY973HXuXWoM+edhkDNJ1E1dteERSUMf9Nj+1d1fySm4jRjsqZHQaF/SMd2UvnxCQAuof0aNiKoRRPPQ6zCiPTdCXVdagcF2m0rv9ZhPjw/r67Wsd1WhXFIY5f6q4PnHJtPutARKOZrIuOd7bs+Q7K4GYb42HixdWSEMVaMFRsBBL5YhQtXmrCQbNJArdasRsGDqWNceC6v8kXF/7PkDwrab5pKfQ07H7+c9naVQuHPRfkwk5n90lt+rRmDQ4N/1sUdvk1inSGjq uGjHJlvn 10kEchbvQyDU9Eze+kyYhSSVh5JHN4mBYzoOBzV+WLiCWnWuU26siz5ONLsqc7Nu3CyblV/LBYgAeofXfI9SaYdR6xZBO6OOMaw/kL9yhwX0t+qL33aOQbGp812ETiVLnPV6sn3GxGT2/8dwCAr56EGRf9iSnYHaR0bxTzUFeUWeoqlshZXDXVZMU0VZGhWQqKtTF+9lcc7IpFdAKVCuTcZORv1oMcWUwNQbW+KyQrTUUpddeVFi2Xm3OCUgmfKAf+EbpBInmeVE1LOWkRuES1WGF/ELmKRTmZrxPWIDpuubJqpwtBNs5BZYVA5onJOXpHWqUC8CxmbhYwAcB5aR/3dh5/q9DAI9c/xW1ens90zNJ9+acRmCDGGjdF/AM9+cnn7GcNZrlURE/QwzYJn8105TthXeLCC5TuTqNhEDDeNe6WR9SpX/JeI86aeqZex5tgNnoxtVluV/SqyahMMeDtcCfGcZjTCJWnJCpxDJznzL4lafYHLyIJbFCjt/6NRpeqeKDd3uUXk9ZTPx2Bc1sPmPNn9BDbfT9XPXeRKtMVb6Qz8x+HnQprYvydm+MI3Qg83NqhEfWUCcPZ0NLQycG3XWCgcXuXWTwGBwr1L5R/IFExtKhK5C4Yhky2YVYLXXR0PfTsZQ30bmIO1IDaQ9C03E8lUTLeAr3TljrX7o8tvhTUhfIG26AbSQSK2j8uTfdv1UZrNL/D5KYUV/NmevwiPjWp+PrDnRIc+xkGsuqqI95MUxKVnToDZmP7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 04, 2025 at 11:07:05AM +0300, Mike Rapoport wrote: > On Wed, Jun 04, 2025 at 09:39:30AM +0200, David Hildenbrand wrote: > > On 03.06.25 21:22, Lorenzo Stoakes wrote: > > > The walk_page_range_novma() function is rather confusing - it supports two > > > modes, one used often, the other used only for debugging. > > > > > > The first mode is the common case of traversal of kernel page tables, which > > > is what nearly all callers use this for. > > > > ... and what people should be using it for 🙂 > > > > > > > > Secondly it provides an unusual debugging interface that allows for the > > > traversal of page tables in a userland range of memory even for that memory > > > which is not described by a VMA. > > > > > > This is highly unusual and it is far from certain that such page tables > > > should even exist, but perhaps this is precisely why it is useful as a > > > debugging mechanism. > > > > > > As a result, this is utilised by ptdump only. Historically, things were > > > reversed - ptdump was the only user, and other parts of the kernel evolved > > > to use the kernel page table walking here. > > > > > > Since we have some complicated and confusing locking rules for the novma > > > case, it makes sense to separate the two usages into their own functions. > > > > > > Doing this also provide self-documentation as to the intent of the caller - > > > are they doing something rather unusual or are they simply doing a standard > > > kernel page table walk? > > > > > > We therefore maintain walk_page_range_novma() for this single usage, and > > > document the function as such. > > > > If we have to keep this dangerous interface, it should probably be > > > > walk_page_range_debug() or walk_page_range_dump() > > We can also move it from include/linux/pagewalk.h to mm/internal.h Yeah I was wondering about a rename actually, but then thought 'oh novma kinda fits blah blah' but you're right, this is better. Nice idea to move to mm/internal.h also :) I like this... Will fixup on respin > > > > > > > Note that ptdump uses the precise same function for kernel walking as a > > > convenience, so we permit this but make it very explicit by having > > > walk_page_range_novma() invoke walk_page_range_kernel() in this case. > > > > > > We introduce walk_page_range_kernel() for the far more common case of > > > kernel page table traversal. > > > > I wonder if we should give it a completely different name scheme to > > highlight that this is something completely different. > > > > walk_kernel_page_table_range() > > > > etc. > > > > > > -- > > Cheers, > > > > David / dhildenb > > > > -- > Sincerely yours, > Mike.