From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EE7C77B75 for ; Tue, 16 May 2023 10:52:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EDF128000E; Tue, 16 May 2023 06:52:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09EB3280001; Tue, 16 May 2023 06:52:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA88528000E; Tue, 16 May 2023 06:52:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA565280001 for ; Tue, 16 May 2023 06:52:22 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A28A01401C8 for ; Tue, 16 May 2023 10:52:22 +0000 (UTC) X-FDA: 80795804124.18.B67C39A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 78B1A20004 for ; Tue, 16 May 2023 10:52:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d4GdjEcn; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684234340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZNW1JTsp2+TJANbu5HHxgt8Gjvq1fykbhirooX/h10s=; b=b/kin21IONdyFw8bBB88EsZOajj18aRjzwfHBotEIJCr8ccIwhDW0i5Q7aYLk6YVPVMqy1 5MK45+KAo1Y0mzQQb5ZmaDUWwsCiLNSGlA1OUgkAaoTWyWtZ2qto/m2IhOqw7Kk/N1u2k8 +tmpcZqOFCa7lOBE4xnXj/SliTXmDy0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684234340; a=rsa-sha256; cv=none; b=4t2nCuurYAk3g3tZxc00m2VEnx0ckQGQ8eVksz9vopoiXJJxqG7nS08AF9Jx75lphRTKx+ fo9LmVMfKm17bQQ+Qikn1QuCpBXI+4QsbX+1MPUkn//AIwMJRbbd+BrP0S/LKT3A+QD9HG 0Z5gbJnpT7Z92QbR1duft5qFDTD/+Lo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d4GdjEcn; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684234338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNW1JTsp2+TJANbu5HHxgt8Gjvq1fykbhirooX/h10s=; b=d4GdjEcnOguLIhzVNUYuiq7G/ol80tnCD0fLVaNZOPxKlUI/fScTa5vbAcYVJhV/Xi6tjB ETkAzrTaYjM8G0QDmt9ZY2apoMQCB3agy9GXGeSQ812Q+qU/I+Yi2OZO4SwqxknFJTxsFE kD1gkl2hMBCQ94RYfS06O0kvgUQdKsw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-LCLufdzaP2ePkGppZ6-HmQ-1; Tue, 16 May 2023 06:52:17 -0400 X-MC-Unique: LCLufdzaP2ePkGppZ6-HmQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f426ffdbc6so57764725e9.3 for ; Tue, 16 May 2023 03:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684234336; x=1686826336; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZNW1JTsp2+TJANbu5HHxgt8Gjvq1fykbhirooX/h10s=; b=DRSV3q0XhZGRWouwxdx/d7olhYjUt50U/7zXejS35v1rEU3qX56I+a14788Q3C3gAJ AJ3JxRpN0ir/LjHFGy3O/eH319hQxVpkVwSOijURHshFfdh6d2ALKJ66AaJ3biwJ67+A 0WsDsSJkIIL47TSqAXjcWih0rPiaWEReFyqH4WhXpHuRD+IKpemJDiZby9cAIjJlHDlY 4DD9ZFnJ7SjjYgWeum4QfNitCbZJj/lRGCY5IHanWg/moBug9Lyj4Sn6O2h5IpZzKT3j 67dlh8+T/967/oktpHFE71UKZMyapHiM5rc/16SchoPsULF8abJKLYiK5lW+pIXFs2PO sSMw== X-Gm-Message-State: AC+VfDxgXXKnhfkJS76sinfY+p0AT0nzyzP7ny84zyFMVFrXoqM21WVr L9Eb2Iem40k6Zue2QftS3KG06gew56nPNzizOXQHh4d+3+XO+e2cRjwuAGrxRLwroFJKAU9th+t +zkg63bZqiK4= X-Received: by 2002:a05:600c:21c2:b0:3f5:b51:12c0 with SMTP id x2-20020a05600c21c200b003f50b5112c0mr4190051wmj.12.1684234336427; Tue, 16 May 2023 03:52:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ411ax2ykjjiu2vkOAsMFB0UarxZmseD9PwixRDnspgDaNLVg/LUhk10UNMtZRjflnMCr4dVg== X-Received: by 2002:a05:600c:21c2:b0:3f5:b51:12c0 with SMTP id x2-20020a05600c21c200b003f50b5112c0mr4190038wmj.12.1684234336025; Tue, 16 May 2023 03:52:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c74f:2500:1e3a:9ee0:5180:cc13? (p200300cbc74f25001e3a9ee05180cc13.dip0.t-ipconnect.de. [2003:cb:c74f:2500:1e3a:9ee0:5180:cc13]) by smtp.gmail.com with ESMTPSA id b4-20020adfde04000000b0030632833e74sm2195140wrm.11.2023.05.16.03.52.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 03:52:15 -0700 (PDT) Message-ID: Date: Tue, 16 May 2023 12:52:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] mm/secretmem: make it on by default To: Mike Rapoport , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230515083400.3563974-1-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230515083400.3563974-1-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 78B1A20004 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: j5563af5zfjr9wqxgwhtssfj67iy5tqx X-HE-Tag: 1684234339-900234 X-HE-Meta: U2FsdGVkX1/QsZ0ZFRF/kLWh/E5YH6Zv3q0RUB3HPfIkHUQ8o/LxwgH8tAwP+o8IMH9DnVQy0YxHz5KkmOVn54zv1fBECHLHVtmTyUvX1EX1eFaF6z+XMMFc1kAtzU/o9r58ihK/SL37pel0KK23VJxZZSFzFzc5ifjgQAgnhiaaLuwciWDHGuEsNttzUXg8gz6ZTgnGCN/Cfz7Rd1gvVPB2013inblyGN89EdUAxwH4q9OQ1k6shMOXVgapM6go6vRdxvAezg6JiXybiX0uTKiodXbcn1mXZ5rlCizsxPKpNrxZaZUrwRjS9kpBtBIsbzS3a04dSMURxde2xdDIppTM9UH0ak8Y0J7zuK2zYdSAHli/sgb411lMBKNPMysLJb6mH2MVX+HoNDril8vX1PbSJxs9TSjDDuYeCc08iGqi0KwgNC0ALXkes3W/y6sY9YVzEVtRwcI1+lB7NP/i1z2C0cOEXmQOvU5+Y2mYa8xDoHJEh2vEm9DCqMDrR1E6NuqHntLsLsnr2fpTiilMLhcCEHmK7LfjWGcV6yFtcXyuMjxVZ0fRxBr0poSOUQjESmOAutn2IPyoatygpaxua2r2Bt1FPOUgWUTm9Cps+VO7LZ2qgMeK0IC4yURvbDAND35+I4m1Goht9Dco5joLtBNuh2VIR027x7NNInqCk/JUuZwBs+cdJN29uxROouN5Lwq0BB8vuAMbNPOCfwpKPmcs4IT8kO/U3Jaz+1L5tgNZxCZkPFmw/8AGugKPXNMX+/DcGAnfcJcDOMJ54gV3eMP3U6bey2TtzY1Ujm9e3TYt1QTg3SLqeuzFVy+ajqgoAIqNIudI1Mn7FFuVZgG3FmShdJUpHxB1jqMleBl/L/kCOudwACDjcQUi6D7wJJ+OOupkGz45psU0bWb+8e7jsuF4jEJNjhCaFTQhWhggfYkGIzD9/8TemjemDQevlhWw8jIoo117JEsQvm0AuhA Ud/z7IQ4 TM7GGfD7s4bwfbbS93WZPr6JQYtrHULZbbij2464Z9R0K5KqCRc8wjEvzBnyYlfufqxEWpYzQ8S3Eh7Dxr2Xal3jq/EFY9morRXiS33Txv+LtMOT+KtY7B2GFxYNh4MLNYwrKtfnpsND8c/KtWaE4hLGEZ1XR4lbIB+5sYwOWCJAfhihRi7BI5ewzm1dtLV7H7l93qDWuerVVgKzHVoYiViFiIIK5pA1vzAlhs9etSx5Xqk7Ibh9qL0JnHfTNkXup1fQyd06Z6Kv3jwDUlcdHEkYA36ELtr9u1RXmoLx0MYKf354HzJfwnuXQg3hVPDyFp1ej+TiJCwZH6e22FJNmvtiWEcrRJVOjv5+p8le1AMqQq/zYuELKigb7Sq5Df6mgYeRhCg0ClziwN+xe7Z9/fYBMsttrpVlaqru36WKDZ31S6FoLxg7VtQt9j+BUelfzHg3akBgrmaTwRk4RvVBI0zzVmMMasYznjhQMX0TL4V0ybQQFsyCEz4XKiryJa4/oEwecoe118TCCzP4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.05.23 10:34, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Following the discussion about direct map fragmentaion at LSF/MM [1], it > appears that direct map fragmentation has a negligible effect on kernel > data accesses. Since the only reason that warranted secretmem to be > disabled by default was concern about performance regression caused by > the direct map fragmentation, it makes perfect sense to lift this > restriction and make secretmem enabled. > > secretmem obeys RLIMIT_MEMBLOCK and as such it is not expected to cause > large fragmentation of the direct map or meaningfull increase in page > tables allocated during split of the large mappings in the direct map. > > The secretmem.enable parameter is retained to allow system > administrators to disable secretmem at boot. > > Switch the default setting of secretem.enable parameter to 1. > > Link: https://lwn.net/Articles/931406/ [1] > Signed-off-by: Mike Rapoport (IBM) > --- > mm/secretmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 0b502625cd30..974b32ba8b9d 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -35,7 +35,7 @@ > #define SECRETMEM_MODE_MASK (0x0) > #define SECRETMEM_FLAGS_MASK SECRETMEM_MODE_MASK > > -static bool secretmem_enable __ro_after_init; > +static bool secretmem_enable __ro_after_init = 1; > module_param_named(enable, secretmem_enable, bool, 0400); > MODULE_PARM_DESC(secretmem_enable, > "Enable secretmem and memfd_secret(2) system call"); Acked-by: David Hildenbrand -- Thanks, David / dhildenb