From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4367C76195 for ; Wed, 22 Mar 2023 16:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5574A6B0075; Wed, 22 Mar 2023 12:49:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B9296B0078; Wed, 22 Mar 2023 12:49:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3597F6B007B; Wed, 22 Mar 2023 12:49:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 21CB66B0075 for ; Wed, 22 Mar 2023 12:49:55 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CF092120240 for ; Wed, 22 Mar 2023 16:49:54 +0000 (UTC) X-FDA: 80597121108.28.AC61091 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf04.hostedemail.com (Postfix) with ESMTP id 03E9A40002 for ; Wed, 22 Mar 2023 16:49:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kbRPgwUl; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679503792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MEWu5/GFLhV8akcwTy7V4t/iTUvtleHlpGhUKcPL4ls=; b=LHkUlCQATdMp3UjyGcAXSC6ZpNtl2k/LdBJ7kljqDeucPkxadGUu/0sAfA8wUFY4MSdR2J kIwurDHlKLFmoSZV+2G+NjikVStM/JILGS/HuwjckgNGXIV0n/ebgfPDLTwVTTzYtyuCxS bt2uvP6D70uLjPLTssSXUAhGCvWOx/c= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kbRPgwUl; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679503792; a=rsa-sha256; cv=none; b=YjhuelvSNSHJYj9BKeXJKh1BLB9Dhgr24F1iFSkmg0EGsecyNOaCJi/a9nHwZGUD5jjP0+ 4DhfXqbEDteR5EhAHoJ4Du4UV2x4SBEh4yuSzWaSUEOXLqI3wz5wnOyDk7FBnILCGEf/o/ M+nmTlc1OnwlNaZDcQAUAKDkJ6eV3ZI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679503792; x=1711039792; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PmlDxcsDFapOGbfdlWh2GWhkkqitl+2PBEpJ4f3MM/Y=; b=kbRPgwUlRt9c4l8olO9tnDv/JbpeHwxBeUwLjxbR64L2ljwJJ44yX6lZ U8ruaUCIRe2zch9VtQLTnD5t/xqxeWESGazDpNkUi8VVakg4KBOhUifos p2Xan5rbhtuOJy/+bWUD5l1eWfhCNremLhOOJfH2LqaTwjG8IAKIrENZO U+SLBk0fViIfD50Mx0KliwhvTOTImw4mvWjPL7NAE7KSRG/DygD+2/eOp jg9RfX9+9yDwzH1FBkIGFfYTuz5VG5nhbSQtvtG4lnJSlrYf9elxrxZk4 uuECUkGeJJemf9/fMotCsM1nmlFa+Bq6f/R2HUG6TE7llYivp1hD8il0f w==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="404159817" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="404159817" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:49:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="1011437716" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="1011437716" Received: from mtfreder-mobl1.amr.corp.intel.com (HELO [10.209.35.23]) ([10.209.35.23]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 09:49:48 -0700 Message-ID: Date: Wed, 22 Mar 2023 09:49:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP Content-Language: en-US To: Matthew Wilcox Cc: Geert Uytterhoeven , Dave Hansen , Arnd Bergmann , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, John Paul Adrian Glaubitz , linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap References: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be> <6320abf6-0898-361b-d5f6-bcc58306f55c@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 03E9A40002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: fpow96kna4ofpe3fs5bk5qahw9gmmo99 X-HE-Tag: 1679503791-943985 X-HE-Meta: U2FsdGVkX1+pka75SgS1yj+ESh8ZDIzOBSoRkrDk7SGSfxY6u46Yc2rY7mq4IhdraELlqJcj2gdr6orWs9ysmqS6ce8DHgF9O8peQeWdgRMlt0k+QOdcpKvwMxETw/6FNjj/20gjjpNmn9yh56DtGX1g8rijn5ZqwFEm21vP8TBZv7Ag2SIFcO+XzHumOwiUMS7t3pghD1XcJBeyN93O1SZQkto5UImlWcId/jM2lFZAPOIWb7LasEjq78RL3W+82pt0QXsfqYL8Hc0Pumt2lZpOkXuopS/9EIZBAvLZV9MzHKjuGP23Mx1P3Q/26ocFu1jC/I9JfHh+FZ5AjGN969SRV8Kl1cRfKw/zqaC1E3Z6TZ/7Tm6FS43Bbmj7yQ8HV/dPmzNfKK3DylA/hMp/9KH6TTxe1aBLNaJrqnReh5URIJU8HnqF9NxfiECjQPAgzFzoHHssZiKvjTuYK5absVCWi5sRxHQLMuHiZ9cD2cLUaXXGo0eC9GwxTyvfgYCd7jGef4pAgkUdBdWkw/B51ccbFaZPakEx4zy4YR8lnrjIp2Kx6iUiX/bDyU1EQ2XE71RwMJT5poC12jlNdCUOl9jkbKYdeWuaTMEh75yVpD3+ykXnvwdvv64EymauucmAAvKOsL3C3x+VVm8CxJcaj93qkO8sU/qOBw/UgmMq7rVHJN2ARtF4inSQkizx43jvh9vLY9HV9JD13/oCKIogz689x4hzEMrngs4Ny9B6FXFbE7kMo/YDTZHXFofSqOsTI1PIsRXV83NwW/EzG3IqlNO3lHC7NTt0SiXYtZxE7ZCUAa3CmSenjPdCp71y91NguooHKG8Mgum/7EcfxHHuDVYdd8ep6XlhJSOpoup+qSS6SFitS9xB2d+3ibuY7QVYhlSOcD2Lkdl5ydVnLbaA2zn3vES3JJZRHflPKCAX1U+fHWkqGtqKwcc6kM6MykFIS+6tesuCfpaKfOpml+9 61RejmbW aFNy7Cscils83lBxIkajqAdLwv6eSWawtSn4EyiMBBiY9ZIc8nAQHoEl/kI2xqJVXm2Ip6CCRLmlR+SZVz1ea+CNyUzB8k9w/avYYb1CF9EVKFIWRLawxmhiO9Trh8kPRryj+UBAvg/aLaUxEKaD2SEUOaEUnXtOmqhlpu7ObAV4F2vZcFuSBGtcyT+ClmVeXN1PAR0hlNiBiemCoXfqbkdPs3tKL0YVCBpAMBcWBHheKPpM940bEoXdlr1iS7ugXpvMDYQXth8XX1qyZsUkVT9BqzkejGtf6j9Vm1YwdlFvex6y3mkZ+7/0Bjl+jHtJJSzf/UOu7Wjtczrw7GXfy0gUviQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/22/23 09:46, Matthew Wilcox wrote: > On Wed, Mar 22, 2023 at 09:16:55AM -0700, Dave Hansen wrote: >> On 3/21/23 09:40, Matthew Wilcox wrote: >>> On Tue, Mar 21, 2023 at 09:30:59AM +0100, Geert Uytterhoeven wrote: >>>> -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || defined(CONFIG_SMP) >>>> +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP) >>> I'm amused by the thought of CONFIG_NUMA without CONFIG_SMP. >>> Is it possible to have one node with memory and a single CPU, then >>> another node with memory and no CPU? >> It's _possible_ for sure, just unlikely. The most likely place these >> days is probably a teensy tiny VM that just happens to have some >> performance-differentiated memory exposed to it for some reason. Maybe >> it's got a slice of slow PMEM or fast High-Bandwidth memory for whatever >> reason. > Right, you can construct such a system, but do we support the CONFIG > options of NUMA enabled and SMP disabled? It seems so niche that we > shouldn't be spending time testing that combination. On x86 we don't: > config NUMA > bool "NUMA Memory Allocation and Scheduler Support" > depends on SMP > depends on X86_64 || (X86_32 && HIGHMEM64G && X86_BIGSMP) ... which I think is fine. I totally agree that NUMA without SMP is too niche to care about. Heck, !SMP is almost too niche to care about these days.