From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EC7C2BA1A for ; Thu, 20 Jun 2024 11:34:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFC2E6B03BC; Thu, 20 Jun 2024 07:34:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D84B66B03BF; Thu, 20 Jun 2024 07:34:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB0346B03C0; Thu, 20 Jun 2024 07:34:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 941836B03BC for ; Thu, 20 Jun 2024 07:34:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0A5691A1A5A for ; Thu, 20 Jun 2024 11:34:10 +0000 (UTC) X-FDA: 82251058260.29.8C26D39 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id A66904000B for ; Thu, 20 Jun 2024 11:34:07 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GbH+06cr; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718883238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=48uMSb3XQmRcndFEBSyjvxLuZw9qFtbAeLLtQCpxcKw=; b=tw3ik11QW9L46bAyqvLNHP4Nn6JjHuGy+r2hlQy4UjMijroVjbZGcbchg9/bONeS3rKmrK 76Pe5d6Z911YmyCZPAQfGJKnrdiKt7sgXLplED2gSVsWhfLvkwNTJgT5r7r6sCA3mHJ0JQ oojFiGemxeNFDJqerFJSq4xNdUMmgdI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718883238; a=rsa-sha256; cv=none; b=Mhs5Mgtc84P+GlVJ+NZgJ7s9zz1A4qcEeDpMjbMDCv6DRJdvuSCagBpcAiJOHvfd2CzEUv 6/HIs/vZth5i4+ZzBE4hSqlVg05cZwIR8rRKUwSfQXt5vvLtOiOawAPVPcPv6ESrhda5SY i43SvqxgMX3xU5Gq7W8WIPNc1H+gpRU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GbH+06cr; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718883247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=48uMSb3XQmRcndFEBSyjvxLuZw9qFtbAeLLtQCpxcKw=; b=GbH+06crNlNHMBZ0qsMsGS4gucwL1CNP7PVzlpqpJ0lRLk8i9I7ywo7zx//5eTD6onK1eT VZ2NynldgsP16kXdq6kMkglDxU7CTt1mhXEYbi4sBMUXzJeWP+yYuX4ejsbt+nD9KZXSk1 NJx7waml2SMa/4ZZmetwV8AxoNueNrA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-JgH5UriANnOVRxBjHUEeEQ-1; Thu, 20 Jun 2024 07:34:05 -0400 X-MC-Unique: JgH5UriANnOVRxBjHUEeEQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42117a61bccso6370105e9.0 for ; Thu, 20 Jun 2024 04:34:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718883244; x=1719488044; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=48uMSb3XQmRcndFEBSyjvxLuZw9qFtbAeLLtQCpxcKw=; b=EYGEcPtnNwjUJJAHO5K1Enu9hei7a0olTG7kMjC9ihy9TRGn5OeaX/3K449W6Fu6TB g1ePHttQaH4G8PiUbyZddtVenv/XZwFfnnRCmrdz15FPAmAyLxF3el+51wVFiJTZADgg 2aXnRJBX2ymX8q/vIwxJMB/9zQvHjrgY58WaKZwF5hXDvXCx8M5IM1QOklNNxMk0MOho c3bC+1UxRgbqkoYT5pMZDjgDt8Hnv0SxeFCqBhn//vNf9T/AaT78rm1Ilir6oWIAIIYC lXB3UBNWhpMdU0Gd9KavovjBSKRl+sBN1dry7flnaEovE28C32ULjg7alcF84wi+/mQV O1vQ== X-Forwarded-Encrypted: i=1; AJvYcCVkOKrWC8jhfnCxQ+uVd3tz16rpkH/+lR33Kh2csE6vs9VrkqoxQoZq9hhg5t6JMzjZASNvTlCpD8bXk+gMUw2xw00= X-Gm-Message-State: AOJu0YwpCrX18gfhAAIB7QaEutd8z2SRAZV96vKSytfUgg3v3JVB+P5r /5ADQMJeAbvnNyHVfq742Xo0nMp2XIZToKZ8fvrm/g+pwNJBIVh2/QJTQcFc3gYCBzpIVzLU6P6 Cyo0u4KPkoX2GvIAugJuYsbEexHRy72B1QYfKb3/eoyTqe084 X-Received: by 2002:a05:600c:22c9:b0:421:a575:99c9 with SMTP id 5b1f17b1804b1-42475180a22mr35613615e9.20.1718883244490; Thu, 20 Jun 2024 04:34:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+gxLFhA6YR817ALtxUbcnfky/pm0YRBBStXqXm4QjjI7azdieywTSEVo5C7aQNuyXlKhmNA== X-Received: by 2002:a05:600c:22c9:b0:421:a575:99c9 with SMTP id 5b1f17b1804b1-42475180a22mr35613445e9.20.1718883243982; Thu, 20 Jun 2024 04:34:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:5b00:61af:900f:3aef:3af3? (p200300cbc7195b0061af900f3aef3af3.dip0.t-ipconnect.de. [2003:cb:c719:5b00:61af:900f:3aef:3af3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0b8f37sm22818715e9.1.2024.06.20.04.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 04:34:03 -0700 (PDT) Message-ID: Date: Thu, 20 Jun 2024 13:34:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org Cc: chrisl@kernel.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ying.huang@intel.com, linux-kselftest@vger.kernel.org, Barry Song References: <20240620002648.75204-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cpmj188okzxj9fpdgzuscgis3t6qj5if X-Rspamd-Queue-Id: A66904000B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718883247-828593 X-HE-Meta: U2FsdGVkX1+cXlK+3z8lfWb3pPKOPwQOsy6GaQEuQr02B3KGtMcXyNFOltuEaQT4MIaZ7Xfzp+5aWVWcEoXBrsueXXxWeAmYC5phgAWnRWR8tl08t/qy5kjqIRnGihBt2vLXII4f+ijNFAF/789duDoasosQMK5Z5cviRbgm6Fb3yNiGSpBjLeEpxqFDddkisg1rLSfX5s9UboQ+XM9UV1d9iJLGsTvUvuVh0mwcatz0gWHo+lS0CiePDsZ0vQxdZVINOfrH6SMcoCJpjI1igB33A6RThyyooM2t5XH41dN88gv24LeVIQ6l73GP9BAcyLEZyH/ofJlXSK8C7QXum4fTDFWPwOKan7ZflqHqbOt8RpPX1dDAobObynYFrApE3blxm6O/WjQ2V7LRm5IARNgWwJgv230Dibk6jy0Qfwg6bUB5izqkZwa33NDAHlIgaxNeum9t30xd7uRLtz+yLTvPHYOfyCdtCEMjYWRDwVzoPrIjQijVmqt+vPL3eS/tFFLD1HfjefvNEr4T2z+KiDjonMpVL/qs6GnyhETk6E/qYfvb6iGhsxsvLumtt6fO6F5654j/PrpLAESvtGCh6FdsoE2Ic6LB2Ni1g/ip65ZUuaU04o0pEKez2fl0f3vhXVIk48fcUNktrPk4rkdET5d6fWzSF5QxbYjlxFdlY262ysx9namnZ/wnBzxi+E6RNzkFlj3Afsi49ETLVx6sno2o9xFbEJclrm/XxOH9hMxDrJfZ/Y74+zwpRBqyXMSxsmY6OeI3XXT2K3tI3oXxvUxy1iwsN5ROaKabmVchmoYng8PDf5uXag7VN6cQAjV8Ubou+3Pj6BKSExGOJQuMV+hW59Y7TPl/g6/SFGP+S39r9f83fmX9OFWcb1ytrcmLYFiYDgOD4m1fm7Kqm56wSnzzrBgPxZwUxDdk7PRlt9i+vqb8P2sMn2/Oz6hQuc5XepM8QTXxaLcnUtyl+47 V1pZEjjZ ZJ9j7raZpgNrO/2fzA/oMR3HmaD4/uhtZxJXzcVY4I5XbWCP9A6avRUVA8SoIFYoTWDJnp9tbqj2i1HcT0oUv4OjN7Shw6aRmb8wAjAxSy2KsEs7dnW+uDcvFaNhfxpvUe4rg3Fd7Hp+N9gu+Lymg1ApXGXCb6BOCxyvwoC+4jr5ggCIZsPbFvZK9qMufYABkXIIMEQ07a2CtYH7R0B9ii1iqhe2OKCJju5NlYhCYtj2Cl2HeLVclbVnB7RqzEGO5rmV9rHlGcEdhntAqa3zoDWqfVGI2igVrlVdGwFiV5W5vp1GzHXuYtFuaMieY0W7Odn4TTFL0T3MvRrOYAMnCYJ8fM5EAFLqkN5e60XBGJTd0b5HOEP8kXhCukJ46gfag4+vmMqkZj/xjpdQw3C0ik3U4f6oC/qszhDuYkmshkl9n67o71WQAGjLwkHhXcUXsLMpfBpJm0LBsXtxjVjQpLV+NJoOUog0Jljpa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.24 11:04, Ryan Roberts wrote: > On 20/06/2024 01:26, Barry Song wrote: >> From: Barry Song >> >> Both Ryan and Chris have been utilizing the small test program to aid >> in debugging and identifying issues with swap entry allocation. While >> a real or intricate workload might be more suitable for assessing the >> correctness and effectiveness of the swap allocation policy, a small >> test program presents a simpler means of understanding the problem and >> initially verifying the improvements being made. >> >> Let's endeavor to integrate it into the self-test suite. Although it >> presently only accommodates 64KB and 4KB, I'm optimistic that we can >> expand its capabilities to support multiple sizes and simulate more >> complex systems in the future as required. > > I'll try to summarize the thread with Huang Ying by suggesting this test program > is "neccessary but not sufficient" to exhaustively test the mTHP swap-out path. > I've certainly found it useful and think it would be a valuable addition to the > tree. > > That said, I'm not convinced it is a selftest; IMO a selftest should provide a > clear pass/fail result against some criteria and must be able to be run > automatically by (e.g.) a CI system. Likely we should then consider moving other such performance-related thingies out of the selftests? -- Cheers, David / dhildenb