From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FB77C4361B for ; Fri, 18 Dec 2020 09:11:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDB5023A7B for ; Fri, 18 Dec 2020 09:11:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDB5023A7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 264456B005C; Fri, 18 Dec 2020 04:11:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2140E6B005D; Fri, 18 Dec 2020 04:11:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DB1C6B0068; Fri, 18 Dec 2020 04:11:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id EC7576B005C for ; Fri, 18 Dec 2020 04:11:09 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B13AD8249980 for ; Fri, 18 Dec 2020 09:11:09 +0000 (UTC) X-FDA: 77605833858.01.knife95_1f0877d2743c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 93A6C1005B1C7 for ; Fri, 18 Dec 2020 09:11:09 +0000 (UTC) X-HE-Tag: knife95_1f0877d2743c X-Filterd-Recvd-Size: 3126 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 09:11:08 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 18 Dec 2020 01:11:07 -0800 Received: from [10.2.61.104] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 18 Dec 2020 09:11:00 +0000 Subject: Re: [PATCH v4 09/10] selftests/vm: test flag is broken From: John Hubbard To: Pavel Tatashin , , , , , , , , , , , , , , , , , , , , , , References: <20201217185243.3288048-1-pasha.tatashin@soleen.com> <20201217185243.3288048-10-pasha.tatashin@soleen.com> <8879f12c-2aed-1615-1298-7cf9596acc95@nvidia.com> Message-ID: Date: Fri, 18 Dec 2020 01:11:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <8879f12c-2aed-1615-1298-7cf9596acc95@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1608282667; bh=3mPuCxRz8KYq0pwcFButq0DOd57iVq04TlvZG8ID//Y=; h=Subject:From:To:References:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=sMmU4YUHis88+7q8FOrjOMAnSAnAGKQ2GV412pBnkj07s0+IB6Dg0kzx6uXmT0FoA D9CtmbOLgNVPgEL4CjkpMgfDKZUoBsABCOj6FR/OT/Ayv3A7Mi/9K3LqDeVL/gVFke 11h//FrtmvBwAkHQd9dQi5uFLVyxVWtTN0/BFa3iWKJUUNLnLaN1+yvzelntj+5Qmb kDkaFu3PaOExGyCeNYrlZUXyb1rhU+0ACDWvwHnqWWBu/Q9bo/NUDFniBG8FrVCx00 pINgEsVY0Wx6JmiWmFHoZO5zfTsFHpPRXyi8VquTqtYw9OmKYL1wIDKPMQmV2kWytw vENCsi8xBVWIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/18/20 1:06 AM, John Hubbard wrote: >> Add a new test_flags field, to allow raw gup_flags to work. > > I think .test_control_flags field would be a good name, to make it very > clear that it's not destined for gup_flags. Just .test_flags is not quite > as clear a distinction from .gup_flags, as .test_control_flags is, IMHO. > And maybe renaming .flags to .gup_flags, just to make it really clear. thanks, -- John Hubbard NVIDIA