From: John Hubbard <jhubbard@nvidia.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<akpm@linux-foundation.org>, <vbabka@suse.cz>, <mhocko@suse.com>,
<david@redhat.com>, <osalvador@suse.de>,
<dan.j.williams@intel.com>, <sashal@kernel.org>,
<tyhicks@linux.microsoft.com>, <iamjoonsoo.kim@lge.com>,
<mike.kravetz@oracle.com>, <rostedt@goodmis.org>,
<mingo@redhat.com>, <jgg@ziepe.ca>, <peterz@infradead.org>,
<mgorman@suse.de>, <willy@infradead.org>, <rientjes@google.com>,
<linux-doc@vger.kernel.org>, <ira.weiny@intel.com>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v4 09/10] selftests/vm: test flag is broken
Date: Fri, 18 Dec 2020 01:11:00 -0800 [thread overview]
Message-ID: <d0b1fec7-cc18-68d2-c574-639e665c137c@nvidia.com> (raw)
In-Reply-To: <8879f12c-2aed-1615-1298-7cf9596acc95@nvidia.com>
On 12/18/20 1:06 AM, John Hubbard wrote:
>> Add a new test_flags field, to allow raw gup_flags to work.
>
> I think .test_control_flags field would be a good name, to make it very
> clear that it's not destined for gup_flags. Just .test_flags is not quite
> as clear a distinction from .gup_flags, as .test_control_flags is, IMHO.
>
And maybe renaming .flags to .gup_flags, just to make it really clear.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2020-12-18 9:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 18:52 [PATCH v4 00/10] prohibit pinning pages in ZONE_MOVABLE Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 01/10] mm/gup: don't pin migrated cma pages in movable zone Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 02/10] mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 03/10] mm: apply per-task gfp constraints in fast path Pavel Tatashin
2020-12-18 9:36 ` Michal Hocko
2020-12-18 12:23 ` Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 04/10] mm: honor PF_MEMALLOC_PIN for all movable pages Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 05/10] mm/gup: migrate pinned pages out of movable zone Pavel Tatashin
2020-12-18 9:43 ` Michal Hocko
2020-12-18 12:24 ` Pavel Tatashin
2020-12-18 13:08 ` Michal Hocko
2021-01-13 19:14 ` Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 06/10] memory-hotplug.rst: add a note about ZONE_MOVABLE and page pinning Pavel Tatashin
2020-12-18 9:44 ` Michal Hocko
2020-12-17 18:52 ` [PATCH v4 07/10] mm/gup: change index type to long as it counts pages Pavel Tatashin
2020-12-18 9:50 ` Michal Hocko
2020-12-18 12:32 ` Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 08/10] mm/gup: limit number of gup migration failures, honor failures Pavel Tatashin
2020-12-17 20:50 ` Jason Gunthorpe
2020-12-17 22:02 ` Pavel Tatashin
2020-12-18 14:19 ` Jason Gunthorpe
2021-01-13 19:43 ` Pavel Tatashin
2021-01-13 19:55 ` Jason Gunthorpe
2021-01-13 20:05 ` Pavel Tatashin
2021-01-13 23:40 ` Jason Gunthorpe
2021-01-15 18:10 ` Pavel Tatashin
2021-01-15 18:40 ` Jason Gunthorpe
2020-12-18 10:46 ` Michal Hocko
2020-12-18 12:43 ` Pavel Tatashin
2020-12-18 13:04 ` David Hildenbrand
2020-12-18 13:14 ` Michal Hocko
2021-01-13 19:49 ` Pavel Tatashin
2020-12-17 18:52 ` [PATCH v4 09/10] selftests/vm: test flag is broken Pavel Tatashin
2020-12-18 9:06 ` John Hubbard
2020-12-18 9:11 ` John Hubbard [this message]
2020-12-17 18:52 ` [PATCH v4 10/10] selftests/vm: test faulting in kernel, and verify pinnable pages Pavel Tatashin
2020-12-19 5:57 ` John Hubbard
2020-12-19 15:22 ` Pavel Tatashin
2020-12-19 23:51 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b1fec7-cc18-68d2-c574-639e665c137c@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=tyhicks@linux.microsoft.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox