From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A87C77B6F for ; Thu, 13 Apr 2023 01:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C95676B0072; Wed, 12 Apr 2023 21:42:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4583900003; Wed, 12 Apr 2023 21:42:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0CA9900002; Wed, 12 Apr 2023 21:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A18706B0072 for ; Wed, 12 Apr 2023 21:42:23 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 827601602CA for ; Thu, 13 Apr 2023 01:42:23 +0000 (UTC) X-FDA: 80674667766.11.67642C3 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf03.hostedemail.com (Postfix) with ESMTP id C19FB2000C for ; Thu, 13 Apr 2023 01:42:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681350141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+5MU00ZxakBjd22dAhdtOkZYOIJKTMw1PJTydS+srMQ=; b=47wAs7zSgbV3hu8/iPJLCHLyamMCcYUzyaDvfNMWJgqBudDUE0mQg2cysUd69zLriEd2j6 DNLVf4Ve3Z1WCiN39EPO9OYpgroj9MHO0zp8n9rnB2bIRqkvOLCljpMmcXCSr8RRAuEoE8 Q21+3ZdCgP5frIQG1I+xuHeBq+Ye0yo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681350141; a=rsa-sha256; cv=none; b=8VjaZf+ebEkhe+dreeIzTHLmZDq42gWg/PBWqCidlrKgSy3FZC1B0yvsxg3P5Hu9FsGsNF bxLvftowpPP2QBi4StOM3Io79hNdN9R3iIV402wzPfOqWW2mBr6Re3sZQZ6owzesV+WV+D 1YwAgB20YFwPccA/+BwcoNPyOshnJMY= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R401e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=23;SR=0;TI=SMTPD_---0VfyAdXe_1681350134; Received: from 30.240.113.14(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VfyAdXe_1681350134) by smtp.aliyun-inc.com; Thu, 13 Apr 2023 09:42:15 +0800 Message-ID: Date: Thu, 13 Apr 2023 09:42:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 1/2] ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on synchronous events To: Xiaofei Tan , mawupeng1@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, justin.he@arm.com, akpm@linux-foundation.org, ardb@kernel.org, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, bp@alien8.de, cuibixuan@linux.alibaba.com, dave.hansen@linux.intel.com, james.morse@arm.com, jarkko@kernel.org, lenb@kernel.org, linmiaohe@huawei.com, lvying6@huawei.com, rafael@kernel.org, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20230411104842.37079-2-xueshuai@linux.alibaba.com> <3dda3629-3623-ad63-9d9d-73706aacbcc0@huawei.com> Content-Language: en-US From: Shuai Xue In-Reply-To: <3dda3629-3623-ad63-9d9d-73706aacbcc0@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: ewrrzbznnzjmw7gukkhuxnkxb9n4hif1 X-Rspam-User: X-Rspamd-Queue-Id: C19FB2000C X-Rspamd-Server: rspam06 X-HE-Tag: 1681350140-704074 X-HE-Meta: U2FsdGVkX1/BmMNK85rzk2RnyCdeRY1vQiTrqGh0Rc0ERqDglZlnxqJEeaJ3kpHB7PLfLbSQ3BEKR89/vU+ugGODtrXqJKmn1UCOsh6TnSxQKI3e+6/Jes3ZiSY859qH68DiAzBOAD/VW1UGetmnD2pqTkjy6D2prxDyoYot/WFhUdRZqad2+C8fN5lVn1aY2f2Ra7wwZTFwwBTW4tpaO3e63DJKesMvvY+2jcVnEH9EASe+prrJdjFwDIWfgt/2qfuCbkpuVHDVy1s19qxlIJ812yS2yS0Jhhy0e0L/aA88+Oa0LFbA1will1/g3LGDW4foS+aMbBY+Sc/VH2n6AEBGVl7EBt+i8odla1nbJ77uGweEuSJ4d49Vou6iUgUngIhsUeG3jln1IGsZ0o6nk5AcNvKS8ITh7hdQvqanr8KFRv9mEp4mRV1gajCtJwYapR5s5xYk2gzauUJy6v+JyAp3Z4lEwbyYCvjXat9tzdJzsh9T9f1803KZJUomTPl/0PFKqrYAuogMHeoHD93FK+KjYWmth+WcnVkZBiV9pfXu9Dn62kOpz43LHEvNoszDFW7oEOmLt3w0LNSlFA7kfFmqJedd4CA9Y06gF5kU5XKZvEk5jEWZ0bl+NpLfncOKzVYgl/u5PPJDMsdrtJghQIZbbuHD1A0NVa64bM7H1xyYLd0/CaJWD8y/OZrhCaGJWWhXju4f5Kr9HQSVaGAwFtbmxBpd94YxJWXK6I+It1PML3EEf/AVF84M/l6zJtN2iOnUzg2lwuy8tyI93GAZP6XZdY17slMMa+uRsavIvmJJS1mAsJYcTeglXQcVaTptCjbaZR9X8I3K2Laz7PyKJVKG1gYRpwqRVrrV1wkueZRbwak9OL+e1ZEytczjHDz5tGjUBHra61t6E3praQK7RzX1DGXFVicg3u7FjYTtVDewvHXi0IW2oEmY4nOm0qXYrCBNt7GLrlVP4GnKsZT RpXn6Pig gvIHYp8Xzh9qVIN0SiewlsSVYXPP7kYotUAnzXc1WKU+LO1bnWzyZ7AAXV5r0cjnSNyXiOygyNH+8bFl7tlHzg/1WmZAPHAgTb+qDy2xbSR1BlT1NX6EZNhZTvaIMfsmrb6p6x+dw/Rb3sg1Pz2JQFl8zcWWoNzOLBP2/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/4/12 AM11:55, Xiaofei Tan wrote: > > Reviewed-by: Xiaofei Tan Thank you :) Cheers, Shuai > > 在 2023/4/11 18:48, Shuai Xue 写道: >> There are two major types of uncorrected recoverable (UCR) errors : >> >> - Action Required (AR): The error is detected and the processor already >>    consumes the memory. OS requires to take action (for example, offline >>    failure page/kill failure thread) to recover this uncorrectable error. >> >> - Action Optional (AO): The error is detected out of processor execution >>    context. Some data in the memory are corrupted. But the data have not >>    been consumed. OS is optional to take action to recover this >>    uncorrectable error. >> >> The essential difference between AR and AO errors is that AR is a >> synchronous event, while AO is an asynchronous event. The hardware will >> signal a synchronous exception (Machine Check Exception on X86 and >> Synchronous External Abort on Arm64) when an error is detected and the >> memory access has been architecturally executed. >> >> When APEI firmware first is enabled, a platform may describe one error >> source for the handling of synchronous errors (e.g. MCE or SEA notification >> ), or for handling asynchronous errors (e.g. SCI or External Interrupt >> notification). In other words, we can distinguish synchronous errors by >> APEI notification. For AR errors, kernel will kill current process >> accessing the poisoned page by sending SIGBUS with BUS_MCEERR_AR. In >> addition, for AO errors, kernel will notify the process who owns the >> poisoned page by sending SIGBUS with BUS_MCEERR_AO in early kill mode. >> However, the GHES driver always sets mf_flags to 0 so that all UCR errors >> are handled as AO errors in memory failure. >> >> To this end, set memory failure flags as MF_ACTION_REQUIRED on synchronous >> events. >> >> Fixes: ba61ca4aab47 ("ACPI, APEI, GHES: Add hardware memory error recovery support")' >> Signed-off-by: Shuai Xue >> Tested-by: Ma Wupeng >> --- >>   drivers/acpi/apei/ghes.c | 29 +++++++++++++++++++++++------ >>   1 file changed, 23 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index 34ad071a64e9..c479b85899f5 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -101,6 +101,20 @@ static inline bool is_hest_type_generic_v2(struct ghes *ghes) >>       return ghes->generic->header.type == ACPI_HEST_TYPE_GENERIC_ERROR_V2; >>   } >>   +/* >> + * A platform may describe one error source for the handling of synchronous >> + * errors (e.g. MCE or SEA), or for handling asynchronous errors (e.g. SCI >> + * or External Interrupt). On x86, the HEST notifications are always >> + * asynchronous, so only SEA on ARM is delivered as a synchronous >> + * notification. >> + */ >> +static inline bool is_hest_sync_notify(struct ghes *ghes) >> +{ >> +    u8 notify_type = ghes->generic->notify.type; >> + >> +    return notify_type == ACPI_HEST_NOTIFY_SEA; >> +} >> + >>   /* >>    * This driver isn't really modular, however for the time being, >>    * continuing to use module_param is the easiest way to remain >> @@ -477,7 +491,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags) >>   } >>     static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >> -                       int sev) >> +                       int sev, bool sync) >>   { >>       int flags = -1; >>       int sec_sev = ghes_severity(gdata->error_severity); >> @@ -491,7 +505,7 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >>           (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) >>           flags = MF_SOFT_OFFLINE; >>       if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) >> -        flags = 0; >> +        flags = sync ? MF_ACTION_REQUIRED : 0; >>         if (flags != -1) >>           return ghes_do_memory_failure(mem_err->physical_addr, flags); >> @@ -499,9 +513,11 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >>       return false; >>   } >>   -static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, int sev) >> +static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, >> +                       int sev, bool sync) >>   { >>       struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata); >> +    int flags = sync ? MF_ACTION_REQUIRED : 0; >>       bool queued = false; >>       int sec_sev, i; >>       char *p; >> @@ -526,7 +542,7 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, int s >>            * and don't filter out 'corrected' error here. >>            */ >>           if (is_cache && has_pa) { >> -            queued = ghes_do_memory_failure(err_info->physical_fault_addr, 0); >> +            queued = ghes_do_memory_failure(err_info->physical_fault_addr, flags); >>               p += err_info->length; >>               continue; >>           } >> @@ -647,6 +663,7 @@ static bool ghes_do_proc(struct ghes *ghes, >>       const guid_t *fru_id = &guid_null; >>       char *fru_text = ""; >>       bool queued = false; >> +    bool sync = is_hest_sync_notify(ghes); >>         sev = ghes_severity(estatus->error_severity); >>       apei_estatus_for_each_section(estatus, gdata) { >> @@ -664,13 +681,13 @@ static bool ghes_do_proc(struct ghes *ghes, >>               atomic_notifier_call_chain(&ghes_report_chain, sev, mem_err); >>                 arch_apei_report_mem_error(sev, mem_err); >> -            queued = ghes_handle_memory_failure(gdata, sev); >> +            queued = ghes_handle_memory_failure(gdata, sev, sync); >>           } >>           else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { >>               ghes_handle_aer(gdata); >>           } >>           else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { >> -            queued = ghes_handle_arm_hw_error(gdata, sev); >> +            queued = ghes_handle_arm_hw_error(gdata, sev, sync); >>           } else { >>               void *err = acpi_hest_get_payload(gdata); >>