From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5436EE67493 for ; Fri, 1 Nov 2024 01:44:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBE266B00A1; Thu, 31 Oct 2024 21:44:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6CBA6B00A2; Thu, 31 Oct 2024 21:44:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D6E6B00A6; Thu, 31 Oct 2024 21:44:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A24F16B00A1 for ; Thu, 31 Oct 2024 21:44:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3A4C7A19E2 for ; Fri, 1 Nov 2024 01:44:54 +0000 (UTC) X-FDA: 82735831122.07.4131CD2 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf29.hostedemail.com (Postfix) with ESMTP id DF001120005 for ; Fri, 1 Nov 2024 01:44:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="xQwTEOd/"; spf=pass (imf29.hostedemail.com: domain of junaids@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=junaids@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730425360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u3XP5Wkv+RNW2+r7bEHxQsIWfnBYd0uQeyY2higphAI=; b=oFl+F6S3dwEoXzLY1dqoxm7upTzyq5Aw7AHl8VJ0WpxiAx//NQcuEQBlMx00aagSCN87gL oNOIxrc9MAnYrd6jgMf07nURCGwCFn2dYMfF2H4+sc/ZD89sNDLaiJPeg7iwtXckjiqxf8 W1e0scKpODI9a38T0OwanTZ7ZkvNjkQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730425360; a=rsa-sha256; cv=none; b=8nv7rMjfyLHG//9kubU63hJcmrGGJK4oMNin5xsuP3PoRTcNzU+29B3VATZwv5jmEu9V8u 1QFSoxsgPaFdp3QQeEphWO5q1IazCg+TiYew8lTR0PdzuEj2GCID/h1633sqqDQuVfZgnX /3yyYHVXY0QKvBdEe52md3OOW6pwfq0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="xQwTEOd/"; spf=pass (imf29.hostedemail.com: domain of junaids@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=junaids@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20ca03687fdso43325ad.0 for ; Thu, 31 Oct 2024 18:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730425491; x=1731030291; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u3XP5Wkv+RNW2+r7bEHxQsIWfnBYd0uQeyY2higphAI=; b=xQwTEOd/xPxd6b0F6AJR1XKvThDc9K2DOtbBfWcV0m3Md2Xc5xjg+peO5/Ey3ubuog GHCdr/F/GYmZZoDIe4haW58KUsVfrdpVPrsex++Gwy9g5n/PLo9er0TkU4BBXACLiZ2Z Tfi3puJsjSyshDC0PyQfAFmuD8WujZ32m0hJvNKALmAK74umX6DL3JGV287lB1L5zLq0 9r1BKhLCKdcbb1iKL5LUqsM1q39tF/c8HL/mz3iuZwJjQ72dUgu427Tps9zBZS7M3ZPa 5joGnRGTlsMS6VzKGls2Qq53to24iERj+uwjJSBbmQTaPhYUd6rTPMpDe5apyXskCeMx vr1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730425491; x=1731030291; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u3XP5Wkv+RNW2+r7bEHxQsIWfnBYd0uQeyY2higphAI=; b=nQvpnbElkipnxWYjIO+SnrjzKW/pyccS9JzYIjA8MDwh96xnV3FTZI35p04ZTAyhEU 1YoJfNNpuaPAHmHGlGdBIm6HuR477ImxsAeMlXWeHqTqHLZqms9Uz2FSEcUItWSVAi1H Pger0yf+u4xyTowKmFz6WpJp6bpT7bsfLKtHs2/2js44QSw7sxnVzzbos4nDhx7STFhK UVuxkFlTuYV2gCqR/LyK8p+56UjiEladdn9J67BSd6R6RtD1LOczhBGRdtKV1xMW2igc iKzL9CasXFpui55SSDOJZfODjoBa1qZLtgqE2aOjsi7aHEIVcDeMn2g6a6xKfNc0PHu+ h1DQ== X-Forwarded-Encrypted: i=1; AJvYcCWmuLyMoLzvUTGe92Sy/GGxOEXMYrmYNskAtUTeSI7DJTvKTxuNPlU7fZZXbrt3XFEL0vbhCAQX5A==@kvack.org X-Gm-Message-State: AOJu0YzzG4DC6qubqoE62/gEqfFxa3QdDdfNRJOVj5zuq/b1e/iKIx0+ GDc23CJqSEFg5wBMMGEKOxKB43TyGO58Peq0LSDS25YIgOY1U6e0j+H/R/VO6Q== X-Gm-Gg: ASbGncukwm2wt+uB30ushh3iQ6ESlINH7FrhouROQJnBUikjW+GNpirFlxh78ebDK47 N54Jm3YBXWaAC33644tYb/pJ10lJcjCglXR9Gl/92kl7YgtPbLs73ERknkGIU5P3eqnn79aJenF zrvrL1c+pMCRLEQF4fk3r93JNjQKXTHvf2zSTElHy5L3mu/euwP2gKTpd92N/LSfTp0P/6vOxOG gZDhASQGPcirIUXFwBYulEZOMbDPlx8024pGoVlRssJ4qqT0hvTRENJuW1TwQB/Ym4ttGp1rfcu foWw7T/NXegdVAQ/6Igruyg= X-Google-Smtp-Source: AGHT+IE5Sl0gNcxBorXKwK80EliT1yn0U0hB4LI9lWcpW0YggnBB9NdstYuNqAFfcfuSQro9x8ORag== X-Received: by 2002:a17:902:ce91:b0:207:14ca:f0c1 with SMTP id d9443c01a7336-2110427ce3cmr4195975ad.16.1730425490601; Thu, 31 Oct 2024 18:44:50 -0700 (PDT) Received: from ?IPV6:2600:1700:38d4:55d0:1ce2:4bd3:4446:5b60? ([2600:1700:38d4:55d0:1ce2:4bd3:4446:5b60]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc1e5839sm1799727b3a.68.2024.10.31.18.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 18:44:49 -0700 (PDT) Message-ID: Date: Thu, 31 Oct 2024 18:44:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/26] mm: asi: Make some utility functions noinstr compatible To: Thomas Gleixner , Brendan Jackman , Borislav Petkov Cc: Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Sean Christopherson , Paolo Bonzini , Alexandre Chartre , Liran Alon , Jan Setje-Eilers , Catalin Marinas , Will Deacon , Mark Rutland , Andrew Morton , Mel Gorman , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Michal Hocko , Khalid Aziz , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Valentin Schneider , Paul Turner , Reiji Watanabe , Ofir Weisse , Yosry Ahmed , Patrick Bellasi , KP Singh , Alexandra Sandulescu , Matteo Rizzo , Jann Horn , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org References: <20240712-asi-rfc-24-v1-0-144b319a40d8@google.com> <20240712-asi-rfc-24-v1-1-144b319a40d8@google.com> <20241025113455.GMZxuCX2Tzu8ulwN3o@fat_crate.local> <878qu6205g.ffs@tglx> Content-Language: en-US From: Junaid Shahid In-Reply-To: <878qu6205g.ffs@tglx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DF001120005 X-Stat-Signature: dudnze5gro1wjtg8ia9mone7aub586sy X-HE-Tag: 1730425454-892368 X-HE-Meta: U2FsdGVkX18zcVfxIsrHcMgF3SIQ6AV/C0ZpfMCZVHiYuJDLrupnO8Q0y/UlIJZvg9yX/j8rYQUN3RThyGK6FB0GE2BdDWNNbb2Npqz8DnODRJa982vzGf54/kKA0Ky1gGKcq3kH3LifaN+A/X3lKrncj+2jliJ+6FolcA1isYhBUJHxKRyphzfsQwpBvvc63bIeDUgrIzgJph73q93bMPAc5A1f0KUcJzPH1q+lvvdgQF04Izspc4sQSewZGn0KiNKRWPlqi1UB0D7yb1g2og7ktYxN+5vMW4w+IpqaMbFGI/ToogPolRUdzoyvekgKJV8iSEI3wn1ut6jWdK53cAJ9LB28T6imX+9yWHFuy4nwz+2T5vOFRGJWS3sX87WHYIlUZMh5LCe3z6JfthsGn9aGsmPdPSLC4KIMsQHfMTNmuhFwXaSnHAfZeVkKhXHVwc6Dr3xGeTu6gS1lVVf/3hf7VdV6+hJ5qAvJXXj3Pn+kusq15ObDrfYIHzkiRF651YVZOhuxe1OH0CFgpYwWJtpQcd758J00EA/6aS8xO7xDIppbprLemuczVJAUOG2gJY1KeFyrSD3VnOll+57zS580AXw5jOtNBdergFqHGWGX3s2HCyL94Q/AokrGEFwzirO5B1JsE296RAdInQCiXkRyT8rkHpCuA6ybnM+SZ0m8jDlJd63d34KGSQe1ZW3thep0epNcqjtos5dmXojV1qJ89XxvC507gaoSGNgG+HZQeP6INR5wYDUW8MSFiQrrawmaTf22MkCs4THIZfiMA7XhTaTRm6mFDF/BUvnQywpJ5o/khqNLR5Crcb8dKFB0KLgzu9NY5mmylELtqnqaC97VaYqThMA1BbewyW9Jr1FfAy40NnBqFp7PqVCg4kHE5ELvjkzaaLz7+uAlaskANx0QqYNTA8Cg2d78Hw/xOfculBkywzDDBLqjX6INfUleYg/wosPAj3u1CUbVlEr hTX78k/T ZlyHk9HjY0ksWjAdDmLXsB3yCG3XJ9HJOZssgULBi2LPCBOoRgxSYT9D3SVdyjIQKSq8rrBkhful4vA3yCfQCWDAkhb7G0VectaAQi8f52YqsDbVc1SD2IHjQBUZBSpW7x/5dRcrS5Ru+sPZBKE2a+rILhIwVorRiPl6cUcqvrDKJJMFo0hfHDbazYdZCaPfD0XWXu1c0pFDO/0xr2kuYXvx9g9cb32lJX6Z8uSNxK9qNB0V2uxp9DptHiZB++HqjMdR7UrQpARBu4nlvrxiPazlbENPzLLfKMmUq7YBnPMT2sjFknSgOJ7U0RaFTN3Wj7odREgZ46Ce1hc6S8JbiKMWaBAISFMZIPKP43nGQR1FGjY5oUPfNkd1WlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/29/24 12:12 PM, Thomas Gleixner wrote: > > I doubt that it works as you want it to work. > > + inline notrace __attribute((__section__(".noinstr.text"))) \ > > So this explicitely puts the inline into the .noinstr.text section, > which means when it is used in .text the compiler will generate an out-of > line function in the .noinstr.text section and insert a call into the > usage site. That's independent of the size of the inline. > Oh, that's interesting. IIRC I had seen regular (.text) inline functions get inlined into .noinstr.text callers. I assume the difference is that here the section is marked explicitly rather than being implicit? In any case, I guess we could just mark these functions as plain noinstr. (Unless there happens to be some other way to indicate to the compiler to place any non-inlined copy of the function in .noinstr.text but still allow inlining into .text if it makes sense optimization-wise.) Thanks, Junaid