From: Mark Brown <broonie@kernel.org>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] selftests/mm: Report unique test names for each cow test
Date: Tue, 27 May 2025 14:06:22 +0100 [thread overview]
Message-ID: <d09e1347-bf13-48f9-91df-2b90f6d15a16@sirena.org.uk> (raw)
In-Reply-To: <675ce51b-a218-4fe9-a571-56387d72fffb@lucifer.local>
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
On Tue, May 27, 2025 at 12:53:30PM +0100, Lorenzo Stoakes wrote:
> On Tue, May 27, 2025 at 12:49:57PM +0100, Mark Brown wrote:
> > On Tue, May 27, 2025 at 11:08:05AM +0100, Lorenzo Stoakes wrote:
> > > On Thu, May 22, 2025 at 06:38:52PM +0100, Mark Brown wrote:
> >
> > > > ret = setup_comm_pipes(&comm_pipes);
> > > > if (ret) {
> > > > - ksft_test_result_fail("pipe() failed\n");
> > > > + log_test_result(KAFT_FAIL);
> > >
> > > Looks like a typo here :) Should be KSFT not KAFT.
Somewhat impressively clang is managing to build this perfectly happily
locally which also isn't helping, I can't figure out why. Can't see a
system include with it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-05-27 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 17:38 [PATCH 0/4] selftests/mm: cow and gup_longterm cleanups Mark Brown
2025-05-22 17:38 ` [PATCH 1/4] selftests/mm: Use standard ksft_finished() in cow and gup_longterm Mark Brown
2025-05-27 12:34 ` David Hildenbrand
2025-05-22 17:38 ` [PATCH 2/4] selftest/mm: Add helper for logging test start and results Mark Brown
2025-05-22 17:38 ` [PATCH 3/4] selftests/mm: Report unique test names for each cow test Mark Brown
2025-05-27 10:08 ` Lorenzo Stoakes
2025-05-27 11:49 ` Mark Brown
2025-05-27 11:53 ` Lorenzo Stoakes
2025-05-27 12:06 ` Mark Brown
2025-05-27 13:06 ` Mark Brown [this message]
2025-05-22 17:38 ` [PATCH 4/4] selftests/mm: Fix test result reporting in gup_longterm Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d09e1347-bf13-48f9-91df-2b90f6d15a16@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox