From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFD5C5AE59 for ; Tue, 3 Jun 2025 21:28:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C44C46B051F; Tue, 3 Jun 2025 17:28:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF5386B0520; Tue, 3 Jun 2025 17:28:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABCF56B0521; Tue, 3 Jun 2025 17:28:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8FC1C6B051F for ; Tue, 3 Jun 2025 17:28:03 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0F38FEEED0 for ; Tue, 3 Jun 2025 21:28:03 +0000 (UTC) X-FDA: 83515377246.15.DCD393A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 8394BC0002 for ; Tue, 3 Jun 2025 21:28:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U3Nd4JD/"; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748986080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CFl8Z5zpVsLk82X+sczguuxuJrSvuXlYSUtFRBPD8vc=; b=o8vPkeYL2X7L9FWw9+jNRiDolYQceHMUeyJ2SrIoHLcwnMkGC7/e2YTRWAxGXju3mcz092 oes0jA41I8SX6VNpDMcK90jkA2SckXa0EiRB897wdK8U/NFnOKe2JCDG+L39chVcYk67LN yqvplnQKPN9sVUv/IRppv33cHn11xZQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U3Nd4JD/"; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748986080; a=rsa-sha256; cv=none; b=yBRuBe2smXqZAK94xj6TfSIRvBRidjSBJN18LXpPXZt8wmXbphv17Ub+95hx6j0E4oH9oP 3HU1xLJvAROvW2DiRfmwLXhCbyphcPxVs5YV9aKizW3MXR0EyRp+HvMSJYSvrjHJ/eAZm6 8o41AHlSBPtNlNjXxJ/lNU+IQ7/j/fI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748986079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CFl8Z5zpVsLk82X+sczguuxuJrSvuXlYSUtFRBPD8vc=; b=U3Nd4JD/+1d+G1IyV2x5ilN/HO2ZRRB9M1YcoD92H68ic2lf+TVTBNLOi/RGEBVKQW/9Cg u9oI4K9EMvdiBJIYIR79iowODEClmoahE+Pjy0II0rL385Hho+3WtCDiPdFoR4a2Dfjf/A 8cZaoF6z74WPQGtoWaEX64Czh6eyIPo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-0HKw69HWMg-67ZbicgNetQ-1; Tue, 03 Jun 2025 17:27:56 -0400 X-MC-Unique: 0HKw69HWMg-67ZbicgNetQ-1 X-Mimecast-MFC-AGG-ID: 0HKw69HWMg-67ZbicgNetQ_1748986075 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451ac1b43c4so19661735e9.0 for ; Tue, 03 Jun 2025 14:27:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748986075; x=1749590875; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CFl8Z5zpVsLk82X+sczguuxuJrSvuXlYSUtFRBPD8vc=; b=eO/lp2BG4d6Vk6xYcN6L5gf6Qk2WWRybm92aCOOyOjseanBrWGgzxsH/mAFnxNmG5c OT0gQFrePVxOFNXDdaA7RHDi7N5xMTWeuYVBQ24yoeNZrpsGaO7y/M60LIeATttwn8iX KXGLFtP334esIHvJZQ32XE0mE6Q++xqY8Q0nxJnvk1beL/3CqvGD7DLT2YWNJRJfsXVX eIPUYP1OYYp8cICN0OfnKkFHsqtpq7QIBqxMTNpHNtr2UYUVBRDkFSNGoyHve5YTzCIp krUiWN3xA7ZxqdXU539JMW7s2Ug1aa6d2uawgErHYjV2A0TO0rS6uO3+FsSod6DHPhi+ GRuQ== X-Forwarded-Encrypted: i=1; AJvYcCVTgp8nXh4x4PoJhd7G4EdhqGB/tU15aUJu/tRE9X9mHUWp132+seaPABXkzAijfSq5RB9MPOanEg==@kvack.org X-Gm-Message-State: AOJu0YyGdjzcQHBPCLYIlp0LDNkWBt73YfAY7fokyI/EPwbixPFnlqcV cbSE5QQKLYB718z/FxktBmbFncFrcU3b3jLrnnPDYlWwYJ+j2X+HtPp5R1osyI73XdlB2Fvmw1F 248Eja9jEOGvH9H6MINGK7BxpPFhzReZU79ymEaph36EU5FuSdHpd X-Gm-Gg: ASbGncu6kw0iu40SPq3+VJw+EnxFZy0JTHbn3OVvFIXPpf8XPIvtgJGyTEWTXxleHD1 G6cKrzfftxjDVOFuvs7iOVmmibNcR/7Pcn/hH2kQ1Td2lxOApNhq23+8CfWn42hwaIKTD/1Cs/Y btk5zL3V85yyvm0+cw0FO/sDS3LbbMy/egI70ved+MOVVobs9gwa1aR2wGvLJYTpih3PS7VB7LG rRGXHW4MEoyJzT66oMXwidn4niJFVng5kaZGuc4juZr+a2j3+2a8UjM9iM8MgeCjeuTm2juo80R Py3aBq1mnttGgmBlH0vRAEuJKsJ4UUJ/snAbBb3ywWM/RAPhX6IFDZCbIHBUUwJ8M3+MZeOyp2h IpbIxuij9T9mc74mduVD4ST8Rdo+q4ZLhPo8P878= X-Received: by 2002:a05:600c:4f8b:b0:450:d37d:7c with SMTP id 5b1f17b1804b1-451f0b105d0mr1729725e9.21.1748986075462; Tue, 03 Jun 2025 14:27:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENSDbSQ6NSwSfZoU79WaytPfnSJbzMWyUTJ6KwFvkHxNGfQ4XrRdJP7uyAd5N+iV77fH+Gkw== X-Received: by 2002:a05:600c:4f8b:b0:450:d37d:7c with SMTP id 5b1f17b1804b1-451f0b105d0mr1729615e9.21.1748986075128; Tue, 03 Jun 2025 14:27:55 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451e57bcb99sm25751735e9.2.2025.06.03.14.27.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 14:27:54 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 23:27:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 6/6] mm/page_isolation: remove migratetype parameter from more functions. To: Zi Yan , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org Cc: Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250602235247.1219983-1-ziy@nvidia.com> <20250602235247.1219983-7-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250602235247.1219983-7-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: l7qW2ypiNEWKE5ysbVwD8_RaEcTP_6dPBrZ9dYgbv8w_1748986075 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 8394BC0002 X-Rspamd-Server: rspam09 X-Stat-Signature: qzsoqoxb5kywfih1rotz1k9fi1fq7pjw X-HE-Tag: 1748986080-224694 X-HE-Meta: U2FsdGVkX1+yE9/NKKQj0zj2Xy8DRgPXlTPzRXDMOOMm0qo5cpmxcHqbGvoYVHE8b0QNnAQMVrPcnZzesOdS5GeNvzXUejSFHd6r0CKhmhEh6L/vjVOfgffe9sz4ZAoJ5cVIBgwLSROCD/zboH8qExE0vVD0Pm9esNqfHrmEAcGVBBc/ZV6wvKnTtDT3RKX3k2MP7YRJKsjYmTqBnwW6enbmMy6s8JOGIvzcXq7ck7X5Ci/IMUwyiXYX63gzq98VMwE3R3Py32HaS1pmbKF9zOjvSYBrYy85b9ri5XoAT/mGHQgTjkvPkwcNj+1inLZapNagdakGV5/4lT7MRPBj3hVO6HzPOWXXxEv9oVDA+Wvld6XjputC21XyL1IsrY3SPEc+0+3Hb5gwWxAue3NSnUXcVyLuQfwNhkhral7QocnNaAczE3FhArFhRNofA3N+OV0/6+L9BualrDmkzHKNlEGGvhSMFv4gLz3WHLyKLwOS5Yu/ewTA1baqAYhXG+YB3lE7H18FhKlfy4m/IOHPHwSobjcXAOHP2zCM+1KmE3SdfNW4KafQbZ3f/dUwky1i+8z06NZjeI51R/QjCQ+Im3GLCd5nF+YoILdajsXHzFWAi2YpVhFt40QVxdyUxLeWx9xm2Y1zaSVjSw1yd5KhHyIOA0IyFnN8fIa1+c7HgLXcQQbbC3KBX9CkOB8cT6uPzsfuhEXbrHMNPeuMVLHomPnmFjm09LgbQDT49oPjMfSe6gkAg74Y0bpT9jnXycPcwTCHr9Ntoqb5Oh9QMeOqEf5+XGlum4UslpShq1GwAyO4kDUwZ2uS9wKKBuLcl7Xs9gYct2WudWWoQj4/MxyZp5pZO+7FqZFJIYVSPbHg1S11AjJK90WQYFOqoQ8lPeEGgk38gkzwAsYuJEsEIDYUl9exmeLAvFc1QIemsoqQuPRSXDQULlqeIEz3ykjve/6Dqs4rKWnKZw9pEa3YR+o 1SIELgEF sIYbP8J35pWQN1tZUerGntf7CLWgJnwghp4uyIvX5tN00SDlyBlyy8zbBbB5NWWPgZ3ZCZVcHktQoQhirwMhoIPXf9V1d2TwZq9M3JEzMtxwDrf3hXtDKAEGBlRFiTqMk6C4BeObK3rAumMfbwrIKk9OJari3MnD4m9bASKbfOgrGF0XdktB8pZI7E5iO5Xk3AlOy29o0SH75veBIN2e6yojx48ejtueduGvi8eYvQo4c3DEXgwiyczwDOxHVauvN1x6WfJGW9PaehYdyZhraO69V5X/t4UJiDu8TsIuEGxmRqZvN3WSsgVlL0Dl3dVgG11S9x4v6x6KblmMFnRh2SRZWUhpsRse5IthRkhYkaKNVOY/mmgzCJjF2IULSZDre3RWoRcVneirvGaPPFQVdXF1q8SaYmA8j2I2Q06V5tVnWU0Zk+F373wKBX4JLhH5FJfjPBGRokP2f3Ad/QN74rmKSoW39IoV/D3XOjUgzKU6NL9seiWG0f+NzFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 01:52, Zi Yan wrote: > migratetype is no longer overwritten during pageblock isolation, > start_isolate_page_range(), has_unmovable_pages(), and > set_migratetype_isolate() no longer need which migratetype to restore > during isolation failure. > > For has_unmoable_pages(), it needs to know if the isolation is for CMA > allocation, so adding PB_ISOLATE_MODE_CMA_ALLOC provide the information. > At the same time change isolation flags to enum pb_isolate_mode > (PB_ISOLATE_MODE_MEM_OFFLINE, PB_ISOLATE_MODE_CMA_ALLOC, > PB_ISOLATE_MODE_OTHER). Remove REPORT_FAILURE and check > PB_ISOLATE_MODE_MEM_OFFLINE, since only PB_ISOLATE_MODE_MEM_OFFLINE > reports isolation failures. > > alloc_contig_range() no longer needs migratetype. Replace it with > a newly defined acr_flags_t to tell if an allocation is for CMA. So does > __alloc_contig_migrate_range(). Add ACR_NONE (set to 0) to indicate > ordinary allocations. > > Signed-off-by: Zi Yan > Reviewed-by: Vlastimil Babka > --- Thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb