From: "David Hildenbrand (arm)" <david@kernel.org>
To: "Pratik R. Sampat" <prsampat@amd.com>,
linux-mm@kvack.org, linux-coco@lists.linux.dev, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, kas@kernel.org, ardb@kernel.org,
akpm@linux-foundation.org, osalvador@suse.de,
thomas.lendacky@amd.com, michael.roth@amd.com
Subject: Re: [PATCH v4 1/2] mm/memory_hotplug: Add support to accept memory during hot-add
Date: Wed, 4 Feb 2026 21:00:36 +0100 [thread overview]
Message-ID: <d07cbb96-ba30-4dcf-ad14-0479d6a989f2@kernel.org> (raw)
In-Reply-To: <20260203174946.1198053-2-prsampat@amd.com>
> #endif
>
> static inline bool pfn_is_unaccepted_memory(unsigned long pfn)
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index a63ec679d861..549ccfd190ee 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1567,6 +1567,8 @@ int add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags)
> if (!strcmp(res->name, "System RAM"))
> firmware_map_add_hotplug(start, start + size, "System RAM");
>
> + accept_hotplug_memory(start, size);
> +
> /* device_online() will take the lock when calling online_pages() */
> mem_hotplug_done();
>
I really hate that accepting (and un-accepting) hotplugged memory is
different to accepting ordinary boot memory.
Is there really no way we can get a reasonable implementation where we
just call a generic accept_memory() and it will know what to do?
--
Cheers,
David
next prev parent reply other threads:[~2026-02-04 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 17:49 [PATCH v4 0/2] SEV-SNP Unaccepted Memory Hotplug Pratik R. Sampat
2026-02-03 17:49 ` [PATCH v4 1/2] mm/memory_hotplug: Add support to accept memory during hot-add Pratik R. Sampat
2026-02-04 11:22 ` Kiryl Shutsemau
2026-02-04 19:59 ` David Hildenbrand (arm)
2026-02-05 3:50 ` Pratik R. Sampat
2026-02-05 10:51 ` Kiryl Shutsemau
2026-02-04 20:00 ` David Hildenbrand (arm) [this message]
2026-02-05 3:50 ` Pratik R. Sampat
2026-02-05 10:48 ` Kiryl Shutsemau
2026-02-05 15:48 ` David Hildenbrand (Arm)
2026-02-05 16:08 ` Kiryl Shutsemau
2026-02-05 17:29 ` David Hildenbrand (Arm)
2026-02-06 12:03 ` Kiryl Shutsemau
2026-02-16 14:45 ` Pratik R. Sampat
2026-02-03 17:49 ` [PATCH v4 2/2] x86/sev: Add support to unaccept memory after hot-remove Pratik R. Sampat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d07cbb96-ba30-4dcf-ad14-0479d6a989f2@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kas@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=prsampat@amd.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox