From: David Hildenbrand <david@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
Muchun Song <muchun.song@linux.dev>, Zi Yan <ziy@nvidia.com>,
Matthew Wilcox <willy@infradead.org>
Cc: sidhartha.kumar@oracle.com, jane.chu@oracle.com,
Vlastimil Babka <vbabka@suse.cz>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org
Subject: Re: [PATCH v2 4/8] mm: page_alloc: add split_non_compound_page()
Date: Tue, 30 Sep 2025 12:06:46 +0200 [thread overview]
Message-ID: <d075fb47-5f87-44e1-8d04-b3311c7b7bc6@redhat.com> (raw)
In-Reply-To: <20250918132000.1951232-5-wangkefeng.wang@huawei.com>
On 18.09.25 15:19, Kefeng Wang wrote:
> Add new split_non_compound_page() to simplify make_alloc_exact().
>
"Factor out the splitting of non-compound page from make_alloc_exact()
and split_page() into a new helper function split_non_compound_page()".
Not sure I enjoy the name "split_non_compound_page()", but it matches
the existing theme of split_page(): we're not really splitting any
pages, we're just adjusting tracking metadata for pages part of the
original-higher-order-page so it can be freed separately later.
But now I think of it, the terminology is bad if you look at the
description of split_page(): "split_page takes a non-compound
higher-order page, and splits it into n (1<<order) sub-pages:
page[0..n]". It's unclear how split_non_compound_page() would really differ.
I would suggest you call the new helper simply "__split_page" ?
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-09-30 10:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 13:19 [PATCH v2 0/8] mm: hugetlb: allocate frozen gigantic folio Kefeng Wang
2025-09-18 13:19 ` [PATCH v2 1/8] mm: page_alloc: optimize pfn_range_valid_contig() Kefeng Wang
2025-09-18 15:49 ` Zi Yan
2025-09-19 2:03 ` Kefeng Wang
2025-09-19 1:40 ` kernel test robot
2025-09-19 5:00 ` Dev Jain
2025-09-20 8:19 ` Kefeng Wang
2025-09-30 9:56 ` David Hildenbrand
2025-10-09 12:40 ` Kefeng Wang
2025-09-18 13:19 ` [PATCH v2 2/8] mm: hugetlb: optimize replace_free_hugepage_folios() Kefeng Wang
2025-09-30 9:57 ` David Hildenbrand
2025-10-09 12:40 ` Kefeng Wang
2025-09-18 13:19 ` [PATCH v2 3/8] mm: debug_vm_pgtable: add debug_vm_pgtable_free_huge_page() Kefeng Wang
2025-09-30 10:01 ` David Hildenbrand
2025-09-18 13:19 ` [PATCH v2 4/8] mm: page_alloc: add split_non_compound_page() Kefeng Wang
2025-09-30 10:06 ` David Hildenbrand [this message]
2025-10-09 12:40 ` Kefeng Wang
2025-09-18 13:19 ` [PATCH v2 5/8] mm: page_alloc: add alloc_contig_{range_frozen,frozen_pages}() Kefeng Wang
2025-09-18 13:19 ` [PATCH v2 6/8] mm: cma: add __cma_release() Kefeng Wang
2025-09-30 10:15 ` David Hildenbrand
2025-10-09 12:40 ` Kefeng Wang
2025-09-18 13:19 ` [PATCH v2 7/8] mm: cma: add cma_alloc_frozen{_compound}() Kefeng Wang
2025-09-18 13:20 ` [PATCH v2 8/8] mm: hugetlb: allocate frozen pages in alloc_gigantic_folio() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d075fb47-5f87-44e1-8d04-b3311c7b7bc6@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=jane.chu@oracle.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=sidhartha.kumar@oracle.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox