From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6B0C27C75 for ; Thu, 13 Jun 2024 15:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 664F26B0098; Thu, 13 Jun 2024 11:13:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6160F6B0099; Thu, 13 Jun 2024 11:13:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B5606B009B; Thu, 13 Jun 2024 11:13:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2E9A16B0098 for ; Thu, 13 Jun 2024 11:13:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BD22CA09B3 for ; Thu, 13 Jun 2024 15:13:28 +0000 (UTC) X-FDA: 82226209296.05.AB0FCAB Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf15.hostedemail.com (Postfix) with ESMTP id D9EA6A0027 for ; Thu, 13 Jun 2024 15:13:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RGMtN2qi; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf15.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718291604; a=rsa-sha256; cv=none; b=doWL1E7rFmbjrN6w0tdUp7LWT0bpPBg2m3LeuIpdHia9i2zV+hL5aAtYzXp1qmrafuXfJR rmxI3vQWm+xuFM8Cvi6YWhZZjMZWJs1d8r8BdtpOY4xK2l2T/ljUp6BINm4XYdMNSe+LHN bePBKeMw/wBLhTXViiigizqB9/cQcGw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RGMtN2qi; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf15.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718291604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R65OusWKx0dwBMqQhrrsKrto+TvW16AkPUtwQVoox2Q=; b=KdZNir8rDyjujLNdTQA4I/6Kc62RVFBJ4kskvCoo/mzv2DqCcb2BKl9b5+/8nr0yJlq5S0 exyaVLFsW52IIBu29159EVZ9tw5sQyzRjv9nwfmMZPs/4PapGgX2IWJ41CKMTzJOTViBwv WUkt/Z/Xyqj2r5/9m5SeGexM8m4mYq0= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4218180a122so8800785e9.1 for ; Thu, 13 Jun 2024 08:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718291604; x=1718896404; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R65OusWKx0dwBMqQhrrsKrto+TvW16AkPUtwQVoox2Q=; b=RGMtN2qiWUDcrLBkyqZsP8cgvMQKDyKh4oFxAUIntUi+ds3pI6rLEJ3t+wh1i1LBTG 7D7EEoMZ8a1UQ+xkRmw2H+SzA+SzVkAxyfHIUYqlaKTX9KJ2WgNN44UvbWvB9nrD10V7 sfRtZaqeiQDJfw7k6st19moBLMbaUSNmkRE67byO5zBUj+dAKz5XykmnkkTr4/R2phaJ mvVWJLFJgShVsk1YT9DOuEd1SkRO+Oy2iThQclG9r9+/jozUY+IfTEKMSAz/I/uxyeug v6n6ay97wZKlyGWfuVHiyEgk7HIQKByTe9KnQy8Sw0AYtU+l7ueGjw9XaUlt9Z9nwETN FZww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718291604; x=1718896404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R65OusWKx0dwBMqQhrrsKrto+TvW16AkPUtwQVoox2Q=; b=ot9hBCinzFQiaQrLzQN8bmvfrsWrsZc0lZkuD/F9Bkzafq3RdU1rtSpR/ZQQ9cdx89 47JETxDgrPnCkVuqPNtSPhDS1FxkNbDTbSzd+BMCDnA7Iu3eWRyUGrHiTqAnF9jwYSaP e5l4A6eu7y+a/3uCK0a51MPK6rg1ijQdR4enSglam57wAMnQbYp5LjM86iZK6DAlFmIH Bb8GRXliAYiWsNwWWSTFtW73nQ8Mbya5gtEGP+ZGSEka2Q+fE3muXogTi5G9QyXCXgKg 9955Q+J83063rb8qjFHqpbBGe/tUtnt7u7+iJawLV5qxmdrAhXWDlAZMddqN0UU2ThiL vL0g== X-Forwarded-Encrypted: i=1; AJvYcCX9l5VgojTnPtlyYiGBtoWAYvbZjzKae8n0bIPlmwgjizYyw5LJZu9hi1VGi+dXkyxes5VZcn4W0ys0naRUY5TKYDg= X-Gm-Message-State: AOJu0Yx9RYR2X2KQD/w0H7PFOoQEBpVA9JJrgwnJJAnvSyAUrr2/s/hL O4+wJU05Y9NoE92hQ+hYzXh1gZBN1taBE2qTNhTqmoNyrwV0TciankY6Mdml+TI= X-Google-Smtp-Source: AGHT+IH+y5X78XErjPGrxoAu6Ah+ExEgfa+ffSsyssT2c5oaOJhQdypTijdzJkbJhVD+3kmRIngeqQ== X-Received: by 2002:a05:600c:450d:b0:421:802a:f43c with SMTP id 5b1f17b1804b1-42304824286mr1038135e9.15.1718291604051; Thu, 13 Jun 2024 08:13:24 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750f224esm1977952f8f.66.2024.06.13.08.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 08:13:23 -0700 (PDT) Date: Thu, 13 Jun 2024 18:13:19 +0300 From: Dan Carpenter To: Matthew Wilcox Cc: David Howells , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [bug report] mm: Provide a means of invalidation without using launder_folio Message-ID: References: <8b6bd8e0-04a2-4b51-9b29-74804ba11564@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D9EA6A0027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: br8ykgo5rj4t9tnxndoj64if3jbnhe8j X-HE-Tag: 1718291605-558039 X-HE-Meta: U2FsdGVkX18c+ALwW6yc47r0ZCj+hJscFlAfqoIWqycvXt6naOlEJcSjxRCs10NzH1aJPFgvk2DGVt74VDsl0nWEW9OzgRHyJ2aCsvf0OmmLKXQSfcCjKkMWA/sywWiLJphTj90YaJLwKl53FOtWp66ibxHfnYYPOpCp6D7tbLMnJL9ryQ1DuZU/phzcm6bGTLVgzjjQXVRnKGaoYtvMplEXkXiG6sTaEIIhd1QLGRnl6bjbiJaw+ybUx66RKy3prCHUrQMM4y99KP6D8/TGyuxasZBq/RkP9YRSjlZXW+cPpjYrHEKwwpUedD+iTj1+FBz351iaE6BiWvU26LvXbqPapgqpfFwYqmasfOPAGpCd3PYY8j7rK95CKbsfQt+vpC6/XG/KaQOlSpOco03XKaECa7U+r+fvlzszS1EsL14nUUxqU329EL8+3i3vThMI5IOXpbjyxk9AXOtXXSxPD1hM9PXQsd1pBNWomIPLTF9XSQQy/OYfSLYMBAJQQ0Tod8EuZpdhpX99egHtpuy+8S5L93Ra/rukiTbb5UHdfcG7PCEBkztvWlFEAzeOtgTbrt51NTE/EKcO+7WGOHB+lCoOBJYx41lubZKaUaGSvFIqbRBNNt4JQP5epztWftQYY82eH2XB+A3qMGQxxDKSdgexkvLkMfulY4Zsi4+LuRhxMppJlbhCtZzohCH+b4ICAPOE7tbciPzz/xmqBHxTRpE2pWePKd19iAeh5N/QP8kGGYa5ZAd8ICIczNafBH4Aujb3sVeAs3qZcWFi6vYDc05X79VN9wxfWj59vJP79Ms9VUYfsS+ZJUkFnK1msxSK6g52o83mbWQG2yCtam9iauKlnEU2nIpyjsgUBz1Wxb3EdVnRrJW1IvB093agPaIX5vqM03e6oCwHnxLqpY7rqkDbSiVPgKLfOvRuec7Kfq3J6EgpVIMeWHErpfCHPx9Mzwk0yEXqKNJHE0vsq+p VBhGzMaP pOm6k89rg3BIhZBFAxBJb1+SBZa2ojUcvWYY/rO/QBmzyl8r2Q7pJYENFbWCFWFZcfRtc2HQvvdkTHh1TDT+AL9wHd6T+vI488SbecqMo90X8esLYRz66579PoQMrCjYDXDbUESab0yJ4MS0ob2kfoIcUITkusVMiisa6Zp2HiU67rOm/33B3DcZflCof2ZzjqdgkyEeWez6qSTpbK//vpUPxWLBLkKCBm1Ym6KCqpl/C38kbJtoagdFigL82h3lI5EYqnD+Vb7l0j5PNT8/TyCjr2kj/EU1NpgU/HGuT+O6HF7l9pluNhcJgbMyiQItchi/G X-Bogosity: Ham, tests=bogofilter, spamicity=0.011151, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 03:56:23PM +0100, Matthew Wilcox wrote: > On Thu, Jun 13, 2024 at 04:55:30PM +0300, Dan Carpenter wrote: > > Hello David Howells, > > > > Commit 74e797d79cf1 ("mm: Provide a means of invalidation without > > using launder_folio") from Mar 27, 2024 (linux-next), leads to the > > following Smatch static checker warning: > > > > mm/filemap.c:4229 filemap_invalidate_inode() > > error: we previously assumed 'mapping' could be null (see line 4200) > > I think David has been overly cautious here. I don't think i_mapping > can ever be NULL. inode_init_always() sets i_mapping to be > &inode->i_data and I don't see anywhere that changes i_mapping to be > NULL. > I don't really understand the errors from this function, though... I would have expected it to return -EINVAL on this path but it instead looks up if any error flags as set in the mapping, otherwise it returns success. regards, dan carpenter