From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11623C25B78 for ; Tue, 4 Jun 2024 13:02:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5060F6B00BB; Tue, 4 Jun 2024 09:02:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B6526B00BC; Tue, 4 Jun 2024 09:02:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B9946B00BF; Tue, 4 Jun 2024 09:02:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 013236B00BB for ; Tue, 4 Jun 2024 09:02:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8750680A53 for ; Tue, 4 Jun 2024 13:02:28 +0000 (UTC) X-FDA: 82193219976.09.53EFEA2 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf25.hostedemail.com (Postfix) with ESMTP id 71FFBA001E for ; Tue, 4 Jun 2024 13:02:25 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CpUY+X/S"; spf=pass (imf25.hostedemail.com: domain of seakeel@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717506145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MChTYhGzrz3KYD410VZi7VqQLRbgGN9BW4zzAlK391Y=; b=a3/lPEslN+YcZ5L8wF4dQm4f+zKHAkwUA0QyV0N4Ea+GAwbdnLe25nsuyv3KLzTMEIkpdO JjjNWTwEg5mo+Z7nNEC66W0qSw+NDDZNYxzy0XZvJTWRJAvdGhcn2IlGy4NV6/+rcQR8pH axxinCp6+Yo2aNC/TWcLMOl/yFrg2AE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CpUY+X/S"; spf=pass (imf25.hostedemail.com: domain of seakeel@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717506145; a=rsa-sha256; cv=none; b=gePE+eOT7fjAUmGSyQSql/lwXGSOBywAm919hgmWTTpmPYUkjFzfO1FyY1LZ7ekT+A+eI8 wx4ar0J1OcXltHY1HU0JT0V0hBKxAOIlge0bph4eZ27umKNjGXw3D7rq+eLItJRrn+RxU1 UR3t7U46tCYkDrFi3ZnNxrV1hfMGi74= Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2c1a99b75d8so4146800a91.3 for ; Tue, 04 Jun 2024 06:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717506144; x=1718110944; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=MChTYhGzrz3KYD410VZi7VqQLRbgGN9BW4zzAlK391Y=; b=CpUY+X/SkvLVuchyrqdd3NliIHfHMXZ9N+JFucMlnKQXImM2sctQ0IqVuLp0YzTFtO XYepd34jdKIvxAwlQy/2Oz6Dp3ythqZNa9S6kU11fwMUiFQ22Mceqt2nfe6A+UEXWOGr Q4ADB8VdCF9jhyNhFbQMzzqhLjlUa36Hfc/1zLBtQFWzyMO0ze+9NaJyf0aFVmkMNxPX 630jK3ABGVDIGObrkk6fyz7jeYlkroKHYRQfIBt0/7i01BlnSsvy4HrGekjd3eKAC7rJ PCv01UiEH8TzUL5Kkx3+505aDvaKne9YtDxEKvMMlZHk7yhzxMbx2okpDTDONELpiPPf 6QOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717506144; x=1718110944; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MChTYhGzrz3KYD410VZi7VqQLRbgGN9BW4zzAlK391Y=; b=r7091MCsj+x8yEcCwTd1sXm9nxH67Lj59BSGicBFuxpUnYkUHwb+jZNViQQevChXkr RIQgZjb25iUfn1gwzoLEerAPwQ4sAStl3oOzy6eqFrHK+XYPt2UNqwbkD2FUTIH78ZDz RVLDVroXfDLG0nZ9kPNegbKEckbC8XB9ugpaHs6DHLttzltreEHSQ97hyEaqCIWia2Sr N4d/AoMUrpFubnNdgF/sv3o1h9/tihICsl0SYggws4r+EDIPJF9R1SmvqO+D1Xvrz4tc 4gKShKmvfREZ+kgRfAeEe+fmc+6E/rzWObWF4vuyItQX0+SFLu6qvPi1E01NkF3IHYbt OBKA== X-Forwarded-Encrypted: i=1; AJvYcCU42RSA2BG6splpAsNO6/T42QN+m32W8Iqrzgrwvc0AAJflxjaw23TXP6Cd/dpiKLdYe6MOa+kz8AXMmF9lqFPAEUw= X-Gm-Message-State: AOJu0YxBpp4JUtu4i+WtT7t7FiE2BOAS2qzZ4W2VbXMsLk++5NmA5vtN ChGGxrYAQUA+q20YwpFxH5DgEoLeMSIl3dWsGCvxjEwjCF1FKRFm0BfDqg== X-Google-Smtp-Source: AGHT+IGu0NXkc7YMxuAXWfpe0K9cubaKltPxks/JHC1BZbVqB58WpEQWUlL3P9h9Nzr7jG6Z4wnpnA== X-Received: by 2002:a17:90a:e02:b0:2b9:a7bf:8701 with SMTP id 98e67ed59e1d1-2c1dc588afemr12028084a91.21.1717506143628; Tue, 04 Jun 2024 06:02:23 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c1c2831aefsm8043247a91.38.2024.06.04.06.02.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 06:02:23 -0700 (PDT) Message-ID: Date: Tue, 4 Jun 2024 21:02:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm/ksm: reduce the flush action for ksm merging page To: David Hildenbrand , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-2-alexs@kernel.org> <9ca730ce-2b2f-42d2-8c7a-78735a995c64@redhat.com> <4d299245-3166-4810-b22b-2a5b4f54a049@gmail.com> <7c6ae2a3-8ec3-4c9b-81c3-125f6973f0f3@redhat.com> Content-Language: en-US From: Alex Shi In-Reply-To: <7c6ae2a3-8ec3-4c9b-81c3-125f6973f0f3@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 71FFBA001E X-Stat-Signature: gdugge9b637c9gxowmpcmpzf1xp6xzjo X-Rspam-User: X-HE-Tag: 1717506145-788475 X-HE-Meta: U2FsdGVkX1+PR6YIs5cj++xzAkhfsHxzGypGCFx0kOkeGpUgZ41yNjV+NAJkuwxPFM4tU+LBrQpTSCVTN1PqVVMNKEF7rJdTcLkZho0gq9Qrwau4fa6T5WD3YrWJ3eg/HgD8oeFKKa5sYM55SiZJtj684Io1VQ23EmJSNymQKydwmuhh2x5B0RQkOxA3qYV2zOMkiNJSGhS5nxRsHwTaq9CgKRFEApsJe1+e3IjRoOAg/zem5Rz945ZNdJO6JmwgXq7IAs9xXXoLxwq+sxRid6Sk28OXM7euAEa5jTrg2jxM4mII+WIza3JhcvnpJabGDdVO/+ZtiP0HR88W6XZ1UiYGYcVAWuSlGXKCiqU5/gzze0sSR9NmaLapYeOYbSWUILCrH48h5/Dpnq3QblwcV8jv1qPMmKAVBGpdOYyic8DLjd9/felG/A+uMevsW2B9Un8nZklCgrR5/sLU5uQR+xLxjqYIBLPoLQGJWawTehqj71BwVolxmpOXOE2RLvoSm9/yi2gOJDhB/dk/mcViPY0TJ/vdFbpC12MoTlA1YWoyExRZEMOeE9GB9MbJ+jCLT1nuk6Y7qz87dNmaMZBqKNjja4O+iB7w1LkMjpjSTzq9OkZ3Mf6NIqliDn5LNh6ed7Be8xN8/zTqE/hzSGQOFRBDIA967EJZeXlBih7uQvqED6rxCfC4ZCoYDf180lWHxprjDJY3ipKjNPTph7TY0eFB+A2KmmUSksb9NQUOjhMOryXMYZpG7W1U/jKduxETeHLyddIWpgJ85T7GlcF9ch3pvSdu9ivfhjOZKS8MUJ11PeSTp2tHLvCFwHCEOSeKZVVlZwwndKqzc8RGekxShmL2hsznTBsi7fHNsc2XE4/0XkLl7xvXT9hem+N5jJDsD+HmBxbYvvWSaqbu3j1n+DAKaX35b/D3+pX3aiCxh/XHEUtOIFF2JZZ44Ri0rsrEPjNwGZrPN/WGOUCPhLd UvlXMkIo PQqabrLIE4BwJsQDZktXHQeM/Lbf60KaTBw6405Df1A/tWn15ofC5shErU2iMk6Xo/iusJVx2TDVqv4/T0bbOjOm+aChx90TwVaw7zR4oLV9l7bctP788U5l/K/UeE972z5NVVOmENFOno4IXn4gJ09FtlLZ3cLYZWR6E+8cKJC/YSjcLQX9ooHxmlJA7F8XT2sS6WzNh2ZIJApSgLPBY6XLCEv9u2yELl6WCp0VHLryW0O13LNQIkv9mW2NTZrbyE6LRTDWxe/AFx3lJ/sCb03ZzoQ0PNxQzr0fLkJVsC2NOyaEI8tqgco0Biz/23OoMacThSDYmKJ9Jtdez5dGkDybuho00Wx5VMo36P3nco5n3xy3N19p5H0u7h1cSXYoLqzjw3pJ905iEQjAlMIaAl5O73muvs3RLaQjtgmA3Kuj2qWC/pjKhNH92DCct7+WoAyqyiadITVD5xY+imWBWxPxgwqWM+KEA/bz/TxBsOCnkMLk4H5VpmqY956FpHB+eF8qL+gUS4XVbJkKNveeh9aRN5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/24 6:45 PM, David Hildenbrand wrote: > On 04.06.24 12:26, Alex Shi wrote: >> >> >> On 6/4/24 4:07 PM, David Hildenbrand wrote: >>> On 04.06.24 06:24, alexs@kernel.org wrote: >>>> From: "Alex Shi (tencent)" >>>> >>>> We can put off the flush action util a merging is realy coming. That >>>> could reduce some unmerge page flushing. >>>> BTW, flushing only do at arm, mips and few other archs. >>>> >>> >>> I'm no expert on that flushing, but I thought we would have to do the flushing before accessing page content -- before calculating the checksum etc. >>> >>> Now you would only do it before the pages_identical() check, but not when calculating the checksum. >>> >> >> Hi David, >> >> Thanks a lot for comments! >> >> If calc_checksum() is wrong before pages_idential(), (that's just after page was write_protected, that's a real guarantee for page context secured) pages_identical could recheck and make thing right. >> > > Yes, but you would get more wrong checksums, resulting in more unnecessary pages_identical() checks. > > That is missing from the description, and why we want to change that behavior. > > What's the net win? > >> And as to 2 flush functions here, I didn't see the guarantee for other writer from any other place. So maybe we should remove these flush action? > > "I didn't see the guarantee for other writer from any other place" can you rephrase your comment? > > If you mean "the process could modify that page concurrently", then you are right. But that's different than "the process modified the page in the past and we are reading stale content because we missed a flush". Maybe moving the flush before checksum could relief some worries. :) But still no one knows what flush really help, since if page content only syncs to memory by the flush, the kernel or process can't be work with current code. thanks Alex