From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0340BC3DA4B for ; Wed, 17 Jul 2024 06:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D33E6B0082; Wed, 17 Jul 2024 02:59:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 882ED6B0083; Wed, 17 Jul 2024 02:59:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 771366B0085; Wed, 17 Jul 2024 02:59:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 59C236B0082 for ; Wed, 17 Jul 2024 02:59:51 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CD081401D3 for ; Wed, 17 Jul 2024 06:59:50 +0000 (UTC) X-FDA: 82348344540.29.20948FF Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf28.hostedemail.com (Postfix) with ESMTP id 5B194C0011 for ; Wed, 17 Jul 2024 06:59:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721199548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6L0hS+WQGzwvLIg4G+PQ/EY0Yjr07+yiNTZoeblk6Ag=; b=GChT2vrEVEkwM/z4fRkQLIsbkYauSF2mXTI76BIG1GU8ctsxmq4PwxkQbF+F2R4bBudn81 OTQsxwREtUUQvobdH7Hq37mvL3ECcKruUGwwvJQVhAOqpgr8xZZbxxkkES4+4/Nqd7UUG6 3PhtFEzMEEXX1pE85TEJ/ckFjr2tQds= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721199548; a=rsa-sha256; cv=none; b=zThnxxUQxbT/Yx10MZpBnxX/SG7mWqQBa5I6iW8vgWnXw0OL3VC6yzem1Qi7yES0uI5WAv EsAY+p2TwO4mj6MneUjKeFURZ3T5c61HOq4o1t5lt6vaf3ySg3ArP7t2MosAgmAUU6U/zT UbI2a7DUhTCKGLh34lr/iY4tp40DLIc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WP6Fy3zhFzdhwy; Wed, 17 Jul 2024 14:57:58 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 3CB671800A1; Wed, 17 Jul 2024 14:59:42 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 17 Jul 2024 14:59:41 +0800 Subject: Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() To: Michal Hocko CC: , , , References: <20240716033516.606582-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Wed, 17 Jul 2024 14:59:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemd200019.china.huawei.com (7.221.188.193) X-Stat-Signature: fg6hd61f53h86wzew8kq1tiemrirgg96 X-Rspamd-Queue-Id: 5B194C0011 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721199586-544765 X-HE-Meta: U2FsdGVkX19l+MpLghyLp2LlOI71x5GMLIyvCwRKaAwbpwioUWYCp5fE3uRSJRmM5kHagSSMm3nZG0pDoH0IqCmqiVV8fCL1ghAP+ifVPxjAGgRXDvYz5nm1wsPWpN/JPT4MO6CTQqrotpXmpU+7UD4ijuB8Hgfz/qy5bS/Aup0IpUoHDj7kv+WLz4JD3z9kAVHY5dwm0tCaCRE35Jb4cQRmnqqwOZiLDMgRMnONOt/Ew1oEq7VL/zjcaNB2TFCKCaLgqVlKw3x6dzVhsShGWVSx9rSAQVa1ZVeO2QG/ZxKmjhVxpMm79LuZ+Q98qp/d2VRd68Hte9Gpsx9wfp9PUhkXw/r3gB5GZiYHB3dHK9YhROUVweKXzJECvkHziO6NSc+qe+uS2X9wYNHxRYbL0yqwmz+0V5zhVHHIq0zL3w86xAKDhsMbQrq3Zh8gLrbF12KKVAcygePvZHnHN50SdHfxapXFdT4RXdL5w4QKOn3qt1StY2xRW2RdsMgomg7gt5cOcr+tyEGtrMGD3GTRea0YHm3XcP06UJgtEjAibE9m/SPObM5ZTYC1CihFUmXEq3sLihADjaBXqYu2OUTrPaCJDXtITNiAWxfwXKUtPHxeUtSzJBrhcw9oFUtQf7hHDkamVOJ82TVdFlpfMWVwEX/swzWhkhNoBbbBr5jHE7UGSjYdoLbc6HKDwnFUZXxLHqngq2veMfBHreo+9+H6rDBmqebbCtey9+DttU8JKZHTptxmA9qHebCEPTeD9EkkFvamWbjKM5m0DVoXW1lsRR+x3/+zLOxoyGHBfToAnas/NHMgUrZn56HGix0p20I3lB8KU+4AJjwVP6UGXg0N5YTLncX8m2HwqallhFOoY9V1YNfEWJ5DWhMVwK+K/DRtqjiMof6UecbNg4Dt508XaTrs8JEFPDIsOZhoQHX89+BXN8vPnHu76+8aFIzxia7Et2eodHHdWblfJVoUR58 fvrdt4eb 9YCIRgbIIdXxk5iHVgjo6QSQLikHyO7mr5w39YeZ0IdUxhv+vgNGVONHe+xTFC4tRGZLoWqDe/9fPXo4Yg602gtBB1UEAoU2rZz9yjjAGKPDPcNWTJCaVYE5h90Vi4cW5Nwwq18CLXybpToqKBv3Dr61G/62e8hOa7+3sUqKS7TwVPphSdZVTQBCDG5BzXIE0tROnH5BYEa7LIOWzeuRhFDk4GFlJZIcihtOzUUq0cUQvWSllsaxyjRcQAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/17 14:18, Michal Hocko wrote: > On Wed 17-07-24 10:23:06, Miaohe Lin wrote: >> On 2024/7/16 16:38, Michal Hocko wrote: >>> On Tue 16-07-24 11:35:16, Miaohe Lin wrote: >>>> When hwpoison_inject module is removed, hwpoison_filter_* parameters >>>> should be reset. Otherwise these parameters will have non-default values >>>> at next insmod time. >>> >>> There is a clear layering broken here. We have mm/memory-failure.c using >>> values and mm/hwpoison-inject.c defining the values. Both with a >>> potentially different life time. Shouldn't that be fix instead? >> >> In fact, we have mm/memory-failure.c defining and using these values while they can >> only be modified through mm/hwpoison-inject.c from userspace. > > Yes, this is exactly what I mean by broken layering that should be > fixed. > >> The common usecase should be: >> >> 1. User set hwpoison filter parameters first through mm/hwpoison-inject.c. >> 2. Then doing memory hwpoison test through mm/hwpoison-inject.c. > > Why does this need to be done through different modules? Why it cannot > be part of the memory-filure.c? This is a bold idea for me. :) I think it can be part of the memory-filure.c. So CONFIG_HWPOISON_INJECT should be removed from the world and then make hwpoison-inject default on when MEMORY_FAILURE is configured? Thanks. .