From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C690C7EE39 for ; Mon, 30 Jun 2025 11:21:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 096016B00A1; Mon, 30 Jun 2025 07:21:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 046A86B00A3; Mon, 30 Jun 2025 07:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E50F26B00A6; Mon, 30 Jun 2025 07:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF8346B00A1 for ; Mon, 30 Jun 2025 07:21:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7DA2B59281 for ; Mon, 30 Jun 2025 11:21:26 +0000 (UTC) X-FDA: 83611826172.21.ED5533A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 0941E80005 for ; Mon, 30 Jun 2025 11:21:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cVLuXIu+; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751282484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GHq7d4kBQr5b6SaXfNxBCKaAAuq16nnAu0Xcwe1WZZU=; b=RnIxtzLkOgYJZzc5l3HUqHSgv6ujHIKYz5tJ1Kg7duSuO+xoTTwQSwp1S8/VqOfwddB63Q PuGCHDSlGom6hnAUxiEOld9sywIIAQzun63+KMzAPg2hO+HDLzRkOXDS0VLE0KU97T6/Od 5Wv8zCiapVkrxYFVnkRsvGdmAZvY7yQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751282484; a=rsa-sha256; cv=none; b=UNAfxsK/xvlm0Gz4yPbj75wdZRsMuGmasxDJxk1YZ2PXkSSopoi0J0sjxK8UxCopcXJX3M SOY/lrrjZ5Yky+7tWfZ8bhSmsdG4wFZv4rlV3Qq7R31LeBBaZc4oits4Fmvib8CIBk5zFm oUfq3UuG+oFZ3oyRu/tNI31vXsdJ5VY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cVLuXIu+; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751282483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GHq7d4kBQr5b6SaXfNxBCKaAAuq16nnAu0Xcwe1WZZU=; b=cVLuXIu+iAKEWaWA1hM+Wj8WkA+71rklzRhpMWQlC2Fz7ZK94kzbWSk3g2q1pcMi7jMV+V hrNZxOUZ/ZeSAz8EMkhZFEKkB4dbDzc5o60dH3R9L3scpYgWjtvWQEydl2OACi0Xv0FapA MFiH8hyM53FAKFpKedb5G1hjNXLGMdo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-0HwQ3zD3MJOCaG9zbW666g-1; Mon, 30 Jun 2025 07:21:22 -0400 X-MC-Unique: 0HwQ3zD3MJOCaG9zbW666g-1 X-Mimecast-MFC-AGG-ID: 0HwQ3zD3MJOCaG9zbW666g_1751282481 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so2143846f8f.2 for ; Mon, 30 Jun 2025 04:21:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751282481; x=1751887281; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GHq7d4kBQr5b6SaXfNxBCKaAAuq16nnAu0Xcwe1WZZU=; b=I2s6jA27ZW5xcAnDOZIUB+/FDMdMic863pUOUXZ4+HpJSY2PlmuJuuNdngha6bzaXx nFb1oYKwTfTvmt79oOuuscacfM9hf0+CKGIBtre6f2ETduLmV0LbxxTnPK+COaNUlqMH yq54Gfu47tVvg6wTJmtTZJNJeweBlhT+PS6vGnXXs9kixT9rv78OkMCxT0nAnqRq4dt2 EVXWGD0IhJ5ynr+Cpx3qIxQSl4ds/k9ABehrg/LJQE6eP8G6fNDFbrwlWYSDhKGykrHM W6nAqiQNiHB/Dpl/bC07bq67LMcFOXGKO57DQkPaWnHaVdeNGQRZlzz1y0ERg04Ot6LM 0g0Q== X-Forwarded-Encrypted: i=1; AJvYcCVZ59IGnshOdEEXXQ50gKehIzLeOA7xqyFMEd4YL/7a9JjoCHJecVU2mkJoZVTFtg4yzxceNVjnGA==@kvack.org X-Gm-Message-State: AOJu0Yw98FyeFviHyLONUuvHaczQRbSUsd7LTsaQRZyudxnUyM+U90+i A8BaiinzKdsVfN1O8yi1uRlPAzc+0pVm17zwzH4eRiS+68J3XXJNhTobCo7WIva44uqZv5yG+K/ +ZP9nlDBx5/RT/UwC+OjdyUmRPQ41fJW2fn+Yd4XfM7JF43TiUYZJ X-Gm-Gg: ASbGncv3EHp/nfieatCiCM72bl/u3qLyxpKWhPqYR8EK40psdvRIK52TzREc8L/Ky29 KaE0rEZvqntg6etra27pq0lFBvDF8JjF4y+spSJ6DajlT+1mjgKgWBoAaEoJakpBZKxXzTTscoo XnSGrKaQcrgyMQZT+S0fsabLVwQi7e+rtymEFG7Y3YG1VAEhGPC9yfCuOrud/Mr4mGj8/Prw3Xt hZDD/7fCuOdkGd9c7KlXTUUETRtIH/YJp75b2RX4kDbdjoThX6RWbG1+WCvLkJOYxLjCDSSx8Gw 2wnUGL7KRsSsDOAc7Xk+R6+izSA1RKdKhbrpog34P47uT6YTt44pCfqlbZ98PS2OBEE7L/INT4T PyMMYd+2t+nipostMejpahw2lY/C6LyN/gYT2Svy6Eg3RckzVWw== X-Received: by 2002:a05:6000:40ca:b0:3a4:c2e4:11b with SMTP id ffacd0b85a97d-3a90bba887fmr10737972f8f.51.1751282480705; Mon, 30 Jun 2025 04:21:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGha/FbwoUKKz1dKbhvLWpIEOwiWlylTo4MrTOZr74+kyRGbAsp4CVpch9K5kNJYsqrHjsrnQ== X-Received: by 2002:a05:6000:40ca:b0:3a4:c2e4:11b with SMTP id ffacd0b85a97d-3a90bba887fmr10737924f8f.51.1751282480253; Mon, 30 Jun 2025 04:21:20 -0700 (PDT) Received: from ?IPV6:2003:d8:2f40:b300:53f7:d260:aff4:7256? (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e595c6sm10400813f8f.66.2025.06.30.04.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 04:21:19 -0700 (PDT) Message-ID: Date: Mon, 30 Jun 2025 13:21:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-5-david@redhat.com> <997a3af4-0c8f-4f8d-8230-08b43d0761b6@redhat.com> <4500541c-dde1-41a7-81c8-ac1573d05419@lucifer.local> <5513d9ba-80bf-49a1-9a50-e1a6814925e7@redhat.com> <428257a9-439f-43a5-8590-4de83d45e185@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <428257a9-439f-43a5-8590-4de83d45e185@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SAGVK-bHOwRTox6D4JgohvWhsdLbe_4F9xReF665Lcs_1751282481 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0941E80005 X-Stat-Signature: ujhu485bxfw7nua5wbwfdtszjhpyepfs X-HE-Tag: 1751282483-558450 X-HE-Meta: U2FsdGVkX18/imTAP4PCV6lK4rAqp5Psd6pTRw2arwNTD2rwbi+16ty/jcFpuOUEOcYSNyKI5Pmppq9wvPAQJ9ag2mHTthtm0X8rgzVRzTwbHWetGy7ajm5fV+0N8sTLoH1ANQshMuqJqW9lv8dRn2x67anG8AfvUGeGjPwRngveQhwk/CfuI3Z67IF5Jp8KkUpBIznghyafy+S8dtCxCYwbKFHYBw5T5ofHozZANmL4DqZx6Wu+hStgBCWzaLBTlC5vSUF/iJBMGpyzt6VJ6U5D/ItgbAQIr5QS4P8e3EQbTXuYIPtROCKZblLZXV4LOH0f+4aR8zlxOzOlaCSeUFjeOU0uSv/d3hcYp++GbZ5Yu6zLqO02smDS2uGGWhWjTkCSy9k06NuJgQpt9zi5f7LY3iYW899DpGYfMnInFtEXWRuHDdbUYzFXBMiA2TieQHVJ5BCmczMZ8ONj8q10TDXDZTW4c4japtAOsJ1yvrRJ7csHOONR/ZAYIf4M3Az0SXHwfZfTRvZmSgHg18D8BV2PIrzUuApA0/ZF5diVFhwE1Ao0A8a5ukO9HkRewsE7+dkh1RqMQYhZSciP2Z0u6XONkK2T8g1IF+ymxjkbytaKcsYNfgMQ4sqRNvB0aXvcVUbWDmFryUqomaMh2jhHJ5/fLC2dIQ1ryJvblAgwYEsuYYoeU5sJpKcEe2DSYOhFqZNiS7S6T/NM2wsmgv4VqfraJovs+d5NRJXd3zHvub3rFldjhNEkb13XKsbiZGda1/vx7zQAYvOJ+q+9NmwhzeNOwAtMn/0j5PKNV4bcN86YhibunugoGHpVE7K9yAU7wizZ3IyWkjCzEzHgutD0y8KxZa6B/b7e5D3yvisV9JYL3lITb/PrRxPRcN98ayYqsY8agy9AipN0vm9+5YfilP1fW8n555Vv472Tkt251VN7CNZtzqui7lFGinsJZGj8aqufpFUAxwc+84ihGKT b+DKkrU+ Ubc9q6Nsgn5LmF1a1360xK+t2YJxyOCASmaoJ0YfK1O7XtkSrNCd8Qg/hY4KulqkGXpyx73lUcMIifmK4omxoWDVk3htLBKBDgCLp8QAhfw1F052tQqNDxJeefLhz7+Kcg+EI6U1bfBTno89CGnj23iORu7rXErWngKSTMZIdTDv/PbWfCw1ayXTi24i9hXMfVtUz6myjR10bD0n0RFW8/tjgIcN1/NqlrMbxD4x7O74bGfK5QpRojswOTvfpD5ToCG4QVqSKOoTwotTcMzwMmfdieZP4+tPHzeVHaJn2+7HbXFsVRU8AorwW9Awgu6X382L8FCqyNxaOT6Fy6hPLdqPzVpkg+L7yfIgKcUKrK7juMb2sWuUqZ2I21/1rAa5u/EjM2tYmhz93NAXCsYCsbdNyrzYWpSPYGG1LItadbmmLZXbklXTFXQYyta3J6DLpFlwVLqIF7qUtvmXfh0mj7+SNVZwnnClBROjbJITHKhkl3aElwuFd9QnyvfP2uzCKuteDFjThfoJoRZ2oW17RoxVJ0Eq/gv/57pOyByTlOS6HB25BkI4MyNGD+WZ2ZanqGmF87ML4RDAbPKY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.25 13:18, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 01:16:52PM +0200, David Hildenbrand wrote: >> >>> >>> @ptentp: Pointer to a COPY of the first page table entry whose flags we update >>> if appropriate. >> >> + * @ptentp: Pointer to a COPY of the first page table entry whose flags this >> + * function updates based on @flags if appropriate. >> >> >>> >>> And then update the description of folio_pte_batch_flags() both the brief one to >>> add 'updates ptentp to set flags if appropriate' and maybe in the larger >>> description bit. >> >> Not in the brief one; the other description, including the excessive parameter doc >> will be enough. > > That works for me! Let's not hold this up on trivia. > >> >> FWIW, I briefly though passing in an arg struct, or returning the pte instead (and returning >> the nr_pages using a parameter), but hated both. More than these two stupid pte*. > > Well I love help structs bro so you know I'd love that ;) Yeah, I was more annoyed by a possible the folio_pte_batch() vs. folio_pte_batch_ext /_flags() inconsistency. I'll think about this once more ... :) -- Cheers, David / dhildenb