From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE52C5AE59 for ; Thu, 5 Jun 2025 17:19:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A0A16B00B8; Thu, 5 Jun 2025 13:19:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1519C6B00BA; Thu, 5 Jun 2025 13:19:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08EC86B00BC; Thu, 5 Jun 2025 13:19:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DFFDA6B00B8 for ; Thu, 5 Jun 2025 13:19:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8AB0FBEA4A for ; Thu, 5 Jun 2025 17:19:07 +0000 (UTC) X-FDA: 83522007534.19.8585C4A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf09.hostedemail.com (Postfix) with ESMTP id 05C4B140006 for ; Thu, 5 Jun 2025 17:19:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="N/Or4xx9"; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749143946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BViz5ib6cM/BfKosRZTWKCe4FEnQDwFbKpc6YKdrRS8=; b=afXik/yHxBKK6+sKdyAfUYUB3Ps60NelVdH9BthSebQRV+j+jybbiD2TbThPIiHgAo3uCr YHowtZgSOWt9hwQ/2u/M5PgtIlqUvGm23xKnUtyUi913UfvvokT9Xorz11VL/3ZPmKXYW8 NPbVmw9NUa9O7wQxCeTbUSyrC/EBZEE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="N/Or4xx9"; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749143946; a=rsa-sha256; cv=none; b=bKqGduUdYUnMN2nR+QZsYiHyFTeKAMawjMQNx0RzH6SNz1hriufoxcnot+Osou+d2NjUZu JxuBEYmWA5Uu3A4Yzrvw1Udr7kktvzLi7QE7F3jZD/7q0hIr4FAYtq7VWkwSfPu+E5WLWT YPprJDqFJOIOmbRPLXCrkzccUHfaMAc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 21EF7614B8; Thu, 5 Jun 2025 17:19:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BB5FC4CEE7; Thu, 5 Jun 2025 17:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749143944; bh=xCg9FEDKTtf3vgEKMxIzLSqhN3C9kcE2FIyIYFBrXO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N/Or4xx9tvbtr9+eiQwdd6CVnIQNajAKUUJYDj6KC5xhn2BBiftLbYl16k1QvKqhP ZMmcd1+CW7EEBd1yXWLiDYjt1To5AbFcX07xfA84hgTaDIpEroHuqDSqsQNZawJfi4 +1wEgHha4pMQLPXuVPFr5cYFuqpw2+Vsr3lmI5D9dPMhFWJvNjUawjZsrtgIzFxHUh CHxnV9Yyf/SC3dENM+XsHdSwUCgn8hz8RN386uf4gpqoyT4pGLHnv9CWDEMMZqjQwS A0IKfKRjEGzvbzEGz0HhmnNikyXgDrKbbAqJVpGZIkZqIW3XiRdWXV+fJXgjjYhmoE kRA6kVpBBevkg== Date: Thu, 5 Jun 2025 18:19:00 +0100 From: Mark Brown To: David Hildenbrand Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm Message-ID: References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> <722628a8-f3fd-4fb9-ae04-2313a52ffb36@sirena.org.uk> <66db3d9e-73a6-4fcd-8abd-db65cfff49ab@lucifer.local> <661fc4ce-839f-4c47-bc3a-0c864e846324@sirena.org.uk> <077b6af0-bef3-4f1f-b785-9e351d01a89f@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xgLCgah/58nynGKp" Content-Disposition: inline In-Reply-To: <077b6af0-bef3-4f1f-b785-9e351d01a89f@redhat.com> X-Cookie: That's no moon... X-Stat-Signature: hst75gy8fq5i1q7zy8tb4nxhc48y5zhe X-Rspamd-Queue-Id: 05C4B140006 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749143945-397061 X-HE-Meta: U2FsdGVkX18NL0Iz7EFsOAP3IOw0rcmuMpcjjuFPmtDo0E1rMM9ClsWL7mHa/+E7PXdvmESRZFnEosljfVFAldfIPKsqJYu6lHidLFI5SyqIjDpXfMGkb1FVl9z28kT1JJNYX+WPKuSpiO+rdLllMsm6qiu4sZa6kPq+KX0eumlqRY2kmJoBKgvtH32kbpGA7+X8MnIZ/ggmWXThCwX7QNukio2R77quFMPbCoDJxz88UCdFdVX/4h/guB74cS2YQdSYkh2ylUTWxWfvqpT/FXbL3mkEo7nToKnuWvM+iIZYTQcymf5OxwgFNeybis44bKmuoymXzLkue7C9J2tLUd0fBZiAVKvhKStSOjM0hX6/O8+cn+R7c5O48Qphi7Grq/mhvbZ95ivs1+XqAyfC1m0BIwJ8AqieN9pMbU2eRKKc8ZanIvDoKiBdRcmrEvL0D9wd0pRMMOcOzQTY8iJ1cajhSS7OmSIjfO69Fihh3Bkx1jU9LzhhhEA++GROwBxZ58SiQM9toO9/Sg0reQbWDLSp2WeU4YTGueWE85Y+YyQ+BYptwFAz68vcTMbwTNCwQk9P8YXYYfvKDsp0Ah0c6q0NJJRllaZJyp65+HpmL8F5Xo4KP4HTzOCb+kcxSmSG+O7Z3q1V4JRWtBu/MwDpsYLgSab1KgWcuZvg/8ggOvFAgivFEcWAzYkXuEOU1S6Yh87DyHK4ox1d4kyKGXf2KtDrkIk5hIGS4UhIiAeCZ7lR5NOGIaECn2VVas4VLeay+ulqxMJr04MbSOkqrKwNX2rN84G9qfcdSSwAIAXygD7OIU3uNctBKopoSpX0+XW1jAbjPDKx1l8I3M2K5ckNZNYH7Jg1FgOByu2spy3ZY1EgBW1/KKOPdU0R2W3OPg0Jbkz4cFtShS8JXo8unEStNQHkLCRlAJnyLZzE66qa3jYLzfdq2ROGVvQ3X24do28gVHh4mvGERIyIeWVB6eB 0X2kWExL jH8rsnU45ks4vTq07vHRtcfkw9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --xgLCgah/58nynGKp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 05, 2025 at 06:55:53PM +0200, David Hildenbrand wrote: > On 05.06.25 18:42, Mark Brown wrote: > > I can't remember off hand, sorry. > I assume in ... my review to patch #4? Oh, yeah - it's there. I did look there but the "not a fan" bit made me think it was one of the stylistic things as I quickly scanned through. > What an unpleasant upstream experience. TBH this has been a lot better than the more common failure mode with working on selftests where people just completely ignore or are openly dismissive about them :/ . Probably room for a middle ground though. --xgLCgah/58nynGKp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmhB0YMACgkQJNaLcl1U h9BK5Qf/fpHXvEbHQRvJzqX8a/QCO94vPB2OwXy8cSOSokQohN3ZULM13g+tnQw2 5BJmHheHkQlqu8VykO3C8BbWyAmR6anJAOeAYaQOPH7itzqrSNnhsoI8pylVPhgK hiYQ8jmIcRkdHPfachihGaHmmrAvF8xZDtRUITnL75f3YlwOmAy+uh1Zj11clYqL mXQZEopwVJWi0DGJyfCFBiMrda86ck9da0KhBDMh0b1vHw9xKOBZpt6Ukt/gsVAh zJXj4R1OnanUjhrxSKuDppSwbSSHGzic6f7LY6WSg4Kno06t0RHPED6vxBGvY++N D00VBYOYo/23HOGZJ3NHG8f8xAajSg== =YRar -----END PGP SIGNATURE----- --xgLCgah/58nynGKp--