From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1233C3ABC3 for ; Tue, 13 May 2025 10:40:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBB926B00B8; Tue, 13 May 2025 06:40:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D41876B00D3; Tue, 13 May 2025 06:40:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6DF26B00D4; Tue, 13 May 2025 06:40:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9163D6B00B8 for ; Tue, 13 May 2025 06:40:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D9FA114031F for ; Tue, 13 May 2025 10:40:04 +0000 (UTC) X-FDA: 83437539528.14.3CCD5BF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 677E94000A for ; Tue, 13 May 2025 10:40:02 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BRfR+8ok; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EPZMvxDK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BRfR+8ok; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EPZMvxDK; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747132802; a=rsa-sha256; cv=none; b=vPqGk0aRYimBDh88tRF5u1RbWx4EdjF+dfQ7Pcw9N58Yk9XCnHZbW2A9z9gtTY+rTrmWY3 ZIEja1+D4P2LPJKUPaWfSU/A++eIXJilW2gaVXeDmz41wda6/0cTdzbYRH41/m+lS4CCwV e45qrKTrWcjbJJc7ZMPI4Z7QtP8x02A= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BRfR+8ok; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EPZMvxDK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BRfR+8ok; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EPZMvxDK; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747132802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oyl6ikRgcExL5pzSCPRicYoK/SSI4/2yziLBcvu9oRo=; b=Z2M6qoDwchiDOF4Lt+75yP/0GPCdX7sdLEpYpxZNgAyoS7HlCCkP6u/mWu/kvqFDijJXXv L7n0A9+T6ugOXkauw9Sq8vYeZiFz+6LYvDFc3y/RJyJmKJnADH5rc0CwBPvVrBqfg+I47S y1BmyR+qDmfh/m6R/35poJ0lOI3J/b4= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 00D5421197; Tue, 13 May 2025 10:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747132801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oyl6ikRgcExL5pzSCPRicYoK/SSI4/2yziLBcvu9oRo=; b=BRfR+8okXd2l18KkyfpqZxh/vnpEu1Bl1LgGjgW+Rgd7ppHNa3tGd6cUyuS8zJY6B8Pgmx GndbG3GfbSObsSwA1q+a4VRvpsqudw35hrHclJLG+XH2rvuRw4k48e+p/euLV5Qdn8RNw5 +QT5u3k3uBDNzNrPUUC5qLK2xeFm0zc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747132801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oyl6ikRgcExL5pzSCPRicYoK/SSI4/2yziLBcvu9oRo=; b=EPZMvxDKyOnVnXBsttjlE584g5Yt4rVvf+V8ZaFPi9vi3zo7FdPrUgEaH5f1xxxWJ6bgVd uDWPEQCnbrM/CHAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747132801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oyl6ikRgcExL5pzSCPRicYoK/SSI4/2yziLBcvu9oRo=; b=BRfR+8okXd2l18KkyfpqZxh/vnpEu1Bl1LgGjgW+Rgd7ppHNa3tGd6cUyuS8zJY6B8Pgmx GndbG3GfbSObsSwA1q+a4VRvpsqudw35hrHclJLG+XH2rvuRw4k48e+p/euLV5Qdn8RNw5 +QT5u3k3uBDNzNrPUUC5qLK2xeFm0zc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747132801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oyl6ikRgcExL5pzSCPRicYoK/SSI4/2yziLBcvu9oRo=; b=EPZMvxDKyOnVnXBsttjlE584g5Yt4rVvf+V8ZaFPi9vi3zo7FdPrUgEaH5f1xxxWJ6bgVd uDWPEQCnbrM/CHAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D4D66137E8; Tue, 13 May 2025 10:40:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yN2hM4AhI2hbIQAAD6G6ig (envelope-from ); Tue, 13 May 2025 10:40:00 +0000 Message-ID: Date: Tue, 13 May 2025 12:40:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 5/7] memcg: make __mod_memcg_lruvec_state re-entrant safe against irqs Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250513031316.2147548-1-shakeel.butt@linux.dev> <20250513031316.2147548-6-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250513031316.2147548-6-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 677E94000A X-Stat-Signature: fgynqfwdkefpw1fx6ne6dt89e5k6w9r3 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1747132802-121340 X-HE-Meta: U2FsdGVkX19OZ5Xbky7CPv1n40/d+JFRGSMZzvf4GRwZprChb5pcCWX+veL1ZyVRQLJCG7UkMiq7Xi83N2/Sf3B4+deK2osWnSjP3p5+4oSG37Udn0ryScyOMcoSBRONDZW4/k+UY/DOKiavlJCX1LCyaUzP1dqfh+5+cwkJacU61SCyWyvZ2edkweQ98dy4dx69qC+IETxFG73HGsSm2sqSeQafcUYQ1N79HYCukzTpN92oXZhLpLjwHDpskrPtEXOAj7n7qoEfFAySCnHtqKqPLSvZObodOkQP0EYpMIa7eG4Xpqc4/XkYZpmNZp+X11naPk5X8cYRfhjPJqAwjwoKtYIgFQUMnrco3xU0Fem3xRTz1qzVOAFlUD+1WWpL3e0uDisBNTM7ZhUfQ4VCPOiO/3h5DMZZmrHr34kyKFqnqd2UhTcVFDrGnnnkaXA9lMDDGGRgcjRjCnvXUXHUhwAclfQ1tuC9quCgNKAx4nOcN7fYSJfESk5mzmR9ynoAxQQSlV9OE5wn4uDhx/kKF6JEmiTao8KszKwm6C11q7J3sK9LVj4p5MT2ewS4mBjhArEnta2VsVATZIO2vUlnOwuVFemC4RsgZ/27b7yhGznO+nmPyuXhkQszEbo5nq52IJwnBu95/MynfWUGWM5onQfoPyHF6rbpJb8Q8JIPF1ImXBQRSogZDb5qo3MeEuwQ0sm89b2MHIBHDsO7lNpc931vf4yzkvEwf/r2YjCRtAv6c1LBDljoUQQ1pM8Rk1hOy+5fsHbgjQDLZpCxemGqRTNPasDwftP1PwGGkSOmA04XlNujVROXWSNxbAAJNUrKF+cBTFYc6ZUK321W6zwYpLtMhTj28y+/T8Nfz2730kQqhu1KSDZNDw8pwCsUadOY5bKVnStzBR5LHQSeuBMW5KiXd69fqtg8gfA7XhosAoi5V64MNGzyYf9/tktKk5sbijjT/HGKmcjGOl7rFJR +WYxnH4n sZBsFzPFgwFacgv7tF4V4Ggqmv3xqGGufPObGB/moQfRmnuOrdjq9l6dg1xGCp7ovObbh7kHzJf6Fpx3QxRwZBhtQePnfpclAYzDjMhVpIExq5we5xqie9Ww6PjMNdr0UTmjuERO7CFf8O/cyScPo9A5D2cwjsLcyXJfZ14RcVbpB4/EF1jSHsRwgkkDXE5TY8bn09XApHkc52Q3om8WpiM4fc0wk8vujliJK1N9fe5ZIcfOhu7hreG4luXl5e5C/3zLs+x1CQjJ+0lsLtq7KJm3n3qRyO88UpxEN6Tfc3e/MeOuJkRYG4m6N1KQlxWVBWe1MWLWr2ba0XyU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/13/25 05:13, Shakeel Butt wrote: > Let's make __mod_memcg_lruvec_state re-entrant safe and name it > mod_memcg_lruvec_state(). The only thing needed is to convert the usage > of __this_cpu_add() to this_cpu_add(). There are two callers of > mod_memcg_lruvec_state() and one of them i.e. __mod_objcg_mlstate() will > be re-entrant safe as well, so, rename it mod_objcg_mlstate(). The last > caller __mod_lruvec_state() still calls __mod_node_page_state() which is > not re-entrant safe yet, so keep it as is. > > Signed-off-by: Shakeel Butt Acked-by: Vlastimil Babka