From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB0FC43217 for ; Fri, 21 Oct 2022 06:55:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C3DB8E0002; Fri, 21 Oct 2022 02:55:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 773B38E0001; Fri, 21 Oct 2022 02:55:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63B7B8E0002; Fri, 21 Oct 2022 02:55:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 520668E0001 for ; Fri, 21 Oct 2022 02:55:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 05E381602DF for ; Fri, 21 Oct 2022 06:55:04 +0000 (UTC) X-FDA: 80044044528.15.EC95BD6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 83E65180019 for ; Fri, 21 Oct 2022 06:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666335302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azbR1iYqZdjkLxcnJ4PM0CwNs7s9IcYhQ0EBbhWLuQQ=; b=LSi+Kb/j5doktBBTi0YAyl4p/zH4GEGbzHNyEg2yD/Ai6z7L1KNpdLa7fgUCzEzcFGHhjP 4GM9wYGfXA4IDw7VTPfontTMl1vsqxXtI28lwY5laz7iljsdctTY3CXE3i3J3NyXadUM8X 17l4tx8Tj/XPBT2c39YONktNj1jv3XA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-176-BayVnCghM-eNolxb2vhIyw-1; Fri, 21 Oct 2022 02:54:59 -0400 X-MC-Unique: BayVnCghM-eNolxb2vhIyw-1 Received: by mail-wr1-f69.google.com with SMTP id d23-20020adfa417000000b002364a31b7c9so475465wra.15 for ; Thu, 20 Oct 2022 23:54:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=azbR1iYqZdjkLxcnJ4PM0CwNs7s9IcYhQ0EBbhWLuQQ=; b=f9KCJwRDzBgejOIuSUAQ1lRC+Sn02v+CfTepPwOtGRc5YkQxoKS/BWugbIk46fYXVp 0w1Y2ezjmskenofGQjWxlOMlXMqDBRI4PF8c2l/kC9guypw2MXzVVQIkG7AL4XapacG5 P4n4/pKMLYZ+MRogXvvXCA+W0VVHre+7XCaKrDIzdurm1QNqUfSfQwlkqQgaScRfcB6J HZ81gS3xj5MXWb4ZvKQwvFJZ9OTdKSfGdmWmM+BIlrKLF0WNE8B+rFIRjwn6+nvhDQUN 3dPgBqd4AEMKocKOWH2Un+veZdUzYUFAq4ac/Ca8aUUxcGJE4FUDAwx3gRR6eohb61+5 L0wg== X-Gm-Message-State: ACrzQf1oSsj9VI89cUsa8evGkAB00cqh1XfsgcsBixsMtvKoxNum0Adn XfnwNGUebfnsGsc7qVzXqIqGplPcv69c6iPDwlRUdSZG5FM5CA/+jopR6P53cB9ikR3LSwg0oq4 dHgLk0deVbVI= X-Received: by 2002:a05:6000:1051:b0:22e:5d8a:d3d5 with SMTP id c17-20020a056000105100b0022e5d8ad3d5mr11029994wrx.476.1666335298293; Thu, 20 Oct 2022 23:54:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7nywPHwEgg407aCL0VBvl6j32KpgwSPv03Ps5WxcZoWqv+Aab1gImv2W/IVSJenOEhTVywYQ== X-Received: by 2002:a05:6000:1051:b0:22e:5d8a:d3d5 with SMTP id c17-20020a056000105100b0022e5d8ad3d5mr11029980wrx.476.1666335298017; Thu, 20 Oct 2022 23:54:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:1700:e40d:574c:c991:5f78? (p200300cbc7081700e40d574cc9915f78.dip0.t-ipconnect.de. [2003:cb:c708:1700:e40d:574c:c991:5f78]) by smtp.gmail.com with ESMTPSA id bv16-20020a0560001f1000b0022e6f0d0d7csm21744709wrb.18.2022.10.20.23.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 23:54:57 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 08:54:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning To: Maria Yu , akpm@linux-foundation.org, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: mike.kravetz@oracle.com, opendmb@gmail.com References: <20221021051936.15346-1-quic_aiquny@quicinc.com> <20221021051936.15346-2-quic_aiquny@quicinc.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221021051936.15346-2-quic_aiquny@quicinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666335303; a=rsa-sha256; cv=none; b=mJhGzKUbfXKBQf5WMoxC6+jRpqX4D/do8rBOqnyuoSkHg2lkSuj3WV+rNBbaBZQL+7E9gV 4fc3d7HKcVbJmaqlHcYchu+5LwZ9DfhRFNqZBFqExZK8AhC/27KI+RO0TfZ+4T/lYDNcnL mPkp3+pUrjxTsqUCi3RMyKZUMpG+iJE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LSi+Kb/j"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666335303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=azbR1iYqZdjkLxcnJ4PM0CwNs7s9IcYhQ0EBbhWLuQQ=; b=KmjL3StekiyXCXuKrmYQZRUehtwnruk2/ZVND5U8XxIvOCyz0k0EXuAEBNWncWcJymSHVQ cOx1xNI+/s4tib+S/+4qta7Ffjm6a34pGsllEaP380SRoJO3/2VuZ27pVWj6Cw+Dyn/2j6 R/TQeWaZGEHZCWnO6lr83ELvQ21HEuM= X-Stat-Signature: yffejb9drz1qjqndqukf7ixcti6hu7p8 X-Rspamd-Queue-Id: 83E65180019 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LSi+Kb/j"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666335303-796907 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.10.22 07:19, Maria Yu wrote: > When !CONFIG_VM_BUG_ON, there is warning of > clang-analyzer-deadcode.DeadStores: > Value stored to 'mt' during its initialization > is never read. > > Signed-off-by: Maria Yu > --- > mm/page_isolation.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 04141a9bea70..a7a478a22123 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -330,9 +330,8 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, > zone->zone_start_pfn); > > if (skip_isolation) { > - int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock)); __maybe_unused should work as well. Was that considered? -- Thanks, David / dhildenb