From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194F6EB64DD for ; Sun, 30 Jul 2023 22:28:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4748C28000B; Sun, 30 Jul 2023 18:28:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42D99280006; Sun, 30 Jul 2023 18:28:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EBD528000B; Sun, 30 Jul 2023 18:28:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1AC10280006 for ; Sun, 30 Jul 2023 18:28:57 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CAC41B16AB for ; Sun, 30 Jul 2023 22:28:56 +0000 (UTC) X-FDA: 81069719472.07.6920D37 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf24.hostedemail.com (Postfix) with ESMTP id F00E2180010 for ; Sun, 30 Jul 2023 22:28:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YzB1thtM; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf24.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690756134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KZRFFoPcrSqd2GFBZXJZF1g0vixMajlncvKykQWDSkY=; b=1tYvsWd9kejga6P5CQVWjD0/RGcffAW7ZEPLcEOJP3cUmDAEwjJW0/WttrkasvlL9/TyJn /vDQgeQZPa8/kmbV065u+uoT+gkbXUCCsEx30ZGSY8UDP5Nsd1tSHxEk9Rjuw4N2t9V8+8 jEzIi7TLvLcJiBcfXTJkbmi2pBzVYjY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YzB1thtM; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf24.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690756134; a=rsa-sha256; cv=none; b=tSbh6PFlPdxpjQBFkIcvKiJGpiC0FqqqEfqkOSV48zP8Lap9L5UP23ggJtWX1yRx9wp5sH 8qosPrUwdT/9pObN3DS923XE+0vVuoh4+MFmCydvcIqFIqHaeK/0VT5Siy4uqahhsQtmfn 4RDYWE+cXUmem6smAFwfnUJNpjfcIsI= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3fbab0d0b88so34175015e9.0 for ; Sun, 30 Jul 2023 15:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690756132; x=1691360932; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KZRFFoPcrSqd2GFBZXJZF1g0vixMajlncvKykQWDSkY=; b=YzB1thtMpuJiI1xsxQuVURjrMrRw5vcT/6Dyyglz/ZbnFidLcqiOnSizY540mInsfM T8rwx0+kRebLNuQjZJWcx1P8d2UqUIDEM22G2B34P8iCZoikdYG1PnmyplNFJjQTswqG TcdoJA83ZcS7t0X5uiaphV7UwflSJKhJQQaJpIR9TWQeSjZ/mVn0nHG1zaP9f04EmFkb xRl9KpftnIE6VKFlY908Oa+/ZhuwVmI7Zhdplb7gCa8bJTprmBXKW/xiduITrncFAijc FOOHlwMhxIflul4kHSgPp2r+G+Wg6zncPqYh/c8iYeaJyRjIwYhWqOxoMzV33HWVlOJH 8LZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690756132; x=1691360932; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KZRFFoPcrSqd2GFBZXJZF1g0vixMajlncvKykQWDSkY=; b=Ja0Te7nFmWcZtsVcJLwsKHbWJHzNj1550/iiB94eoGcVKaagGT+/zB/8i1oJYmkju+ YO7UIFLWIS67IPGDap/y5MJZ6hPXcW6VmULN1xHfxdk5lhtWZKqD1By9uQ2+uOdqxmsY QBYNr+eH+EdeaVIqBgh8ls9iNjLVoU8dHBC/HDGJsYbJUWfJm3TwfeVEoLjBuXvg7H56 FWf1rSL+gi0ZOCa8d1PnCTXH68bpvYTf3HvUqv7NcPyI0pPs2nWd/QvOVxddHIUPUyOT l+KKZj1bvpNeIW5tp4bpmPZplCSdfYt3l1PXY9curvR7iQcfiwlz6VWRElBrQQW74qDq Jexw== X-Gm-Message-State: ABy/qLbLRUBemEosJdaK+PLHkoFqzNZ3MEqovB/sU+YT3jw4z4N/MKf5 TvaIBEJM1owl6gfD4rBrruHTqZugcBgEHFskM5o= X-Google-Smtp-Source: APBJJlG/YsFGRjLOglbrshFMlFn9hDKFjCnmZwdnmkb8yJ706MwEXRG84bNhu+tyayk6Yzs6C0UF/w== X-Received: by 2002:a5d:6686:0:b0:317:6220:ac0d with SMTP id l6-20020a5d6686000000b003176220ac0dmr6617400wru.1.1690756131769; Sun, 30 Jul 2023 15:28:51 -0700 (PDT) Received: from ?IPV6:2a02:6b6a:b465:0:eda5:aa63:ce24:dac2? ([2a02:6b6a:b465:0:eda5:aa63:ce24:dac2]) by smtp.gmail.com with ESMTPSA id j4-20020a5d6184000000b003142c85fbcdsm11094522wru.11.2023.07.30.15.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jul 2023 15:28:51 -0700 (PDT) Message-ID: Date: Sun, 30 Jul 2023 23:28:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [v2 0/6] mm/memblock: Skip prep and initialization of struct pages freed later by HVO Content-Language: en-US To: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com References: <20230730151606.2871391-1-usama.arif@bytedance.com> From: Usama Arif In-Reply-To: <20230730151606.2871391-1-usama.arif@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F00E2180010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 61ioxqaohg1qbdwfx1ynd9nfqfujxiia X-HE-Tag: 1690756133-848040 X-HE-Meta: U2FsdGVkX19r8cim27KtcDvuYCwuAvCNqKVg668sYgSUZedfpiKe+4GqpYd0VMvWdqzD5ZVjtgZ/+ZvNEWSGlC3EW/yLMRPryJvnVwDqgXUIrJS1UqaOBpyEX/fSY2nBqMG1SRDXstA053ZSCVe/xxZF9M8NR8DnPrkPQv0Zegs/kR5AzA5eSEhtNjYMw9gnMsQ1z5W+i29f/uztyvO65x6MbikNMMggkkshmL+QvmsTLbiaIECz92H/FlOWHWJ32xPgdr6ZQjSfAhn+pkdLsAz4T3gCzuNGFM5y52UYdzxol+aErhEzeLycfS2J0USaZmrmAQGpZmO8oC2hiANGjl0GOHTNMyTq9G7FJV66eT5OBJshxCC7kOUTmgsWjrO0zUYXyAVlxTU2iVOh5YDg1O5zFMX7mZwzuBbg0FlqLklYAxsIDO96To3utQoW3hAijViuec/0UvskmeIYyXcTMPGhEnQCEsq0YeyabnV/rQ3F24Q64eRS9Y07F9eSm5mCauHDeO4g6KMihdoQFd9DToKmip4hSjWZmEmJxoVJhLCNDiTcbkIzqv9YHpAc0MI5UfkE0R06CAb20nkaHMNKae/hpGIxlfHMWJ3ltn8Y5+YOoIFZkcL+GmYOkUeGfKml+StmUJOnspu7+hncnP7p6RHa7q7o0pe07qudni/ePmVll3YWtuZBWSRje9nFtpUt+QH32L7ROaVFBy0MHJMBBkh9PTeX/YWEaSTJaoxQwiW7FrXjlw6FU4haE9ZYIWauR5j85JOZJcbIf4sjqJ9EKIOM51af0KUwCUB2UNYP+Df314LJyk7fKSttoa3E/y6xogiWGxMDN9CI+q9xrI0jiyzwb/pG3NPQUZ9PBeMdzkcGk4N4dmKpxFsDHo6lg+tqQEt09+Rnr7p1DJrKjbHlnTDDiFqt2Za/33Jn8/L7kraN2U627kghG16clLKvLM3z7oFTZIdPZAm/hyKiLDy 4tQuxjOk 9njtPsbjGiNloE/r93C2CfvKI07NlSYk7rsEwWTQ6HKjekxUWvvp/XPLSM7Qn37Ako8sFTXSEfkD25RWUujSnKkNgjm2EEprM+OM+J/FcyhMg1JGAlQ7DBS7UDaZJK0Xjp33ggBgmvy3duTP/9VKXWKlNzk4RURzylTU3c6WPiQSb5aOy+DDr+DmUI8fBHUpJv2nZxFoPhcsamXJjbFTDCorFLnpW043eWnJnXf65n2PHjZQH4pX8Fk3Bk2hU8BYovxnw9oOXWMGNeoh3k9S8rV2Guu6O4Pc2mQsYN4EesfLk0VTZlEm+WiHsGI7HNHCvKA3BVJ9/L5HrE1rlb9wuu1y2vqfprA36AncUPRl0HlffdOgnorS6Q2yYHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30/07/2023 16:16, Usama Arif wrote: > If the region is for gigantic hugepages and if HVO is enabled, then those > struct pages which will be freed later by HVO don't need to be prepared and > initialized. This can save significant time when a large number of hugepages > are allocated at boot time. > > For a 1G hugepage, this series avoid initialization and preparation of > 262144 - 64 = 262080 struct pages per hugepage. > > When tested on a 512G system (which can allocate max 500 1G hugepages), the > kexec-boot time with HVO and DEFERRED_STRUCT_PAGE_INIT enabled without this > patchseries to running init is 3.9 seconds. With this patch it is 1.2 seconds. > This represents an approximately 70% reduction in boot time and will > significantly reduce server downtime when using a large number of > gigantic pages. > > Thanks, > Usama > There were build errors reported by kernel-bot when CONFIG_HUGETLBFS/CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is disabled due to patches 5 and 6 which should be fixed by below diff. Will wait for review and include it in next revision as its a trivial diff diff --git a/mm/hugetlb_vmemmap.h b/mm/hugetlb_vmemmap.h index 3fff6f611c19..285b59b71203 100644 --- a/mm/hugetlb_vmemmap.h +++ b/mm/hugetlb_vmemmap.h @@ -38,6 +38,8 @@ static inline unsigned int hugetlb_vmemmap_optimizable_size(const struct hstate return 0; return size > 0 ? size : 0; } + +extern bool vmemmap_optimize_enabled; #else static inline int hugetlb_vmemmap_restore(const struct hstate *h, struct page *head) { @@ -58,6 +60,8 @@ static inline bool vmemmap_should_optimize(const struct hstate *h, const struct return false; } +static bool vmemmap_optimize_enabled = false; + #endif /* CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP */ static inline bool hugetlb_vmemmap_optimizable(const struct hstate *h) @@ -65,6 +69,4 @@ static inline bool hugetlb_vmemmap_optimizable(const struct hstate *h) return hugetlb_vmemmap_optimizable_size(h) != 0; } -extern bool vmemmap_optimize_enabled; - #endif /* _LINUX_HUGETLB_VMEMMAP_H */ diff --git a/mm/internal.h b/mm/internal.h index 692bb1136a39..c3321afa36cb 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1106,7 +1106,7 @@ struct vma_prepare { #ifdef CONFIG_HUGETLBFS void __init hugetlb_hstate_alloc_gigantic_pages(void); #else -static inline void __init hugetlb_hstate_alloc_gigantic_pages(void); +static inline void __init hugetlb_hstate_alloc_gigantic_pages(void) { } #endif /* CONFIG_HUGETLBFS */ > [v1->v2]: > - (Mike Rapoport) Code quality improvements (function names, arguments, > comments). > > [RFC->v1]: > - (Mike Rapoport) Change from passing hugepage_size in > memblock_alloc_try_nid_raw for skipping struct page initialization to > using MEMBLOCK_RSRV_NOINIT flag > > > > Usama Arif (6): > mm: hugetlb: Skip prep of tail pages when HVO is enabled > mm: hugetlb_vmemmap: Use nid of the head page to reallocate it > memblock: pass memblock_type to memblock_setclr_flag > memblock: introduce MEMBLOCK_RSRV_NOINIT flag > mm: move allocation of gigantic hstates to the start of mm_core_init > mm: hugetlb: Skip initialization of struct pages freed later by HVO > > include/linux/memblock.h | 9 +++++ > mm/hugetlb.c | 71 +++++++++++++++++++++++++--------------- > mm/hugetlb_vmemmap.c | 6 ++-- > mm/hugetlb_vmemmap.h | 18 +++++++--- > mm/internal.h | 9 +++++ > mm/memblock.c | 45 +++++++++++++++++-------- > mm/mm_init.c | 6 ++++ > 7 files changed, 118 insertions(+), 46 deletions(-) >