From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3B3C3ABDD for ; Tue, 20 May 2025 08:39:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC4D66B0093; Tue, 20 May 2025 04:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9C236B0095; Tue, 20 May 2025 04:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD9186B0096; Tue, 20 May 2025 04:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 93F6B6B0095 for ; Tue, 20 May 2025 04:39:01 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 33E401A08A7 for ; Tue, 20 May 2025 08:39:01 +0000 (UTC) X-FDA: 83462636082.19.CA2AFEA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf02.hostedemail.com (Postfix) with ESMTP id F3C328000E for ; Tue, 20 May 2025 08:38:58 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S5Wkh7oL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=znplM6+X; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CJFHxz9D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0GGXyUr6; spf=pass (imf02.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747730339; a=rsa-sha256; cv=none; b=sxYhhO1/a5br75CECD2H5/m5JJRI/nM7Q0aidmKeMnOAL4tzfkQ1yOlSdMua28J0fA+85f 3UL2jpgQGO3SQisN1A58m+Go3vzOBO7c4NeLAhKrPbOoSlZQA3V2E1bjMiiyvvDhBNT8FQ 0s/I1cv6YBFFBkAAJowszSbXSOB+Ed0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S5Wkh7oL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=znplM6+X; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CJFHxz9D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0GGXyUr6; spf=pass (imf02.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747730339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OVYlKjN4zUbpXRhJAkTH7z/CxKiGHqQXzuN/0SLxarg=; b=YfLY0SaltCO+GOaFUGaffblEoZPiyMYxQZdyVdsZbVHwesB/vTyVXXDgh0J8AWuRjXlQsR 6gTqipBYvd4jI4JNNbZYP67hzsD8PSK1TJmD7kHjSgDoAsFyEjo/Vl4SA50BOV5dtrxKsG Kl63yqFjFfv8jFUlr9SM0HVomN8Vmew= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D9B702065E; Tue, 20 May 2025 08:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747730337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OVYlKjN4zUbpXRhJAkTH7z/CxKiGHqQXzuN/0SLxarg=; b=S5Wkh7oLEB79AG9GvXwtSeuvm1Zs6tw/Rh+C9aqjEEb/dDcZ45tFzmUpU1nfBRv0qR/VBm tijgRsBh8ni8KgUswuHV937a5wDKtEBxdAMayoAEnBQdyy1mTzKqIlJH8kqZIk2oOKw9jZ zO+7jbg0I8rj1d4QPyC9FlVEd+atdzw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747730337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OVYlKjN4zUbpXRhJAkTH7z/CxKiGHqQXzuN/0SLxarg=; b=znplM6+XJeTxQbRmMiKHe4Y+wEj7An18tt3bokMp6AeIJCr0afJsY5s7K/2CB5SBoxh31m WbQ5ayBn9Rjx9BAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747730335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OVYlKjN4zUbpXRhJAkTH7z/CxKiGHqQXzuN/0SLxarg=; b=CJFHxz9DD7J4lxijpdZiCPXYbXis1d0zyu8wHB3c6HHFWtu346uEZybT+Rlj5tC/ATOMHG 2P+B/otJj9iHw1jmBHWsdtU5u931OHlwRcwFsegRKfNubDHoWPmWhdGirG9hYq5qM8dk0L eCps+KPLwGzP1BaSK7fBc47f2JPZex8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747730335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OVYlKjN4zUbpXRhJAkTH7z/CxKiGHqQXzuN/0SLxarg=; b=0GGXyUr69SQbPvt64kne5uiuZbabsAkZKrhFd1y3PuhTKXAsGwofLTz81P+D6YePb3BkQ8 WnxzOMdg84Bt2GAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9CA5A13888; Tue, 20 May 2025 08:38:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GCUiJZ8/LGj9TAAAD6G6ig (envelope-from ); Tue, 20 May 2025 08:38:55 +0000 Date: Tue, 20 May 2025 09:38:50 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , David Hildenbrand , Vlastimil Babka , Jann Horn , Arnd Bergmann , Christian Brauner , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park , Usama Arif Subject: Re: [RFC PATCH 4/5] mm/madvise: add PMADV_SET_FORK_EXEC_DEFAULT process_madvise() flag Message-ID: References: <617413860ff194dfb1afedb175b2d84a457e449d.1747686021.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <617413860ff194dfb1afedb175b2d84a457e449d.1747686021.git.lorenzo.stoakes@oracle.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F3C328000E X-Stat-Signature: tfmm3q7ejo9x1o61ib5hykcsrb3dn7zz X-HE-Tag: 1747730338-372564 X-HE-Meta: U2FsdGVkX18slvPxlWJdeu5ETh6dqS6nB/CRfVAJf0+jtWvJNvlCuOl52ux8O3DupkDNiKrqF+IHDKBvuC5S0IIR8mNjL5NiqcZfihBKTTH2fIMTsHdDSMJNrT/7f97syJUZWdl4N3wJBtbAmRecJaniEyYuxMrybnD1QmfYSuYk3MZOT15QvrilI9nrJHXNamL0U4ICUrFQddjYbZWGc1XOFuWhUkMrsktL9VSU3TbUHChYpkZdjaR7NkHD3J5aGJx1au5Y6iy7L0znKYWw1xFCcsjSFXjTGD+digHDz9LNVmzdbHFOgfATJhGN2NWQJ7D7c3QMzwyQYec57KQAuX5r0yvGzwIC0tIFsrJbk4PI4Lu7m0hUe9Nl2ImyZqeyh7viGn/VPyKUob0q3qskuZYqIYYa4N92eGt0gJypp8fNLCCfYADJ5ZxgBgGnpH2Rap0wkHQiuPTCdL3M8BrSHzziEf4doIcVK+7y0I3JkIOwFA8AIu5CSyX4pJ3LmMaIkmSoQ/hfxq8ihbzazaPkqQHz2FbWiWtlAtprg3mMPgHRCcFAJSRqwEpbwUbBvV2n/KXF6BR+kbWEZBZWDq/ZhJZWb4rfEXZ6+WkBjK/sCxk2jQENCDsE52SGtd3WM4EiMUWLA3t1SMj2g6SrxgcsQJWRax1nX/DW9a4zg/5PKnwJKztAPcRRhHn7lOzq0UoUBYKvZ2wnHWSRiba4yUxYs9+7GqOKnrzOgfe6u1zcRgPjQJ3sIm3x95ZguJU5ik+UDsFrGmFhinLJ3g5mj+w1Atj3BECRxouAGmlkWz6CfX1f3ho56DGxwLRpSfBEnBFflJV15VrZ59bBQ7O27qA20QLaJ2LfH30+w1fP8yClhgpeNsExhHqFM22HDlkJ4awt/3FDmmZCexTAC8lMltf344yKWk4rlHt8qNtsxi44swCt5K1ufBwNzg/7djiNi6tKbfNQDdc4n01T4M7b243 vH0Fdrba 7Qj+TSNz0cD9vHMhNwQ+VM9Bcfq2LQ3ULBN+P1/oc0dF3VGTg+D6txrg9OgvrQFOpQD6mPKuea+M9UhYAzL+9/a6GYZ+jQl5o//SHV7HAFfLOWQmZ5DIMdBwc19qlMKowLLpeIqezZCo0eS4ucnMKlfMwxcOS5RvxHABTV12juX+BtZ4Omlal20NsvXARiju2Inu86FWUMswoqeCSaUhcfDX6kgvp3PgZKYZ+Wxgs5Wa0ZBHRFduFls4b/PrJWbp3WlTQVODeahAn/IdjtNGmpkQtPnlci8RMPL8FPXJrHnBtwR+hFx0CgrZsH9h7rHi6ubxwdj7+bh/LgIpNGmkY+chfl7m0dkWlrJCr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 19, 2025 at 09:52:41PM +0100, Lorenzo Stoakes wrote: > It's useful in certain cases to be able to default-enable an madvise() flag > for all newly mapped VMAs, and for that to survive fork/exec. > > The natural place to specify something like this is in an madvise() > invocation, and thus providing this functionality as a flag to > process_madvise() makes sense. > > We intentionally limit this only to flags that we know should function > correctly without issue, and to be conservative about this, so we initially > limit ourselves only to MADV_HUGEPAGE, MADV_NOHUGEPAGE, that is - setting > the VM_HUGEPAGE, VM_NOHUGEPAGE VMA flags. > > We implement this functionality by using the mm_struct->def_flags field. This seems super specific. How about this: - PMADV_FUTURE (mirrors MCL_FUTURE). This only applies the flag to future VMAs in the current process. - PMADV_INHERIT_FORK. This makes it so the flag is propagated to child processes (does not imply PMADV_FUTURE) - PMADV_INHERIT_EXEC. This makes it so the flag is propagated through the execve boundary (and this is where we'd filter for 'safe' flags, at least through the secureexec boundary). Does not imply FUTURE nor INHERIT_FORK. and, while we're at it, rename PMADV_ENTIRE_ADDRESS_SPACE to PMADV_CURRENT, to align it with MCL_CURRENT. Thoughts? -- Pedro