From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85DDC71136 for ; Tue, 17 Jun 2025 10:12:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 795026B00A0; Tue, 17 Jun 2025 06:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 745AC6B00A5; Tue, 17 Jun 2025 06:12:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E63A6B00A0; Tue, 17 Jun 2025 06:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4BA6E6B0093 for ; Tue, 17 Jun 2025 06:12:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 158CF16046C for ; Tue, 17 Jun 2025 10:12:53 +0000 (UTC) X-FDA: 83564479026.17.93A69A6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id D81B720009 for ; Tue, 17 Jun 2025 10:12:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lYQbxJ10; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Svwy5fM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lYQbxJ10; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Svwy5fM; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750155171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4vW1BLf3KmtZV1m8k5bHUaabgyxSpXUIU3DYk4FH3CY=; b=iGC3YAoBbdorhl0EkHkhW3r/BQ97G45o9j08OxRKaLLwF1bJ531wbJTsjd7hCDjvWsDGCy 5ftI0havtho0J2idouD1kQVq7LpaXdqQw2gXI/JDhMOf5RjLrUvIASDbOK2rh1B75JjJqK CZAYDjkQGoF78ulmMUYE0UB54MG7VlE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lYQbxJ10; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Svwy5fM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lYQbxJ10; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6Svwy5fM; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750155171; a=rsa-sha256; cv=none; b=HsawCjMOkUcMBC9Y1EDPB5inz8ctGfh7YlBzTDacDZuNln+qS4tpRRcinK70gez8JbOzBL Q8/7tQcp7O4kl5Qn0IXQpKtg/ur3nw+slK7Gx/6aQaIXrgL5DVCfYDTN5tcP/Ssiwq83VH b4qsuR4YoNTzDLQOSz0gKwax+Hz6O0Y= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0CDC31F391; Tue, 17 Jun 2025 10:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750155169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4vW1BLf3KmtZV1m8k5bHUaabgyxSpXUIU3DYk4FH3CY=; b=lYQbxJ10XiF36NJ1nZX42utoD9Yi9TyH4Ri/ANfsedxpT2Cx0Qq8W/p6zKiFmiP7s3zPkO vbi/Khf10BE1V8jJeg5U2LP+5M9mZ+tGSED0JBxpGQbaWchHGHnUfgJnCPLHc2FZta69oj vTfJbMV67J/+PmBScr0eGy8Ap6QA134= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750155169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4vW1BLf3KmtZV1m8k5bHUaabgyxSpXUIU3DYk4FH3CY=; b=6Svwy5fMZHrfWJ0JoGLiBFzbzdphbHyONhbgAax6JbhOcNZmQutxQUD0ZOoTNQkgIB0GQQ bUpA7yCdSF8Rm6Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750155169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4vW1BLf3KmtZV1m8k5bHUaabgyxSpXUIU3DYk4FH3CY=; b=lYQbxJ10XiF36NJ1nZX42utoD9Yi9TyH4Ri/ANfsedxpT2Cx0Qq8W/p6zKiFmiP7s3zPkO vbi/Khf10BE1V8jJeg5U2LP+5M9mZ+tGSED0JBxpGQbaWchHGHnUfgJnCPLHc2FZta69oj vTfJbMV67J/+PmBScr0eGy8Ap6QA134= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750155169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4vW1BLf3KmtZV1m8k5bHUaabgyxSpXUIU3DYk4FH3CY=; b=6Svwy5fMZHrfWJ0JoGLiBFzbzdphbHyONhbgAax6JbhOcNZmQutxQUD0ZOoTNQkgIB0GQQ bUpA7yCdSF8Rm6Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ED7E013A69; Tue, 17 Jun 2025 10:12:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cLv1OaA/UWgDGQAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 10:12:48 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id A6C44A29F0; Tue, 17 Jun 2025 12:12:48 +0200 (CEST) Date: Tue, 17 Jun 2025 12:12:48 +0200 From: Jan Kara To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 07/10] mm/filemap: introduce generic_file_*_mmap_prepare() helpers Message-ID: References: <30622c1f0b98c66840bc8c02668bda276a810b70.1750099179.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30622c1f0b98c66840bc8c02668bda276a810b70.1750099179.git.lorenzo.stoakes@oracle.com> X-Rspamd-Queue-Id: D81B720009 X-Rspamd-Server: rspam07 X-Stat-Signature: 595yxm5tj96bjc81afjp9ctwixjwitho X-Rspam-User: X-HE-Tag: 1750155170-390760 X-HE-Meta: U2FsdGVkX18oqjx40QLAY5cxmHA3NsfIb23snoYap+HNY7cfREZ9HDVt65YB2fn50MmZftEUR3Eh6wZtCwoeR/SWzT9lASr2ujdLEuVlMtAqqyN1qv/kvYCMLXpfh+BYuIlcUjW00KXobJgxE+w57CvARvlTxHHeuggEBF0skQ2aAYXo7gblD1r2qK9UZC2EOKT8CZ7vUfp2hdllb5qm+eUwiUsjiJsCFHVb7SlCyzyltBBOeCdgFPs1x+/cRSIRgwdVr1Vz++4Se8GrMWtapL5kr42N6POyM20Mqh9AHqiWpLeaaijbtNbaV2m08bRffRnJeySbvXGurAo5DoWTAQ1XR6YwAeiHOJ5In+R321wgANhkiVOczHSrW+crhqcjM8YaSybldS6JNddvYIgZqMwxqzLoVSdiY6on7fOB25WYT2pN8+VUwV/kDoXwLlbNtGR3aXUM9vEkKOm1x65Bjq1fQ72bkdaey9owTanj5WAAU8Wl7s44xKyaRf16qelUqpuuVMSRv2eIwyoS0oUtIHMbou2MwvMk76L2Q0d31678FmNNHTfhG8auI1k5r8xphYmyKNDa204xKGw/hVlgrlctePFW73QK1VQERdS4ywffYwPmElBmyiOTt6zsPgIUR2oXpJgkHvzpOPilwDgpiB4Q3OhGgl1zsv8idNtVdBquSJoGC2P53SIqaE0lTTz1VmDLk+SZdp1+rOyxNU34L08XdyKdJEU5hDBi0fFKXyVlu0J1bCe3JdsLxDFxC1k8RAeQn+v+svVZ7iNdO3/Cl2xo9k+Sk+Kt/W6/w84gXMH0qVIwIN4A2QbaghK8eRJTcPk0D1++CSbcP2zbxM0CaicG7QIVxWQecFPHNsipar3t8g6uHCHWNxEQU3bmCAl56ldHfxmchfR4Li99CMPeFibUZzN+3z6zynS1CQKmlX12yBixIy0JfB6gJZqvm+p9eT+6Csu4TB6uSmcVMhP /LiqyUCu Y5g6+F+Qc0HcWFo1bBIBXeCcWK5RHDm9/qymIGqG2YpHR6Ng1GbIRz+dic+mUT8Mncb0j3hESqotzJcu50WqZSi1Vm4d+wLCy9P3qX4rSH2JmuT66XQI4taotqsSC+hRtqZu3ku+9WbMHVQ/ZgMAGqStAoB1LFaYSWh5DgZk3839Dm4ehydHRYizhIOSVmOB6MZPq1tHQw1Y15QIsFd/z8I7YzxAuEf7mc72X/pHR3qWVEFFqIefD67pwBOlQfCP3ga3IfXd/ltwZ9z0ReqLE0HLzrvqIZ7cgVzRBvcM69FEjpU0ZmrfPfgGUjaIBSSP5iaJlC7dvFOT/IXy6heoLe10vXxK7h/CWXibZKBqOWbkJZsLPOz+oanxa9cIIsDdv9v8uRV33CIYmRaG9JTjPpeuMKBNUVmRxUy+L606NUbXYY53ShOWw+s+yNhbyfIWs6eKLQR+ZhK8G/c7lCdsJsLdyACZSM0GswxtREqGlYKodAy0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 16-06-25 20:33:26, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > The generic mmap handlers are very simple, so we can very easily convert > these in advance of converting file systems which use them. > > This patch does so. > > Signed-off-by: Lorenzo Stoakes Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/fs.h | 6 ++++-- > mm/filemap.c | 29 +++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+), 2 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 7120f80255b3..65cffc445fcc 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3395,8 +3395,10 @@ extern void inode_add_lru(struct inode *inode); > extern int sb_set_blocksize(struct super_block *, int); > extern int sb_min_blocksize(struct super_block *, int); > > -extern int generic_file_mmap(struct file *, struct vm_area_struct *); > -extern int generic_file_readonly_mmap(struct file *, struct vm_area_struct *); > +int generic_file_mmap(struct file *, struct vm_area_struct *); > +int generic_file_mmap_prepare(struct vm_area_desc *desc); > +int generic_file_readonly_mmap(struct file *, struct vm_area_struct *); > +int generic_file_readonly_mmap_prepare(struct vm_area_desc *desc); > extern ssize_t generic_write_checks(struct kiocb *, struct iov_iter *); > int generic_write_checks_count(struct kiocb *iocb, loff_t *count); > extern int generic_write_check_limits(struct file *file, loff_t pos, > diff --git a/mm/filemap.c b/mm/filemap.c > index 93fbc2ef232a..e75608cbf420 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3847,6 +3847,18 @@ int generic_file_mmap(struct file *file, struct vm_area_struct *vma) > return 0; > } > > +int generic_file_mmap_prepare(struct vm_area_desc *desc) > +{ > + struct file *file = desc->file; > + struct address_space *mapping = file->f_mapping; > + > + if (!mapping->a_ops->read_folio) > + return -ENOEXEC; > + file_accessed(file); > + desc->vm_ops = &generic_file_vm_ops; > + return 0; > +} > + > /* > * This is for filesystems which do not implement ->writepage. > */ > @@ -3856,6 +3868,13 @@ int generic_file_readonly_mmap(struct file *file, struct vm_area_struct *vma) > return -EINVAL; > return generic_file_mmap(file, vma); > } > + > +int generic_file_readonly_mmap_prepare(struct vm_area_desc *desc) > +{ > + if (is_shared_maywrite(desc->vm_flags)) > + return -EINVAL; > + return generic_file_mmap_prepare(desc); > +} > #else > vm_fault_t filemap_page_mkwrite(struct vm_fault *vmf) > { > @@ -3865,15 +3884,25 @@ int generic_file_mmap(struct file *file, struct vm_area_struct *vma) > { > return -ENOSYS; > } > +int generic_file_mmap_prepare(struct vm_area_desc *desc) > +{ > + return -ENOSYS; > +} > int generic_file_readonly_mmap(struct file *file, struct vm_area_struct *vma) > { > return -ENOSYS; > } > +int generic_file_readonly_mmap_prepare(struct vm_area_desc *desc) > +{ > + return -ENOSYS; > +} > #endif /* CONFIG_MMU */ > > EXPORT_SYMBOL(filemap_page_mkwrite); > EXPORT_SYMBOL(generic_file_mmap); > +EXPORT_SYMBOL(generic_file_mmap_prepare); > EXPORT_SYMBOL(generic_file_readonly_mmap); > +EXPORT_SYMBOL(generic_file_readonly_mmap_prepare); > > static struct folio *do_read_cache_folio(struct address_space *mapping, > pgoff_t index, filler_t filler, struct file *file, gfp_t gfp) > -- > 2.49.0 > -- Jan Kara SUSE Labs, CR