From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF15C02183 for ; Fri, 17 Jan 2025 09:55:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 879326B008A; Fri, 17 Jan 2025 04:55:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8295B6B008C; Fri, 17 Jan 2025 04:55:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73E8F6B0092; Fri, 17 Jan 2025 04:55:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5211C6B008A for ; Fri, 17 Jan 2025 04:55:23 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C80D0C069D for ; Fri, 17 Jan 2025 09:55:22 +0000 (UTC) X-FDA: 83016486084.16.786A6DA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 1ADB240003 for ; Fri, 17 Jan 2025 09:55:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vR7rTmvc; spf=pass (imf12.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737107721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s+yotaUtYF2CouWuQ8FEmsPWIK8eazcthIBiPyFKkAI=; b=Bib9E2/gf6Qd1IB1Q6M65vPKeYZejLqI32LA80aAYRNUV5XeIuz3W0BJjAkgRxb5Ra8Enx qzpps1/NE7DsmYNnMl/yLEm1FVxI1rTvKSvMOgzhhO7xro5/WBAmmy4l4hqXEVlS4MdyF9 u3pOIr5nLbDm79Gbeao/Y5Jmd6L1kkA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737107721; a=rsa-sha256; cv=none; b=WjtLnVYTdso0P91n59bZw+QVmR7UwoRhVEo9h8zmJE+ZQJuhKXoQrP+epGRrZn3Zz6EVT0 l4TiZflUbLOPsxEuffcAkg5pq4ijGYbEvTY2W2PqUgDjBwdXilbzQ21ATpqGgVN+m0xkeH g37jboSaFLQWmvXa0OyUnHxdH09Wtdw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vR7rTmvc; spf=pass (imf12.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2F4705C5FED; Fri, 17 Jan 2025 09:54:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15A99C4CEDD; Fri, 17 Jan 2025 09:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737107719; bh=b2+5I4Ol2pXJvkBZ25q9n0ksWds8r5RzMGcUkZNXIng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vR7rTmvchnyfzF5H2XyPp+s5v4UNzLMt8hLgNgt0BW9Av3EJtMTzYNgzU8yBYQf6O MJ2az8kCy+MMGnAQM3b0/4sOVDdU5hd4bwn+kCZRAcL9IIgc/L6LYaz0Jcac90tBUY XSiwKHtvtallUo+yeHR18MAlGtVbe84A4/kWJypY7x7QNSELNudlnMiqd95GL2WpyC nvjxxXZsVKR75XEyCu62Yp+i0UWzN9vrcIMM22DUkBDucC5HmEE9ABy4ZeFP/4awU2 bNWXqLsaqYQFUf4U/ETOqNBv3TfJhoLm+PBLt7l5Sx1S4OiORnc1D+Yjs/J/CX8xG+ 2JiCJfr4mNPZQ== Date: Fri, 17 Jan 2025 10:55:14 +0100 From: Joel Granados To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v5 -next 11/16] sunrpc: simplify rpcauth_cache_shrink_count() Message-ID: References: <20250111070751.2588654-1-yukaixiong@huawei.com> <20250111070751.2588654-12-yukaixiong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250111070751.2588654-12-yukaixiong@huawei.com> X-Stat-Signature: ctccwfqgsm8hkwg5e18sj6nedo7awjk4 X-Rspamd-Queue-Id: 1ADB240003 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737107720-901828 X-HE-Meta: U2FsdGVkX19QuxehVn0LceYUa+9yvi/0vbTUWpXeTqZ33XGI9pKwZ33FAj7aR6wydrdCTstD233ttiNCT+duEwBVWIpi9/mZir5NnaRS9AuKuKjHQzx3kk3hMX5ivfqDWGAdLiQbn3EjIiiGuuQo+g8w63rOWl5o/51AIRbjEGdqazEZJdIt11sG9CP8TM0ZLPIm5J4cmSedeg4dMiWMcsDme6XkUDbEC+tSB4eXCYwYc8H94NX5AMVI8rE0g3lrP0xm7V7NliasDteDyJH1r61pjYdWyaoTj9b1TYzZwFL+zJjTo57UPKWe+VzcLcIlEgCP/YcjmyHe2Xp49z8CpFfpeTX/8OfoJSakqdgE6WPu1YgKO2s63iI3pkc5NvYiMq5I4rODLsfzn3eEzlO2KBRng+OfwsVavGwqc3ggx+bnCisSJzVhKxogKqwv+mLIBMtJk+ApQonpOh29M9NlRhII/K+Qghm9nstlwfTQpaPzvuWwnDrYazJGbX2/rachj77ZOhj9vfCmTNPcYrfB5p6QZ/zU8bqZ6dEGsCeuVr+Hji5tW1DARTkBdg+txnbLaBf2yrklYLJ7SMwvD4nwHfD+fN/Hn4EhqkkwVqOPMwv1bjOKqOTCrSmjIySLnD0VrjJX0yyMHYXUvHS3V1RhIFjJbmjam4QUjwDgKq4uFxyjLUEvLrwIQG7+X3Z3+eVFjwcF+1yB2WHpNBL7HcgADaKpKB53Nz/Uf/dLjK77pFcLFG/EH7vcO4FK/pw4J26pzlbbtHNAkkWY7tYE6NBwSO6mGdpyGOngZ6DOcylMyg8e/2+Y4eqxn4itQWULzrTUPV/voaMFdJWNo5oAs4gdeKFcVRpc4j+j2O7fRnJ7r87yierwhVakgVRagC8dTWm0VdoBHQWAJYIA61FIOQ3wyEALvwXCRWLlGOwT5RlPlKbLIGkcWifVKwp8ItSPgHKANaWFykSAQobq70L8XFu ejeqOUg2 2auKOP7XJJsC5fcXmhTCFUBBGj6VfhJLnbgGWmTdCnglGX2/sIKsuyX5gxhRs4LYF5iaJ/6IGDFQHss7R8MRGekBE2dWuZTOD9PiwoH7ygA80aIRL5r+vvG91CIxmMbb8N45k1g2zpE0GRYDVtcpT/KCI8wIuYTwHTJqYNa6IvwdsHTk0VOXXQZqecbzzg5tW5KoQnR+PuXoWTDqwTDWyBzMBM3CRkc1D3Svu85v2K9hg71aWHmCeNBEDc9EZCTc/th2ts4FMzfoATEqGrUCwpLK+KSW0SQmoUr4IOo8+Rw/N/nGgEGjf+zx5KmGNtMDIlu6W/0RZgTcW8pPFRjyHw82c6yHSCRZRu0oY44wVyxFVnQ65iuLH3CIcBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 11, 2025 at 03:07:46PM +0800, Kaixiong Yu wrote: > It is inappropriate to use sysctl_vfs_cache_pressure here. > The sysctl is documented as: This percentage value controls > the tendency of the kernel to reclaim the memory which is used > for caching of directory and inode objects. > > So, simplify result of rpcauth_cache_shrink_count() to > "return number_cred_unused;". > > Signed-off-by: Kaixiong Yu > Reviewed-by: Kees Cook > Acked-by: Anna Schumaker > Acked-by: Jeff Layton > --- > v4: > - Simplify result of rpcauth_cache_shrink_count(). > --- > --- > net/sunrpc/auth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c > index 04534ea537c8..5a827afd8e3b 100644 > --- a/net/sunrpc/auth.c > +++ b/net/sunrpc/auth.c > @@ -489,7 +489,7 @@ static unsigned long > rpcauth_cache_shrink_count(struct shrinker *shrink, struct shrink_control *sc) > > { > - return number_cred_unused * sysctl_vfs_cache_pressure / 100; > + return number_cred_unused; This one is not related to the "moving sysctls out of kenrel/sysctl.c" but I'll keep it here because of the Acks received. > } > > static void > -- > 2.34.1 > -- Joel Granados