From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA261CE7AAE for ; Fri, 6 Sep 2024 03:52:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AE836B008C; Thu, 5 Sep 2024 23:52:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35EFD6B0092; Thu, 5 Sep 2024 23:52:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24D236B0093; Thu, 5 Sep 2024 23:52:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 051696B008C for ; Thu, 5 Sep 2024 23:52:51 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7CA6940DF9 for ; Fri, 6 Sep 2024 03:52:51 +0000 (UTC) X-FDA: 82532942142.22.16D35DE Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf14.hostedemail.com (Postfix) with ESMTP id 7F4A1100002 for ; Fri, 6 Sep 2024 03:52:49 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EWsDUIk1; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725594671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ViqQws4Jf5ziYGnPbgxaT1dl8++vDEC9G09+6DnUaY0=; b=agYZVdKVmHKnv5Y07/ivBF5dxx86D31DiwkfPAc1IbCYKZRFLaRnmbqu7BZgyIAZjX8ZNu AXq1azWMi4Cv/lDytyrRA9RD8QAYRXDVrE+zbYge4kSywT8yC/kQAT4CO4411i2S5pASxI PPJ5fud2LDoswd2OJSKCorIXbaJ5bUw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725594671; a=rsa-sha256; cv=none; b=26rTgqLn2xDI6/sO3VqNisbpZAT9hKNFntuvWUoF5GnKhPcf1lcHmO8RubiSAP3IcHbx0a //aHCEFpWMsvTElI0+ZLHcDP6zoLNSqMbpLW1XCKbPmUN9QzMUTMbVqchfyaDQ+c6vbN24 5tJYPyClKs8QeKiAupIyTD/VTdL2OQo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EWsDUIk1; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 5 Sep 2024 23:52:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725594767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ViqQws4Jf5ziYGnPbgxaT1dl8++vDEC9G09+6DnUaY0=; b=EWsDUIk1GSB2ZARLyN51oWu0S91Lx4Y9sI1v80o+i9Fd55EtgN8xmnlTMgaoKd4CYqKHmj YazBWM44WRcybdK+tis1Xwp5TX5av0Q9xrWBMukgKgJXSdeOuKpPxg3uKMFhJs/tziEdR0 +7rzaHpVjj5/KQ7Cqm0PMZHtoEgY9s4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/show_mem.c: report alloc tags in human readable units Message-ID: References: <20240906005337.1220091-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: ws9quk4ttbtsxx3u4r7oitfhuzhk3pf1 X-Rspamd-Queue-Id: 7F4A1100002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725594769-915687 X-HE-Meta: U2FsdGVkX18bfWCtw4FAyOdmRaxHsHoNeNYX2lUIe760FxjHPf6edVL5Wt50De5jLGD6axBQw5ruO4tg4Pel+WlkDwNgj3N+DMH+qZV+Cc5GlG1JTL1Y52uMb9x1dz7Q0YO2TqHnEaR8aZUnM/U06A/HmF8V93YNOLcPppRYHsLw5lYs/SZsllKhKe/xKxQFo44r4dbfArMiYRmpI71WhDAs93s1Vzw0egK7dEGjyxCWgqNmJ28OMIES74iQy/P2mmSEWEggAZUpv89aXjXAznPCWMPugyXV5RLa1UK0MO4teh/fN9C6UxrwK/B/rdVMYUdGF73hOPo5BYRAW1pxcWFzSY1NDQbVag0A0ET2HPl5aGnXkhI8KT7JVyPT9TlNh2EJdQLto1XV/+rJ4cV8DxFk1+7LnRWZ/3mMuhK6tKY3vYwOctsAoKP/uk9LpeZXC7vIXqOwJkHnJcU6SoHmrjhBS8EjNb/1huoJpqHSDRSXAUqE5iLkcdXOUUKzLB3z+vCc1/66E3TSigqiuIXiUjkXF+6cxzpe+s7mkBmmUg2iumA5Ey+CSVcwfsP7yFAaDae6Mwq9g8RMpr7qHyxkhdRt0FXfzXsG+w3skribJamGjpmG8xGji6IMhqNrmD/Qy8mQoFkogw+XnHwg4Sm2jvcY0IKfykfh4G23hC7Y5J/BFtjRvh9KsVbWrErjgR1QohwDqljaoGDZRZyQwIYHuk8fyXTGblckMw5zfbEKc3fXX/DN7mvHVAVke1NTW30+lhRH8ft/G00ANUdgai714C3Z9grDgK+lRR+DpwWR5IV2uNSxx4vI3Twed6QQ2FDcOUNuWxB9QB2NM1/owr4HKdc4SRhjpqtBIV7ZF4JXX58Bb2+BrK3/HbDrUZU9b9uw2k2t9S7FeYS4d/FlAzbwG0vm/SwAugo5svM9MD1Vkx3ysawojyk3K3D01DE5ZV7kIvbXccAcBEa4dV/bPzJ ii9jQFbj MZEdhg7vUegPDvbs6Ex/l2y3YfbaDVIqgX6vJx43F5lzIiJGW+DLP2rFV15klFWTa3YPbo8r2i3dB+qqJCiGSA8TNrkI5C6QJ5bboHv2dWLUW32v9hh274MxqMDc80VpT9ZW6o9QxHHWqnS1OkoCJ4gXaH5jYUu6MrlZkE766C8PcnaiFBUVqe7ZSRaBGSbnVeF2RkkV7OSaRQF+7d3Mi//Pec7CtgRgW6Dx0sq9Su/HQjCqBqI/x1MXPrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001787, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 08:32:24PM GMT, Suren Baghdasaryan wrote: > On Thu, Sep 5, 2024 at 5:53 PM Kent Overstreet > wrote: > > > > We already do this when reporting slab info - more consistent and more > > readable. > > Hi Kent, > I remember we discussed this before and agreed upon Pasha's suggestion > that if needed one could do: > > # sort -g /proc/allocinfo|tail|numfmt --to=iec > 2.8M 22648 fs/kernfs/dir.c:615 func:__kernfs_new_node > 3.8M 953 mm/memory.c:4214 func:alloc_anon_folio > 4.0M 1010 drivers/staging/ctagmod/ctagmod.c:20 [ctagmod] > func:ctagmod_start > 4.1M 4 net/netfilter/nf_conntrack_core.c:2567 > func:nf_ct_alloc_hashtable > 6.0M 1532 mm/filemap.c:1919 func:__filemap_get_folio > 8.8M 2785 kernel/fork.c:307 func:alloc_thread_stack_node > 13M 234 block/blk-mq.c:3421 func:blk_mq_alloc_rqs > 14M 3520 mm/mm_init.c:2530 func:alloc_large_system_hash > 15M 3656 mm/readahead.c:247 func:page_cache_ra_unbounded > 55M 4887 mm/slub.c:2259 func:alloc_slab_page > 122M 31168 mm/page_ext.c:270 func:alloc_page_ext > > That's even documented here: > https://elixir.bootlin.com/linux/v6.10.8/source/Documentation/mm/allocation-profiling.rst#L36 > Did something change? That's for /proc/allocinfo, which this patch doesn't change - this is the oom report.