From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org
Subject: Re: [PATCH 0/7] spanning write related cleanup
Date: Wed, 27 Nov 2024 08:31:13 -0500 [thread overview]
Message-ID: <cqulekn3csbs5q6vo3uormpplgbn7vvqir4a4pnaavgvhcsd3b@js4s5ncaritj> (raw)
In-Reply-To: <20241127012753.3393-1-richard.weiyang@gmail.com>
* Wei Yang <richard.weiyang@gmail.com> [241126 20:28]:
> Here is some cleanup related to spanning write.
None of these fix anything, but do fiddle with code that's pretty
critical to the kernel. Most of the changes will be immeasurable in
change but carry risk to causing subtle changes.
Some are simple removal of returns that aren't used while others change
things because you think they are probably the equivalent. This seems
like unnecessary chrun at this point. I'm all for efficient code but
this is getting a bit much, some of these are just preference of what to
use that will already exist in the cpu cache.
I'll get back to you when I dig through them, as some need a deeper look
for sure.
Liam
>
> Wei Yang (7):
> maple_tree: not necessary to check ahead if !content
> maple_tree: validate we won't split on NULL
> maple_tree: check mid_split only may have
> maple_tree: the return value of mast_spanning_rebalance() is not used
> maple_tree: the type of left subtree is already saved in bnode->type
> maple_tree: always need to update max of new left node
> maple_tree: only ascend left subtree to get the old node for
> replacement
>
> lib/maple_tree.c | 56 +++++++++++++++++++++++++-----------------------
> 1 file changed, 29 insertions(+), 27 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-11-27 13:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 1:27 Wei Yang
2024-11-27 1:27 ` [PATCH 1/7] maple_tree: not necessary to check ahead if !content Wei Yang
2024-11-27 1:27 ` [PATCH 2/7] maple_tree: validate we won't split on NULL Wei Yang
2024-11-27 1:27 ` [PATCH 3/7] maple_tree: check mid_split only may have Wei Yang
2024-11-27 1:27 ` [PATCH 4/7] maple_tree: the return value of mast_spanning_rebalance() is not used Wei Yang
2024-11-27 1:27 ` [PATCH 5/7] maple_tree: the type of left subtree is already saved in bnode->type Wei Yang
2024-11-27 1:27 ` [PATCH 6/7] maple_tree: always need to update max of new left node Wei Yang
2024-11-27 1:27 ` [PATCH 7/7] maple_tree: only ascend left subtree to get the old node for replacement Wei Yang
2024-11-27 13:31 ` Liam R. Howlett [this message]
2024-11-28 1:11 ` [PATCH 0/7] spanning write related cleanup Wei Yang
2025-01-17 5:49 ` Wei Yang
2025-01-23 17:52 ` Liam R. Howlett
2025-01-24 1:43 ` Wei Yang
2025-01-27 14:36 ` Liam R. Howlett
2025-01-28 1:36 ` Wei Yang
2025-01-28 2:11 ` Wei Yang
2025-01-31 16:46 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cqulekn3csbs5q6vo3uormpplgbn7vvqir4a4pnaavgvhcsd3b@js4s5ncaritj \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox