From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F18C25B7E for ; Thu, 30 May 2024 21:57:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 477F76B0099; Thu, 30 May 2024 17:57:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 428516B009A; Thu, 30 May 2024 17:57:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F03C6B009B; Thu, 30 May 2024 17:57:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 114DA6B0099 for ; Thu, 30 May 2024 17:57:08 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7B3251C1353 for ; Thu, 30 May 2024 21:57:07 +0000 (UTC) X-FDA: 82176423294.21.3B6FC63 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf22.hostedemail.com (Postfix) with ESMTP id 98607C001A for ; Thu, 30 May 2024 21:57:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VCVj+QGd; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717106224; a=rsa-sha256; cv=none; b=Gd1TS9frD/BHVOq5MHJtnp4HYofrZ/snTJBIwutLn4tvFAfE5SQEwJJ9hJz/2i61nMMBxS oQrM2MSwUZsnuMSf8AAnXSFDMBqR6uaOnRCSVhiiQQdMu9VB3rj8LVKJPRM0M+aX14QEtb KVrsFL5Pwhp94nna/h6GYT7k3obPUnE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VCVj+QGd; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717106224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6vUVw2k/TRVjir+kYWNyPhgdXmenTsS4haD6uSDw11g=; b=BijaXnLOfQd1VsisNqf7yYqQkjo/39w5AKRO90Gn2y1WA1BbOOH8dgiUSn4MfHKf78vTON mPxFrpiaGmWOTuLAf3vS19bbaxEZbZMDfnHO9qYie3XKs/dz1ocPevfiQRq3C/7vnKlbNb yQtSUodN+na3JDuwJKC7PERPOxrZDKU= X-Envelope-To: pasha.tatashin@soleen.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717106221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6vUVw2k/TRVjir+kYWNyPhgdXmenTsS4haD6uSDw11g=; b=VCVj+QGdkLubGb31rdV+qzMmQJjacwDnq9OF4HDCPPFZqa7CKGS5NBrVJqz4yk3xZ8hDnf pQPh7u8vSj0K/yemTrKl3qXU2HqPpAfxn4pl8a6hpz/Dt2nVRFhi9tQ7q5Omokj7i606qH +LAKslGWOQG7cg4sBU193b18qJ0sPZg= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: jpoimboe@kernel.org X-Envelope-To: kent.overstreet@linux.dev X-Envelope-To: peterz@infradead.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: cerasuolodomenico@gmail.com X-Envelope-To: surenb@google.com X-Envelope-To: lizhijian@fujitsu.com X-Envelope-To: willy@infradead.org X-Envelope-To: vbabka@suse.cz X-Envelope-To: ziy@nvidia.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org Date: Thu, 30 May 2024 14:56:56 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Pasha Tatashin Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram Message-ID: References: <20240530170259.852088-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240530170259.852088-1-pasha.tatashin@soleen.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 98607C001A X-Stat-Signature: xkoymetuxoxx7pa1kdzoufwqo6ekmq15 X-HE-Tag: 1717106223-15800 X-HE-Meta: U2FsdGVkX1/SEKkjfLot/YuIcM+XNd745EO5YHWus5dFSLC+tTc7VPBARKvCesTD+Mx7xjBmOV97cAs89HV1fRNsBWQyhbwmT5ue5kMR0geQUWRxvskgG5k8FdN+S242k4jr0LQh9r/Xs0VVYlt6Rrqg4q9abC9Oge4A6kZVKo4nysh6Cd7l7MkAwJT0jswxbA9i27tkjqU51X5gDW3TgmnRnienN09kH+PePQJ8SZzPn0Lo6qe7zqx63Og5evDHkU5tzrAjkxYFIE0J0ecmIkBXJocgfLf8zUZUJnmnLWFKmCzkfVqFYa84ynhAnSatpr2q0VgC72l7SsnVSwumIY6qbMlsPmaChk5yT2pRnkz7xYJzcYFSIt6Q6Sjj+zutvRZXbh+ykgFTptN061EOvTGawrFMyG4FsbexL6xPn4GFoBjKeN6ZUdAwSR0IbgHXePAdhm55PRmBuHNM+OjNVxjWfP0M6nNhHPTQbtJ4FknfLyexy5PwcyOR1i25rmiG0ZXyCQNobeH0TzBLQbtSzQzPx0AI3mri8e88Q8e9A28hQT64vQ9Du0yWreaGi1cw1iDOpBXE1HVUOUNBKCIdPoz1v7HFPtvIe85wcKxOTFUTAYoU9MnT280ABly039NIpYf44pEfSu3o0yFypu40PflM35tNerDzODjQek8r6/JEJ/D0bA2DXyr6QPoTvpRvUEdhJrdbYc0KahGnyeEoJsLDSA/D50ftH/aoIiXn/eriQ4GsVAeUyd/ZShM5RToi/BOvflQh5pOi82XAZUVlgLl067pXFo0nHztGRC8I7D7sLCmQqH9p5f/yOzfv3KOLmJyU34QYNYU99ZFzGAsSzxs8ad+d8sYDONmEtHWK/IFNIGhFZL4BBySY5aS8Nq+sQlR+YaDvxzkR7h1zPAqQJCgMfqH21Ib0SC/1tjxIf0n0VnruwIPALJQpaaF32s3NKUX9jG2bqKFizdYrz/x 4t7nvhWk 60jh9aWRtc3lnlBWb42maX+wfDvwtfZKHjMXtgCoppbprwrchGWlqkbWgZcbl29LQdkbvmrhK6hc0HoscLTPeAV7fAc5lNoFjZS0GTQDrGQlEcO48su35WSeTPdyl0f6N2MB7y9TTQfl0jbt0xljb5whGNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Pasha, On Thu, May 30, 2024 at 05:02:59PM GMT, Pasha Tatashin wrote: > Provide a kernel stack usage histogram to aid in optimizing kernel stack > sizes and minimizing memory waste in large-scale environments. The > histogram divides stack usage into power-of-two buckets and reports the > results in /proc/vmstat. This information is especially valuable in > environments with millions of machines, where even small optimizations > can have a significant impact. > > The histogram data is presented in /proc/vmstat with entries like > "kstack_1k", "kstack_2k", and so on, indicating the number of threads > that exited with stack usage falling within each respective bucket. > > Example outputs: > Intel: > $ grep kstack /proc/vmstat > kstack_1k 3 > kstack_2k 188 > kstack_4k 11391 > kstack_8k 243 > kstack_16k 0 > > ARM with 64K page_size: > $ grep kstack /proc/vmstat > kstack_1k 1 > kstack_2k 340 > kstack_4k 25212 > kstack_8k 1659 > kstack_16k 0 > kstack_32k 0 > kstack_64k 0 > > Signed-off-by: Pasha Tatashin Couple of questions: 1. In future with your on-demand kstack allocation feature, will these metrics still be useful? (I think so but I want to know your take) 2. With on-demand kstack allocation, the stack_not_used() needs to be changed to not cause the allocation, right? 3. Does the histogram get updated on exit only? What about long running kernel threads whose will never exit? thanks, Shakeel