From: Maciej Wieczor-Retman <m.wieczorretman@pm.me>
To: andreyknvl@gmail.com, akpm@linux-foundation.org,
ryabinin.a.a@gmail.com, elver@google.com, dvyukov@google.com,
vincenzo.frascino@arm.com, urezki@gmail.com, glider@google.com
Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, m.wieczorretman@pm.me
Subject: [PATCH v1 0/2] kasan: vmalloc: Fix incorrect tag assignment with multiple vm_structs
Date: Tue, 04 Nov 2025 14:48:07 +0000 [thread overview]
Message-ID: <cover.1762267022.git.m.wieczorretman@pm.me> (raw)
A KASAN tag mismatch, possibly resulting in a kernel panic, can be
observed on systems with a tag-based KASAN enabled and with multiple
NUMA nodes. Initially it was only noticed on x86 [1] but later a similar
issue was also reported on arm64 [2].
Specifically the problem is related to how vm_structs interact with
pcpu_chunks - both when they are allocated, assigned and when pcpu_chunk
addresses are derived.
When vm_structs are allocated they are tagged if vmalloc support is
enabled along the KASAN mode. Later when first pcpu chunk is allocated
it gets its 'base_addr' field set to the first allocated vm_struct.
With that it inherits that vm_struct's tag.
When pcpu_chunk addresses are later derived (by pcpu_chunk_addr(), for
example in pcpu_alloc_noprof()) the base_addr field is used and offsets
are added to it. If the initial conditions are satisfied then some of
the offsets will point into memory allocated with a different vm_struct.
So while the lower bits will get accurately derived the tag bits in the
top of the pointer won't match the shadow memory contents.
The solution (proposed at v2 of the x86 KASAN series [3]) is to tag the
vm_structs the same when allocating them for the per cpu allocator (in
pcpu_get_vm_areas()).
Originally these patches were part of the x86 KASAN series [4].
The series is based on 6.18-rc4.
[1] https://lore.kernel.org/all/e7e04692866d02e6d3b32bb43b998e5d17092ba4.1738686764.git.maciej.wieczor-retman@intel.com/
[2] https://lore.kernel.org/all/aMUrW1Znp1GEj7St@MiWiFi-R3L-srv/
[3] https://lore.kernel.org/all/CAPAsAGxDRv_uFeMYu9TwhBVWHCCtkSxoWY4xmFB_vowMbi8raw@mail.gmail.com/
[4] https://lore.kernel.org/all/cover.1761763681.git.m.wieczorretman@pm.me/
Maciej Wieczor-Retman (2):
kasan: Unpoison pcpu chunks with base address tag
kasan: Unpoison vms[area] addresses with a common tag
include/linux/kasan.h | 10 ++++++++++
mm/kasan/common.c | 19 +++++++++++++++++++
mm/vmalloc.c | 4 +---
3 files changed, 30 insertions(+), 3 deletions(-)
--
2.51.0
next reply other threads:[~2025-11-04 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 14:48 Maciej Wieczor-Retman [this message]
2025-11-04 14:49 ` [PATCH v1 1/2] kasan: Unpoison pcpu chunks with base address tag Maciej Wieczor-Retman
2025-11-05 1:12 ` Andrey Konovalov
2025-11-05 10:39 ` Maciej Wieczor-Retman
2025-11-05 4:20 ` kernel test robot
2025-11-05 22:00 ` Lorenzo Stoakes
2025-11-06 15:00 ` Maciej Wieczór-Retman
2025-11-06 1:42 ` kernel test robot
2025-11-04 14:49 ` [PATCH v1 2/2] kasan: Unpoison vms[area] addresses with a common tag Maciej Wieczor-Retman
2025-11-05 1:13 ` Andrey Konovalov
2025-11-05 11:13 ` Maciej Wieczor-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1762267022.git.m.wieczorretman@pm.me \
--to=m.wieczorretman@pm.me \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=urezki@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox