[PATCH 0/2] change "a mm_struct" to "an mm_struct" in comment

[PATCH 0/2] change "a mm_struct" to "an mm_struct" in comment

[Joey Pabalinas]

The correct english is "an mm_struct" which is used everywhere else
in the kernel.

Joey Pabalinas (2):
  Hexagon: change "a mm_struct" to "an mm_struct" in comment
  fork: change "a mm_struct" to "an mm_struct" in comment

 arch/hexagon/include/asm/mmu.h | 2 +-
 kernel/fork.c                  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
Cheers,
Joey Pabalinas

[PATCH 1/2] Hexagon: change "a mm_struct" to "an mm_struct" in comment

[Joey Pabalinas]

The correct english is "an mm_struct" which is used everywhere else
in the kernel.

Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
---
 arch/hexagon/include/asm/mmu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/hexagon/include/asm/mmu.h b/arch/hexagon/include/asm/mmu.h
index dfa46660d695bb65b4..ce784218dc67c92a94 100644
--- a/arch/hexagon/include/asm/mmu.h
+++ b/arch/hexagon/include/asm/mmu.h
@@ -7,11 +7,11 @@
 #define _ASM_MMU_H
 
 #include <asm/vdso.h>
 
 /*
- * Architecture-specific state for a mm_struct.
+ * Architecture-specific state for an mm_struct.
  * For the Hexagon Virtual Machine, it can be a copy
  * of the pointer to the page table base.
  */
 struct mm_context {
 	unsigned long long generation;
-- 
Cheers,
Joey Pabalinas

[PATCH 2/2] fork: change "a mm_struct" to "an mm_struct" in comment

[Joey Pabalinas]

The correct english is "an mm_struct" which is used everywhere else
in the kernel.

Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
---
 kernel/fork.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index af673856499dcaa35e..9a783cd46d097a2d68 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1397,18 +1397,18 @@ static int wait_for_vfork_done(struct task_struct *child,
 	put_task_struct(child);
 	return killed;
 }
 
 /* Please note the differences between mmput and mm_release.
- * mmput is called whenever we stop holding onto a mm_struct,
+ * mmput is called whenever we stop holding onto an mm_struct,
  * error success whatever.
  *
- * mm_release is called after a mm_struct has been removed
+ * mm_release is called after an mm_struct has been removed
  * from the current process.
  *
  * This difference is important for error handling, when we
- * only half set up a mm_struct for a new process and need to restore
+ * only half set up an mm_struct for a new process and need to restore
  * the old one.  Because we mmput the new mm_struct before
  * restoring the old one. . .
  * Eric Biederman 10 January 1998
  */
 static void mm_release(struct task_struct *tsk, struct mm_struct *mm)
-- 
Cheers,
Joey Pabalinas

Re: [PATCH 0/2] change "a mm_struct" to "an mm_struct" in comment

[Lorenzo Stoakes]

On Wed, Sep 03, 2025 at 08:23:24PM -1000, Joey Pabalinas wrote:
> The correct english is "an mm_struct" which is used everywhere else
> in the kernel.

Hi Joey, this doesn't really warrant a patch, it's just not important and there
isn't great RoI on the churcn here. It is also very silly to make this two
patches, it should only be one.

Also please do run scripts/get_maintainers.pl when you're doing this, Kees is on
the list but he is joined by many esteemed kernel colleagues ;))

Ingo Molnar <mingo@redhat.com> (maintainer:SCHEDULER)
Peter Zijlstra <peterz@infradead.org> (maintainer:SCHEDULER)
Juri Lelli <juri.lelli@redhat.com> (maintainer:SCHEDULER)
Vincent Guittot <vincent.guittot@linaro.org> (maintainer:SCHEDULER)
Dietmar Eggemann <dietmar.eggemann@arm.com> (reviewer:SCHEDULER)
Steven Rostedt <rostedt@goodmis.org> (reviewer:SCHEDULER)
Ben Segall <bsegall@google.com> (reviewer:SCHEDULER)
Mel Gorman <mgorman@suse.de> (reviewer:SCHEDULER)
Valentin Schneider <vschneid@redhat.com> (reviewer:SCHEDULER)
Kees Cook <kees@kernel.org> (maintainer:EXEC & BINFMT API, ELF)
Andrew Morton <akpm@linux-foundation.org> (maintainer:MEMORY MANAGEMENT - CORE)
David Hildenbrand <david@redhat.com> (maintainer:MEMORY MANAGEMENT - CORE)
Lorenzo Stoakes <lorenzo.stoakes@oracle.com> (reviewer:MEMORY MANAGEMENT - CORE)
"Liam R. Howlett" <Liam.Howlett@oracle.com> (reviewer:MEMORY MANAGEMENT - CORE)
Vlastimil Babka <vbabka@suse.cz> (reviewer:MEMORY MANAGEMENT - CORE)
Mike Rapoport <rppt@kernel.org> (reviewer:MEMORY MANAGEMENT - CORE)
Suren Baghdasaryan <surenb@google.com> (reviewer:MEMORY MANAGEMENT - CORE)
Michal Hocko <mhocko@suse.com> (reviewer:MEMORY MANAGEMENT - CORE)
Brian Cain <bcain@kernel.org> (maintainer:QUALCOMM HEXAGON ARCHITECTURE)
linux-kernel@vger.kernel.org (open list:SCHEDULER)
linux-mm@kvack.org (open list:EXEC & BINFMT API, ELF)
linux-hexagon@vger.kernel.org (open list:QUALCOMM HEXAGON ARCHITECTURE)
EXEC & BINFMT API, ELF status: Supported
QUALCOMM HEXAGON ARCHITECTURE status: Supported

>
> Joey Pabalinas (2):
>   Hexagon: change "a mm_struct" to "an mm_struct" in comment
>   fork: change "a mm_struct" to "an mm_struct" in comment
>
>  arch/hexagon/include/asm/mmu.h | 2 +-
>  kernel/fork.c                  | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> --
> Cheers,
> Joey Pabalinas
>
>
>

So yeah I don't think we should take this, sorry! :(

Cheers, Lorenzo

Re: [PATCH 0/2] change "a mm_struct" to "an mm_struct" in comment

[Lorenzo Stoakes]

On Thu, Sep 04, 2025 at 11:46:52AM +0100, Lorenzo Stoakes wrote:
> isn't great RoI on the churcn here. It is also very silly to make this two

Oops typo - should be "isn't great RoI on the _churn_ here" :)