* [PATCH v3 0/2] minor ptdesc updates
@ 2023-11-21 19:43 Alexander Gordeev
2023-11-21 19:43 ` [PATCH v3 1/2] pgtable: fix s390 ptdesc field comments Alexander Gordeev
2023-11-21 19:43 ` [PATCH v3 2/2] pgtable: rename ptdesc _refcount field to __page_refcount Alexander Gordeev
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Gordeev @ 2023-11-21 19:43 UTC (permalink / raw)
To: Andrew Morton, Vishal Moola
Cc: linux-mm, linux-s390, linux-kernel, Gerald Schaefer, Heiko Carstens
Hi Vishal, Andrew,
Please find v3 of s390-caused ptdesc updates.
Changes since v2:
- single patch split in two;
- _refcount renamed to __page_refcount;
- _refcount TABLE_MATCH() check restored;
Changes since v1:
- missing comment to _pt_pad_3 padding added;
Thanks!
Alexander Gordeev (2):
pgtable: fix s390 ptdesc field comments
pgtable: rename ptdesc _refcount field to __page_refcount
include/linux/mm_types.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/2] pgtable: fix s390 ptdesc field comments
2023-11-21 19:43 [PATCH v3 0/2] minor ptdesc updates Alexander Gordeev
@ 2023-11-21 19:43 ` Alexander Gordeev
2023-11-21 19:43 ` [PATCH v3 2/2] pgtable: rename ptdesc _refcount field to __page_refcount Alexander Gordeev
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Gordeev @ 2023-11-21 19:43 UTC (permalink / raw)
To: Andrew Morton, Vishal Moola
Cc: linux-mm, linux-s390, linux-kernel, Gerald Schaefer, Heiko Carstens
Since commit d08d4e7cd6bf ("s390/mm: use full 4KB page for 2KB PTE")
there is no fragmented page tracking on s390. Fix the corresponding
comments.
Suggested-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
---
include/linux/mm_types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 957ce38768b2..fbec64036baa 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -401,11 +401,11 @@ FOLIO_MATCH(compound_head, _head_2a);
* @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs.
* @__page_mapping: Aliases with page->mapping. Unused for page tables.
* @pt_mm: Used for x86 pgds.
- * @pt_frag_refcount: For fragmented page table tracking. Powerpc and s390 only.
+ * @pt_frag_refcount: For fragmented page table tracking. Powerpc only.
* @_pt_pad_2: Padding to ensure proper alignment.
* @ptl: Lock for the page table.
* @__page_type: Same as page->page_type. Unused for page tables.
- * @_refcount: Same as page refcount. Used for s390 page tables.
+ * @_refcount: Same as page refcount.
* @pt_memcg_data: Memcg data. Tracked for page tables here.
*
* This struct overlays struct page for now. Do not modify without a good
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v3 2/2] pgtable: rename ptdesc _refcount field to __page_refcount
2023-11-21 19:43 [PATCH v3 0/2] minor ptdesc updates Alexander Gordeev
2023-11-21 19:43 ` [PATCH v3 1/2] pgtable: fix s390 ptdesc field comments Alexander Gordeev
@ 2023-11-21 19:43 ` Alexander Gordeev
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Gordeev @ 2023-11-21 19:43 UTC (permalink / raw)
To: Andrew Morton, Vishal Moola
Cc: linux-mm, linux-s390, linux-kernel, Gerald Schaefer, Heiko Carstens
Rename ptdesc _refcount field to __page_refcount similar
to the other unused page fields.
Suggested-by: Vishal Moola <vishal.moola@gmail.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
---
include/linux/mm_types.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index fbec64036baa..ef18d2b25378 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -405,7 +405,7 @@ FOLIO_MATCH(compound_head, _head_2a);
* @_pt_pad_2: Padding to ensure proper alignment.
* @ptl: Lock for the page table.
* @__page_type: Same as page->page_type. Unused for page tables.
- * @_refcount: Same as page refcount.
+ * @__page_refcount: Same as page refcount.
* @pt_memcg_data: Memcg data. Tracked for page tables here.
*
* This struct overlays struct page for now. Do not modify without a good
@@ -438,7 +438,7 @@ struct ptdesc {
#endif
};
unsigned int __page_type;
- atomic_t _refcount;
+ atomic_t __page_refcount;
#ifdef CONFIG_MEMCG
unsigned long pt_memcg_data;
#endif
@@ -452,7 +452,7 @@ TABLE_MATCH(compound_head, _pt_pad_1);
TABLE_MATCH(mapping, __page_mapping);
TABLE_MATCH(rcu_head, pt_rcu_head);
TABLE_MATCH(page_type, __page_type);
-TABLE_MATCH(_refcount, _refcount);
+TABLE_MATCH(_refcount, __page_refcount);
#ifdef CONFIG_MEMCG
TABLE_MATCH(memcg_data, pt_memcg_data);
#endif
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 19:43 [PATCH v3 0/2] minor ptdesc updates Alexander Gordeev
2023-11-21 19:43 ` [PATCH v3 1/2] pgtable: fix s390 ptdesc field comments Alexander Gordeev
2023-11-21 19:43 ` [PATCH v3 2/2] pgtable: rename ptdesc _refcount field to __page_refcount Alexander Gordeev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox