From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1523BC41513 for ; Fri, 13 Oct 2023 11:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C0E480014; Fri, 13 Oct 2023 07:36:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6493E8D0015; Fri, 13 Oct 2023 07:36:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E9E180014; Fri, 13 Oct 2023 07:36:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3A0488D0015 for ; Fri, 13 Oct 2023 07:36:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0CF88140234 for ; Fri, 13 Oct 2023 11:36:31 +0000 (UTC) X-FDA: 81340235382.19.8E2D8C0 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf26.hostedemail.com (Postfix) with ESMTP id 50F8314000D for ; Fri, 13 Oct 2023 11:36:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ho9COROt; spf=pass (imf26.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697196989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=AwW9if9WNdP6Sajk9KGlxQoZKY2rQ8Xoex/2T06qWZM=; b=zK2J6qif4IQW+b48i7fI+iorJ04D9RSjyN7YXwRfhsb8npc6aGoPHl9qJ/qDTeuukr49L4 y2J8dA1E1Dw60r01NLAxvy2uGRhKozURTr7XpZXEEe/ki19pvDbW2gqqzsVS9gy9GkwqP1 0LnxThnKNfxdhr8VDHncG8mpLQvdoe8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697196989; a=rsa-sha256; cv=none; b=c3WxpaFz84zIxI8aoWJcz1izOfX9MeMV9Ye3Mz5+coe6pxLWHQIq7xq40HqBFi5KS8jJN4 Wy+bfSTej63fXIWOcT+9GE9DB0Nhk4YoTVp1UMM/+/CVqJS/ClGJ/9Ht/4nT5mhD229OFm 83UcoU1ZLq9o9qMk0svGwXcs9PSzA84= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ho9COROt; spf=pass (imf26.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697196988; x=1728732988; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3kHNtyQVnjAw9mhsimssz82xFGGV/T8R0wPGXi0ez5k=; b=ho9COROtU7NDQFxLqUsfy+O/PcbuJEOSm/vDfF3wrQQFfWiBRMPYG/3T 7ljXbWe8dTwmfMh+l0bGluu8U8i4swWLl6R7QS1z+EWPjsImRbEkihgGJ 8ZrXPC08LRvdH1ouQYXz6I7Dyqq1iWEaFzokXQMdx4L9z67zgSDi+7w7X bczlIpwe2HKR1uKetvhjQ/1RwuGy5T8/sHJ7kP4tuECGZb0YEdeiyrH2v /+5meTFmrWa3z4hkSHEAp1jbUV+jNGJgu7rNkJ4DTrD7fePziW+JrNWcX pSQQkXmBySxr2w62Iorlw1SacmPQAnbabirw1/1CbbpFeX5gOR3ZDI8+f g==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="382391389" X-IronPort-AV: E=Sophos;i="6.03,222,1694761200"; d="scan'208";a="382391389" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2023 04:36:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="1001916985" X-IronPort-AV: E=Sophos;i="6.03,222,1694761200"; d="scan'208";a="1001916985" Received: from bsankiew-mobl.ger.corp.intel.com (HELO wieczorr-mobl1.intel.com) ([10.213.0.114]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2023 04:36:18 -0700 From: Maciej Wieczor-Retman To: akpm@linux-foundation.org, christian@kellner.me, fenghua.yu@intel.com, keescook@chromium.org, ndesaulniers@google.com, coltonlewis@google.com, dmatlack@google.com, vipinsh@google.com, seanjc@google.com, brauner@kernel.org, pbonzini@redhat.com, shuah@kernel.org, hannes@cmpxchg.org, nphamcs@gmail.com, reinette.chatre@intel.com Cc: ilpo.jarvinen@linux.intel.com, linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v6 0/8] Add printf attribute to kselftest functions Date: Fri, 13 Oct 2023 13:36:04 +0200 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: hphqq84e7pw3r1ukxetews95izirc934 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 50F8314000D X-Rspam-User: X-HE-Tag: 1697196988-157131 X-HE-Meta: U2FsdGVkX19WTtX0/nIlbrlMj3d+Ar1LZtNpfsqoRB8ms6AT4V4oJinyN6Znh/pPNKX8xhRjrRjPgRGGfUNxOQYfmkWr53lcptZcQfxCMIkTwYSRx/kSt5F55O545HwbmB6U0MsgCuZQ1bUXt5/NtTzYJ4wUmUQfiUTUHYgcjfD2zfgA/kklTTPyBnAnqanloxnARg1JDvbApaD08CbIG4uts1kdXQ2xlalLktXYAWxiF6gN5xGlj62xNkPU9TAyf8w+qtXwsdioeV0nUuAtDu25IfCpt+OTOJoH8gXCl5efWHsWJRPd9Ni5LJ2oWCpfxPc874ZpG6+4QVAGgrpfDprFap3gExqbGGDIla6lH99uVkqRXYk2ezu4BALvESNYANCC9JJvY6sKErq5G7ICoMrfOg4UuQ7gTcSAUXVPwEbqxHmd7P+MCSml3FFTuljgeF9RE6yyxBoiOcfkjBijQUWZ1gsV3fCZG5XyCZFSqpR7zASVVrMk1KPABZLfR9SPDSni27ASbvVUyA2LMVTrscK7W4mYFSYWLxp1GVj2bQGpNEGJzynfkiKa/5XeQEsdd5jvCQIm/TcmQB0QvW6TKmisd9zT1ecmyrMKraOOQK6zcJQFy9ftSdtJOYZj5iUB7P6HrzOkaAdeSfFgyVQri3AvsMT8YL/5u9GOwtK/pqIOmgeBLy+r+kIjcGT2wilBu0Bf9MsUuFgEYsNvGhFaHn5SBnyEvDUtQ863AJg0E3wzLwuIPAyLM+nhYqzbET9uXET7hzoaKVjMTlvouzNnwv1D9h14ZEQoQ7sW8CAxUlFXt0IsnkOGfOd1o/OWA7+XVkW1HiCUYNCyZL4R0O1Cphfy/JJJJVgj/fS2iAof9ACyTkSVZNmLkG9NzUgenzS8iEo0grQpPMyCz65BSUJtNmWcy7acWOKbSWskTWVRI18hCNW5iSnR5WUm3Z5b512HwW24RaGm1fblDvZMx4h RnBdo+Po pNIJm2htijchPGnSoNGsJX4HIxeZj1UWaV7Utv0HdRVK5NTZeEUp2aVmnz2Erec6Q8EJCQjfZ4YSaD//RYx5+HNiPZcq0uNcmFMhtvN4OddR8MOCziu/aZdt6A8jcXmgfMh+8/vgyCUEPPb69Oe3w575c3VAFxbwQrtRDg/U4OIthxdNAAX1xI99Mxmw/kRylKoPj3FN5vOU3PgQyaSyTSPB10b20HLENAzbJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: kselftest.h declares many variadic functions that can print some formatted message while also executing selftest logic. These declarations don't have any compiler mechanism to verify if passed arguments are valid in comparison with format specifiers used in printf() calls. Attribute addition can make debugging easier, the code more consistent and prevent mismatched or missing variables. The first patch adds __printf() macro and applies it to all functions in kselftest.h that use printf format specifiers. After compiling all selftests using: make -C tools/testing/selftests many instances of format specifier mismatching are exposed in the form of -Wformat warnings. Fix the mismatched format specifiers caught by __printf() attribute in multiple tests. Series is based on kselftests next branch. Changelog v6: - Add methodology notes to all patches. - No functional changes in the patches. Changelog v5: - Mention in the cover letter what methodology was used to find the mismatched format specifiers. - No functional changes in the patches. Changelog v4: - Fix patch 1/8 subject typo. - Add Reinette's reviewed-by tags. - Rebase onto new kselftest/next patches. Changelog v3: - Changed git signature from Wieczor-Retman Maciej to Maciej Wieczor-Retman. - Added one review tag. - Rebased onto updated kselftests next branch. Changelog v2: - Add review and fixes tags to patches. - Add two patches with mismatch fixes. - Fix missed attribute in selftests/kvm. (Andrew) - Fix previously missed issues in selftests/mm (Ilpo) [v5] https://lore.kernel.org/all/cover.1697012398.git.maciej.wieczor-retman@intel.com/ [v4] https://lore.kernel.org/all/cover.1696846568.git.maciej.wieczor-retman@intel.com/ [v3] https://lore.kernel.org/all/cover.1695373131.git.maciej.wieczor-retman@intel.com/ [v2] https://lore.kernel.org/all/cover.1693829810.git.maciej.wieczor-retman@intel.com/ [v1] https://lore.kernel.org/all/cover.1693216959.git.maciej.wieczor-retman@intel.com/ Maciej Wieczor-Retman (8): selftests: Add printf attribute to kselftest prints selftests/cachestat: Fix print_cachestat format selftests/openat2: Fix wrong format specifier selftests/pidfd: Fix ksft print formats selftests/sigaltstack: Fix wrong format specifier selftests/kvm: Replace attribute with macro selftests/mm: Substitute attribute with a macro selftests/resctrl: Fix wrong format specifier .../selftests/cachestat/test_cachestat.c | 2 +- tools/testing/selftests/kselftest.h | 18 ++++++++++-------- .../testing/selftests/kvm/include/test_util.h | 8 ++++---- tools/testing/selftests/mm/mremap_test.c | 2 +- tools/testing/selftests/mm/pkey-helpers.h | 2 +- tools/testing/selftests/openat2/openat2_test.c | 2 +- .../selftests/pidfd/pidfd_fdinfo_test.c | 2 +- tools/testing/selftests/pidfd/pidfd_test.c | 12 ++++++------ tools/testing/selftests/resctrl/cache.c | 2 +- tools/testing/selftests/sigaltstack/sas.c | 2 +- 10 files changed, 27 insertions(+), 25 deletions(-) base-commit: 2531f374f922e77ba51f24d1aa6fa11c7f4c36b8 -- 2.42.0